Skip to content

Baro: Initial R3 Driver Implementation - #140

Draft
266-750Balloons wants to merge 2 commits into
mainfrom
feature/DS/r3-baro
Draft

Baro: Initial R3 Driver Implementation#140
266-750Balloons wants to merge 2 commits into
mainfrom
feature/DS/r3-baro

Conversation

@266-750Balloons

Copy link
Copy Markdown

Description

For now, it's just minor cleanup that isn't even R3 specific; it just happened to occur during R3 baro bringup.

Issue Link

Related to SunDevilRocketry/driver#8 and SunDevilRocketry/driver#49.

Testing

  • Passes existing unit tests
  • Unit tests modified (link the test changes as a child PR)
  • Integration test performed

Attach any test artifacts here, if relevant.

Other

Leave any additional notes here

Reviewer Checklist

Standards

  • Follows FCF Architectural Standards
  • Follows SDR Coding Standards
  • Code complexity/function Size is minimized
  • Code is testable
  • Code is readable and commented properly
  • License terms are respected

Error Handling

  • Potentially unsafe functions return a status code
  • Error returns properly handled

Memory

  • Stack allocated memory is scoped correctly
  • Heap allocated memory is avoided
  • Globally allocated memory is minimized except when necessary
  • Pointers are used correctly
  • Concurrency has been considered

Performance

  • Rate limiters are respected
  • Busy waiting is avoided
  • "Delay" calls are not used in performance sensitive code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant