Repository navigation
deps: rustix 1.1.6 (RUSTSEC-2026-0486); the desktop lock catches up - #88
SovereignTechnology wants to merge 3 commits into
Conversation
RUSTSEC-2026-0486 (published 2026-11-16) marks rustix 1.1.5 unsound: its xattr functions mark unwritten bytes initialized when given a zero-length buffer. nfx reaches rustix through iroh-blobs > reflink-copy and never calls the xattr functions, but cargo deny fails every CI check on the advisory. Fixed in 1.1.6. crates/desktop/Cargo.lock also gains cipher 0.5.2 and inout 0.2.6: nfx-proto has needed them since #75 (chacha20 0.10 for NIP-44), and the desktop workspace's lock had not been refreshed. No manifest changes; the money crates' locked closure (crates/ci/locked-compiled.txt) has no rustix and is unchanged.
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters: 2
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including
|
|
Updates both workspace lockfiles to rustix 1.1.6 to clear RUSTSEC-2026-0486, without changing manifests or the money-crate lock list.
Needs changes: reconcile the lockfile diff with the stated scope—either regenerate it to the intended updates or document the additional |
…c so check can pass
|
CI diagnosis for run 43793743809 The failing jobs/steps are Root cause: the updated lockfile brings The In the diff, the Smallest fix: after reviewing the added Windows-only transitive dependencies, regenerate |
…2), so the money crates' closure is unchanged cargo update -p rustix --precise 1.1.6 had moved rustix's windows-sys to 0.52.0, which brought windows-sys 0.52 and windows-targets 0.52.6 into what the money crates are built from, and the lock job refused it. Both locks are validated with cargo metadata --locked --offline.
|
CI diagnosis for run 43793803794 (failed head The failing jobs/steps are Root cause: the dependency update changes the money crates’ resolved Windows dependency closure, but The The lockfile diff shows the source of the extra version: Smallest fix: review the added Windows-only transitive dependencies, then regenerate |
…sktop lock's missing cipher/inout) 093f469 still left errno 0.3.14, rustls-platform-verifier 0.7.0 and winapi-util 0.1.11 on windows-sys 0.52.0 (moved by the same cargo update), so the money crates' closure still differed. Now crates/Cargo.lock differs from main in rustix's version and checksum only, and crates/desktop/Cargo.lock adds cipher 0.5.2 and inout 0.2.6 and the same rustix bump, with no windows-sys line changed. Both validated with cargo metadata --locked --offline.
…anged) into nfxd/mesh-public
…anged) into web/85-ask-the-origin
|
CI diagnosis for run 43799699433 The failing jobs/steps are Root cause: the lockfile update changes the money crates’ resolved Windows dependency closure, but The logs report: In the lockfile, Smallest fix: after reviewing the added Windows-only transitive dependencies, re-pin locally outside CI with |
) RUSTSEC-2026-0486 (published 2026-11-16) marks rustix 1.1.5 unsound: its xattr functions mark unwritten bytes initialized when given a zero-length buffer. nfx reaches rustix through iroh-blobs > reflink-copy and never calls the xattr functions, but cargo deny failed every CI check on the advisory. Fixed in 1.1.6. - crates/Cargo.lock differs from main in rustix's version and checksum only. rustix keeps windows-sys 0.61.2 (its range is >=0.52, <0.62): a plain `cargo update -p rustix` had also moved rustix, errno, rustls-platform-verifier and winapi-util to windows-sys 0.52.0, which changed the money crates' closure, and the lock job refused it. Both locks were rebuilt from main and validated with `cargo metadata --locked --offline`. - crates/desktop/Cargo.lock also gains cipher 0.5.2 and inout 0.2.6, which nfx-proto has needed since #75 (chacha20 0.10 for NIP-44); the desktop workspace's lock had not been refreshed. No windows-sys line changed. - No manifest changes; the money crates' locked closure (crates/ci/locked-compiled.txt) is unchanged.
|
Squash-merged as a75b0d2 |
RUSTSEC-2026-0486 (published 2026-11-16) marks rustix 1.1.5 unsound: its xattr functions mark unwritten bytes as initialized when given a zero-length buffer.
cargo deny check advisoriesnow fails thecheckjob on every PR and on main. This PR moves rustix to 1.1.6, where the issue is fixed.nfx-node→iroh-blobs→reflink-copy→ rustix. nfx never calls the xattr functions, but the advisory gates CI.crates/Cargo.lock: only rustix 1.1.5 → 1.1.6 changes.crates/desktop/Cargo.lock: rustix 1.1.6, and the lock also catches up withcipher0.5.2 andinout0.2.6. nfx-proto has needed both since feat(spec): signaling over Nostr (NFX-10 §6), its vectors, and nfx-proto's reader (#71) #75 (chacha20 0.10 for NIP-44), and the desktop workspace's lock had not been refreshed.crates/ci/locked-compiled.txt) contains no rustix and is unchanged; thelockjob proves it.Seen as the failing
checkon #86 (run 43788310088).