Skip to content

deps: rustix 1.1.6 (RUSTSEC-2026-0486); the desktop lock catches up - #88

Closed
SovereignTechnology wants to merge 3 commits into
mainfrom
deps/rustix-1.1.6
Closed

SovereignTechnology wants to merge 3 commits into
mainfrom
deps/rustix-1.1.6

Conversation

@SovereignTechnology

Copy link
Copy Markdown
Owner

RUSTSEC-2026-0486 (published 2026-11-16) marks rustix 1.1.5 unsound: its xattr functions mark unwritten bytes as initialized when given a zero-length buffer. cargo deny check advisories now fails the check job on every PR and on main. This PR moves rustix to 1.1.6, where the issue is fixed.

  • How nfx reaches it: nfx-node → iroh-blobs → reflink-copy → rustix. nfx never calls the xattr functions, but the advisory gates CI.
  • crates/Cargo.lock: only rustix 1.1.5 → 1.1.6 changes.
  • crates/desktop/Cargo.lock: rustix 1.1.6, and the lock also catches up with cipher 0.5.2 and inout 0.2.6. nfx-proto has needed both since feat(spec): signaling over Nostr (NFX-10 §6), its vectors, and nfx-proto's reader (#71) #75 (chacha20 0.10 for NIP-44), and the desktop workspace's lock had not been refreshed.
  • No manifest changes. The money crates' locked closure (crates/ci/locked-compiled.txt) contains no rustix and is unchanged; the lock job proves it.

Seen as the failing check on #86 (run 43788310088).

RUSTSEC-2026-0486 (published 2026-11-16) marks rustix 1.1.5 unsound: its xattr functions mark unwritten
bytes initialized when given a zero-length buffer. nfx reaches rustix through iroh-blobs > reflink-copy
and never calls the xattr functions, but cargo deny fails every CI check on the advisory. Fixed in 1.1.6.

crates/desktop/Cargo.lock also gains cipher 0.5.2 and inout 0.2.6: nfx-proto has needed them since #75
(chacha20 0.10 for NIP-44), and the desktop workspace's lock had not been refreshed. No manifest changes;
the money crates' locked closure (crates/ci/locked-compiled.txt) has no rustix and is unchanged.
@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters: 2

  • crates/Cargo.lock is excluded by !**/*.lock
  • crates/desktop/Cargo.lock is excluded by !**/*.lock

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 3086da2b-f337-4217-880d-5115e67af513

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@sovtechpro sovtechpro Bot added the size/XS Lines changed by this pull request: XS (sovtechpro[bot]) label Nov 16, 2026
@sovtechpro

sovtechpro Bot commented Nov 16, 2026

Copy link
Copy Markdown

Updates both workspace lockfiles to rustix 1.1.6 to clear RUSTSEC-2026-0486, without changing manifests or the money-crate lock list.
The security bump is targeted, but the diff also contains dependency-resolution changes beyond those described in the PR.

  • Security: rustix 1.1.5 is replaced by 1.1.6, with new checksums, in crates/Cargo.lock:4220 and crates/desktop/Cargo.lock:5395. That is the appropriate fix for the advisory; no affected xattr call sites are introduced here.
  • Breaking-change / scope risk: crates/Cargo.lock:1354 is one of four non-rustix edges changed from windows-sys 0.61.2 to 0.52.0, contradicting the statement that this lockfile changes only rustix. The desktop lock also adds getrandom 0.4.3 and portmapper to nfx-node (crates/desktop/Cargo.lock:3943, crates/desktop/Cargo.lock:3955) and rewrites several other windows-sys edges. These may be valid stale-lock catch-up rather than new manifest requirements, but they broaden the update and need to be explained or removed by regenerating the locks minimally.
  • Missing tests / validation: no test changes are expected for a lock-only advisory bump, but the extra graph drift means the advisory check alone is insufficient validation. Before merge, CI should demonstrate that both workspaces still check/build, including the desktop dependency graph and Windows-specific resolution affected by these edits.

Needs changes: reconcile the lockfile diff with the stated scope—either regenerate it to the intended updates or document the additional nfx-node and windows-sys changes and provide CI validation for them.

@sovtechpro

sovtechpro Bot commented Nov 16, 2026

Copy link
Copy Markdown

CI diagnosis for run 43793743809

The failing jobs/steps are lock / lock (job 133057762347) and check / check (job 133057762627). Both exit 1 in the final locked paths validation.

Root cause: the updated lockfile brings windows-sys 0.52.0 into the money crates’ resolved dependency closure, while crates/ci/locked-compiled.txt still pins only windows-sys 0.61.2. That additional edge also brings in windows-targets 0.52.6 and its eight windows_* 0.52.6 architecture crates. This is deterministic dependency-pin drift, not a test or infrastructure failure.

The lock log reports:

locked paths: 44 guarded files and sections match their pins
locked paths: what the money crates are built from differs from its pins:
+ money-dep windows-sys 0.52.0 registry+https://github.com/rust-lang/crates.io-index ...
+ money-dep windows-sys 0.61.2 registry+https://github.com/rust-lang/crates.io-index ...
+ money-dep windows-targets 0.52.6 registry+https://github.com/rust-lang/crates.io-index ...

In the diff, the rustix 1.1.6 package selects "windows-sys 0.52.0" at crates/Cargo.lock:4229; crates/Cargo.lock:1354 is one of three other edges switched from 0.61.2 to 0.52.0. The check log otherwise reports advisories ok, bans ok, licenses ok, sources ok, and its WASM suites pass before the same pin mismatch.

Smallest fix: after reviewing the added Windows-only transitive dependencies, regenerate crates/ci/locked-compiled.txt against this branch’s crates/Cargo.lock and commit the resulting entries for both windows-sys versions, windows-targets 0.52.6, and the eight architecture crates. Also update the PR description’s statement that the money-crate lock list is unchanged; no manifest change is needed for this CI failure.

…2), so the money crates' closure is unchanged

cargo update -p rustix --precise 1.1.6 had moved rustix's windows-sys to 0.52.0, which brought windows-sys 0.52 and
windows-targets 0.52.6 into what the money crates are built from, and the lock job refused it. Both locks are
validated with cargo metadata --locked --offline.
@sovtechpro

sovtechpro Bot commented Nov 16, 2026

Copy link
Copy Markdown

CI diagnosis for run 43793803794 (failed head 1f610d).

The failing jobs/steps are lock / lock (job 133057953995) and check / check (job 133057953835). Both exit 1 in the final locked paths validation.

Root cause: the dependency update changes the money crates’ resolved Windows dependency closure, but crates/ci/locked-compiled.txt still contains the old money-dep pins. The new closure adds windows-sys 0.52.0, windows-targets 0.52.6, and eight architecture-specific windows_* 0.52.6 packages; this is deterministic pin drift, not a flaky or infrastructural failure.

The lock log reports:

locked paths: 44 guarded files and sections match their pins
locked paths: what the money crates are built from differs from its pins:
- money-dep windows-sys 0.61.2 registry+https://github.com/rust-lang/crates.io-index ...
+ money-dep windows-sys 0.52.0 registry+https://github.com/rust-lang/crates.io-index ...
+ money-dep windows-sys 0.61.2 registry+https://github.com/rust-lang/crates.io-index ...
+ money-dep windows-targets 0.52.6 registry+https://github.com/rust-lang/crates.io-index ...

The lockfile diff shows the source of the extra version: crates/Cargo.lock:1354 switches a dependency edge from windows-sys 0.61.2 to 0.52.0, and the failed head’s rustix entry does likewise at crates/Cargo.lock:4229. Before reaching the same mismatch, the check log reports advisories ok, bans ok, licenses ok, sources ok, and its WASM suites pass.

Smallest fix: review the added Windows-only transitive dependencies, then regenerate crates/ci/locked-compiled.txt against this branch’s crates/Cargo.lock and commit the refreshed money-dep entries. No manifest change is needed for this CI failure; the PR description’s claim that the money-crate lock list is unchanged should also be corrected.

…sktop lock's missing cipher/inout)

093f469 still left errno 0.3.14, rustls-platform-verifier 0.7.0 and winapi-util 0.1.11 on windows-sys 0.52.0 (moved
by the same cargo update), so the money crates' closure still differed. Now crates/Cargo.lock differs from main in
rustix's version and checksum only, and crates/desktop/Cargo.lock adds cipher 0.5.2 and inout 0.2.6 and the same
rustix bump, with no windows-sys line changed. Both validated with cargo metadata --locked --offline.
@sovtechpro

sovtechpro Bot commented Nov 16, 2026

Copy link
Copy Markdown

CI diagnosis for run 43799699433

The failing jobs/steps are check / check (job 133076611258) and lock / lock (job 133076611565). Both exit 1 in the locked-path dependency validation.

Root cause: the lockfile update changes the money crates’ resolved Windows dependency closure, but crates/ci/locked-compiled.txt still pins the old closure. The resolved graph now has both windows-sys 0.52.0 and 0.61.2, plus windows-targets 0.52.6 and eight architecture-specific windows_* 0.52.6 crates. This is deterministic dependency-pin drift, not a flaky or infrastructural failure.

The logs report:

locked paths: 44 guarded files and sections match their pins
locked paths: what the money crates are built from differs from its pins:
+ money-dep windows-sys 0.52.0 registry+https://github.com/rust-lang/crates.io-index ...
+ money-dep windows-sys 0.61.2 registry+https://github.com/rust-lang/crates.io-index ...
+ money-dep windows-targets 0.52.6 registry+https://github.com/rust-lang/crates.io-index ...

In the lockfile, crates/Cargo.lock:1354 switches a dependency edge from windows-sys 0.61.2 to 0.52.0; the rustix entry does likewise at crates/Cargo.lock:4229. Before reaching the same mismatch, the check job’s visible cargo-deny checks and WASM suites pass.

Smallest fix: after reviewing the added Windows-only transitive dependencies, re-pin locally outside CI with LOCKED_DIRS_UNLOCKED=1 crates/ci/check-locked.sh --pin, then commit the regenerated crates/ci/locked-compiled.txt and crates/ci/locked.sha256. No manifest change is needed for this CI failure.

SovereignTechnology added a commit that referenced this pull request Nov 16, 2026
)

RUSTSEC-2026-0486 (published 2026-11-16) marks rustix 1.1.5 unsound: its xattr functions mark unwritten
bytes initialized when given a zero-length buffer. nfx reaches rustix through iroh-blobs > reflink-copy and
never calls the xattr functions, but cargo deny failed every CI check on the advisory. Fixed in 1.1.6.

- crates/Cargo.lock differs from main in rustix's version and checksum only. rustix keeps windows-sys 0.61.2
  (its range is >=0.52, <0.62): a plain `cargo update -p rustix` had also moved rustix, errno,
  rustls-platform-verifier and winapi-util to windows-sys 0.52.0, which changed the money crates' closure,
  and the lock job refused it. Both locks were rebuilt from main and validated with
  `cargo metadata --locked --offline`.
- crates/desktop/Cargo.lock also gains cipher 0.5.2 and inout 0.2.6, which nfx-proto has needed since #75
  (chacha20 0.10 for NIP-44); the desktop workspace's lock had not been refreshed. No windows-sys line changed.
- No manifest changes; the money crates' locked closure (crates/ci/locked-compiled.txt) is unchanged.
@SovereignTechnology

Copy link
Copy Markdown
Owner Author

Squash-merged as a75b0d2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Lines changed by this pull request: XS (sovtechpro[bot])

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant