Skip to content

release: NFX 0.1.2, nfxd serves browsers through NATs with Nostr signaling - #92

Open
SovereignTechnology wants to merge 1 commit into
mainfrom
release/0.1.2
Open

SovereignTechnology wants to merge 1 commit into
mainfrom
release/0.1.2

Conversation

@SovereignTechnology

@SovereignTechnology SovereignTechnology commented Nov 16, 2026 •

Copy link
Copy Markdown
Owner

NFX 0.1.2: nfxd serves browsers directly, through NATs, with Nostr relays as the only signaling path (its mesh endpoint, #82 and #86, NFX-10 §6), plus --stun (#74), seeders that hold only some renditions (#77), the one-rendition packaging default (#76), --iroh-bind/--iroh-external and --bridge-public for seeders behind a NAT or a DNAT (#47, #48), a fetch deadline that grows with the transfer (#70), and rustix 1.1.6 (#88).

  • Versions: nfxd, nfx-node and nfx-media are 0.1.2 (the release workflow reads the version from nfxd's and nfx-media's manifests and requires the tag to match), with the workspace pin of nfx-node and the desktop pin of nfxd to match. The same files release: NFX 0.1.1, the relay searches a video's title #27 touched for 0.1.1.
  • Cargo.lock: five lines, each a version = "0.1.1" → "0.1.2" of one of those three crates: nfx-media, nfx-node and nfxd in crates/Cargo.lock, and nfx-node and nfxd in crates/desktop/Cargo.lock. No checksum, dependency or other package line changes.
  • No locked path moves. nfx-pay and nfx-pay-wire do not depend on these three crates, so crates/ci/locked-compiled.txt is unchanged and needs no re-pin; release.yml and crates/ci/locked.sha256 are untouched.
  • docs/nfx/releases/v0.1.2.md: what changed; what operators change (three defaults moved: one rendition from nfx-package, up to 60 s waiting for an iroh relay where 0.1.1 waited 10 s, SIGTERM as a clean shutdown; and a scoped NFX-04 relay cannot be a mesh relay); what was tested (the NAT test's four cells from run 42790887367, the Nostr-only browser and nfxd runs, the Rust and web tests); what it does not do (payments; nfxd fetching from browsers, Hole-punch browsers and NFX clients behind NAT over Nostr (no TURN; STUN from NFX runners) #71; nfxd behind a symmetric NAT; fetch throughput, nfxd fetches at ~17–26 Mbit/s where the nutflix-pear iroh helper reaches 420–500 on the same links #21); and the signed-notice verify lines.
  • README: the status paragraph says 0.1.2.

After merge: tag v0.1.2 (annotated, as v0.1.1) on the merged commit, which builds a DRAFT release; signing the notice and publishing stay with the maintainer.

Note: main's check at 8202c7a failed once on a port race in nfxd's a_seeder_waits_for_an_iroh_relay_that_comes_up_late_and_then_seeds_through_it ("Address already in use"). It is not touched here; if it recurs, the job is re-run.

Merge pick: squash (one commit).

Summary by CodeRabbit

  • New Features
    • Browsers can connect directly to the service through NATs, using Nostr relays for signaling.
    • Packaging now defaults to a single video rendition.
  • Documentation
    • Added release notes covering connection and network settings, partial-rendition seeding, and updated relay-wait and fetch-resume behavior.
    • Documented testing with the desktop app and browsers behind NATs, including connections over TLS relays, along with known limitations.

…aling

nfxd's mesh endpoint (#82, #86) is a full-ICE WebRTC peer that meets browsers in the rooms of the
renditions it holds through ordinary Nostr relays (NFX-10 §6), with no tracker and no TURN. With it
come --stun (#74), seeders that hold only some renditions (#77), the one-rendition packaging
default (#76), --iroh-bind, --iroh-external and --bridge-public for seeders behind a NAT or a DNAT
(#47, #48), a fetch deadline that grows with the transfer (#70), and rustix 1.1.6 (#88).

The crates nfxd, nfx-node and nfx-media are 0.1.2 (the release workflow reads the version from
nfxd's and nfx-media's manifests and requires the tag to name it), with the workspace and desktop
dependency pins and both Cargo.lock files to match: five version lines, nothing else. The release
notes docs/nfx/releases/v0.1.2.md say what changed, what operators change, what was tested (the
NAT test's four cells, the Nostr-only browser and nfxd runs), what is left out (payments, nfxd
fetching from browsers, nfxd behind a symmetric NAT, fetch throughput), and how to verify the
signed notice. The README's status paragraph says 0.1.2. No locked path moves: the money crates do
not depend on these three, locked-compiled.txt is unchanged, and release.yml is unchanged.
@sovtechpro sovtechpro Bot added the size/M Lines changed by this pull request: M (sovtechpro[bot]) label Nov 16, 2026
@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The README and crate manifests update to version 0.1.2. New release notes describe release features, configuration, operator guidance, test results, limitations, and artifact verification.

Changes: NFX 0.1.2 release

Layer / File(s) Summary
Node and packaging capabilities
docs/nfx/releases/v0.1.2.md
The release notes describe mesh signaling and segment service, STUN responses, rendition selection, node configuration, relay startup behavior, fetch retries, and shutdown.
Protocol and browser integration
docs/nfx/releases/v0.1.2.md
The release notes describe specification and protocol support for signaling and rendition selection, plus browser player behavior.
Operations and test coverage
docs/nfx/releases/v0.1.2.md
The release notes provide operator guidance, test outcomes and coverage, limitations, and a link to testnet service information.
Release versions and verification
README.md, crates/Cargo.toml, crates/desktop/Cargo.toml, crates/nfx-media/Cargo.toml, crates/nfx-node/Cargo.toml, crates/nfxd/Cargo.toml, docs/nfx/releases/v0.1.2.md
The README and crate manifests identify version 0.1.2. The release notes document dependency updates and release artifact verification.

Estimated code review effort: 2 (Simple) | ~15 minutes

Change: Other

Possibly related PRs

  • SovereignTechnology/nfx#86: Adds a mesh endpoint public-address option for DNAT, which is related to the DNAT settings documented in this release.
Merge Risk: Minimal · up to 8ee86

This release prep updates versions and adds release notes without changing runtime code. No concrete merge-blocking risk was found.

Security architecture risk: Minimal · up to 8ee86

This PR updates release versions and documents capabilities already present at its base. No introduced or worsened architecture-level security risk was established.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the release (NFX 0.1.2) and the headline behavior: nfxd serving browsers through NATs with Nostr signaling. The raw summary and objectives confirm that the version bumps across Cargo m…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the release (NFX 0.1.2) and the headline behavior: nfxd serving browsers through NATs with Nostr signaling. The raw summary and objectives confirm that the version bumps across Cargo manifests and the v0.1.2 release notes are the main changes, and the NAT/Nostr browser-serving capability is the feature the release notes highlight. The title is specific and accurate, though it bundles two items (release prep and the feature) and is slightly long at 74 characters.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 396ae39d-e437-4165-b3fc-98e361158efc
Commits

Reviewing files that changed from the base of the PR and between d96c64a and 8ee8659.

Files ignored due to path filters: 2

  • crates/Cargo.lock is excluded by !**/*.lock
  • crates/desktop/Cargo.lock is excluded by !**/*.lock
Files selected for processing: 7

  • README.md
  • crates/Cargo.toml
  • crates/desktop/Cargo.toml
  • crates/nfx-media/Cargo.toml
  • crates/nfx-node/Cargo.toml
  • crates/nfxd/Cargo.toml
  • docs/nfx/releases/v0.1.2.md

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

@sovtechpro

sovtechpro Bot commented Nov 16, 2026

Copy link
Copy Markdown

All three crate versions, their workspace/desktop pins, and the five lockfile package entries are consistently bumped to 0.1.2 (crates/nfxd/Cargo.toml:3, crates/nfx-node/Cargo.toml:3, crates/nfx-media/Cargo.toml:3, crates/Cargo.toml:29, crates/desktop/Cargo.toml:21).
The README points to the new release notes, which cover the feature set, operator changes, test evidence, limitations, and artifact verification (README.md:16, docs/nfx/releases/v0.1.2.md:1).

Risks

  • Security: This PR contains no source-code or release-workflow changes. The notes explicitly disclose mesh candidate-address exposure and the unauthenticated, rate-limited STUN responder (docs/nfx/releases/v0.1.2.md:28, docs/nfx/releases/v0.1.2.md:30), and include signed-artifact verification steps (docs/nfx/releases/v0.1.2.md:158).
  • Breaking changes: The changed defaults—one rendition, up to 60 seconds waiting for an iroh relay, and SIGTERM handling—are called out, along with the requirement for a general rather than NFX-04-scoped mesh relay (docs/nfx/releases/v0.1.2.md:87, docs/nfx/releases/v0.1.2.md:94). These are operator-facing behavior changes, adequately surfaced for the release.
  • Missing tests: No tests are added here, which is reasonable for this version-and-documentation-only diff. The notes record NAT/browser, Rust, web, fetch, and CI coverage (docs/nfx/releases/v0.1.2.md:101, docs/nfx/releases/v0.1.2.md:138) while retaining explicit limits such as no browser-to-nfxd fetching and no symmetric-NAT coverage (docs/nfx/releases/v0.1.2.md:141). Those statements are not independent verification: the final PR checks and tagged release build still need to pass.

Looks fine to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Lines changed by this pull request: M (sovtechpro[bot])

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant