Skip to content

feat: unify operator notification sections - #779

Merged
Pigbibi merged 4 commits into
mainfrom
feat/unified-operator-format
Nov 6, 2026
Merged

Pigbibi merged 4 commits into
mainfrom
feat/unified-operator-format

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

AI assistance

Codex (GPT-6; host-selected configuration).

What changed

Use the existing notification facts and localized explanations in one five-section operator format: Result, Scope, Evidence, Coverage, Next step. Migrate risk, runtime-guard and receipt templates without changing their signatures, classifier, routing or transport. Add canonical explanations for preserved execution-block causes. Required diagnostics are reserved before optional display context.

How verified

Current repair: focused notification/localization suite 318 passed and 2 subtests; complete repository suite 4033 passed, 3 skipped and 1277 subtests (27 warnings), with declared development dependencies, pip and the actual starting source revision supplied. Twelve regression cases fail before the fixes and pass after. Repository Ruff passes. python scripts/check_style.py: exit 0, zero blocking findings, one existing README advisory. Hosted CI and the new independent review are not claimed green.

Why

Operators currently receive different layouts and must infer the inspected scope and unknown financial counts. The new format makes those facts explicit while keeping existing business decisions intact.

Risk

Display-contract change only. Existing pinned platform consumers do not adopt this revision automatically. QRS and Schwab consume only a byte-recorded pure presentation snapshot; neither bumps the runtime dependency pin. No deployment, switch, permission, recipient, receipt-acceptance or execution change. A budget too small for required fields fails explicitly. Central publication-check.py is available on the repair host; its advisory result is recorded below.

<PROJECT_ID> alert example

Before:

🚨 IBKR · 账户未知 · 策略
结果:硬停 / 运行异常,需人工恢复
原因:operational_uncertain: 运行状态不确定 / 故障
运行时间:2026-01-06 09:45:00 SGT
运行详情:未提供运行链接
下一步:打开管理站处理恢复 / 复位(需授权)

After:

🚨 IBKR · 账户未知 · 策略
【结果】
结果:硬停 / 运行异常,需人工恢复
【范围】
运行时间:2026-01-06 09:45:00 SGT
【证据】
原因:operational_uncertain: 运行状态不确定 / 故障
运行详情:未提供运行链接
【覆盖】
单次运行;订单:未知;成交:未知
【下一步】
下一步:打开管理站处理恢复 / 复位(需授权)

Review finding repairs

Exclude routine time skips from receipt attention only when an accepted receipt exists; real and unknown faults still require review. Return complete evidence when the UTF-16 message fits its budget, including 246-unit diagnostics under a 256-unit limit. Existing overflow and required-field failure behavior stays covered. No merge, label or deployment. Codex, GPT-6.1 Sol (host-selected configuration).

Central publication check

publication-check/2.0-advisory build 83d9d1130377; advisory exit 0; total matches: 1179; matching lines: 1174. First 20 matches (masked text):

  • .<PROJECT_ID>/CODEOWNERS:2: /.github/CODEOWNERS @<PROJECT_ID>
  • .<PROJECT_ID>/CODEOWNERS:3: /src/quant_platform_kit/risk/ @<PROJECT_ID>
  • .<PROJECT_ID>/CODEOWNERS:4: /src/quant_platform_kit/binance/ @<PROJECT_ID>
  • .<PROJECT_ID>/CODEOWNERS:5: /src/quant_platform_kit/ibkr/ @<PROJECT_ID>
  • .<PROJECT_ID>/CODEOWNERS:6: /src/quant_platform_kit/longbridge/ @<PROJECT_ID>
  • .<PROJECT_ID>/CODEOWNERS:7: /src/quant_platform_kit/schwab/ @<PROJECT_ID>
  • .<PROJECT_ID>/CODEOWNERS:8: /src/quant_platform_kit/common/models.py @<PROJECT_ID>
  • .<PROJECT_ID>/CODEOWNERS:9: /src/quant_platform_kit/common/port_adapters.py @<PROJECT_ID>
  • .<PROJECT_ID>/CODEOWNERS:10: /src/quant_platform_kit/common/execution_translation.py @<PROJECT_ID>
  • .<PROJECT_ID>/CODEOWNERS:11: /src/quant_platform_kit/position_sizing.py @<PROJECT_ID>
  • .<PROJECT_ID>/CODEOWNERS:16: /scripts/verify_fractional_dca_execution.py @<PROJECT_ID>
  • .<PROJECT_ID>/CODEOWNERS:17: /src/quant_platform_kit/binance/execution.py @<PROJECT_ID>
  • .<PROJECT_ID>/CODEOWNERS:18: /src/quant_platform_kit/common/account_risk_budget.py @<PROJECT_ID>
  • .<PROJECT_ID>/CODEOWNERS:19: /src/quant_platform_kit/common/execution_capabilities.py @<PROJECT_ID>
  • .<PROJECT_ID>/CODEOWNERS:20: /src/quant_platform_kit/common/execution_commands.py @<PROJECT_ID>
  • .<PROJECT_ID>/CODEOWNERS:21: /src/quant_platform_kit/common/execution_fills.py @<PROJECT_ID>
  • .<PROJECT_ID>/CODEOWNERS:22: /src/quant_platform_kit/common/execution_outcomes.py @<PROJECT_ID>
  • .<PROJECT_ID>/CODEOWNERS:23: /src/quant_platform_kit/common/execution_receipts.py @<PROJECT_ID>
  • .<PROJECT_ID>/CODEOWNERS:24: /src/quant_platform_kit/common/execution_state.py @<PROJECT_ID>
  • .<PROJECT_ID>/CODEOWNERS:25: /src/quant_platform_kit/common/paper_execution_admission.py @<PROJECT_ID>

Repair head: a7166cf1cce1dafdaf55c5fef87f1572759de49a.

Pigbibi and others added 3 commits November 6, 2026 12:50
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>

Pigbibi commented Nov 6, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

Please review exact head commit fb8e687fb9a5d61694d5ad21591c52247bf8dfa1 and publish a codex-review-state:v1 marker bound to that full commit_sha, including status and has_unresolved_findings.

Review request only. Job: notify-codex-request-r1.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-06T05:44:39.007656Z a7166cf Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: fb8e687fb9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Pigbibi
Pigbibi marked this pull request as ready for review November 6, 2026 05:27

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fb8e687fb9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Pigbibi

Pigbibi commented Nov 6, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

Please review both P2 repairs on current head a7166cf1cce1dafdaf55c5fef87f1572759de49a. Local full suite: 4033 passed, 3 skipped, 1277 subtests; Ruff passed.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: a7166cf1cc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Pigbibi Pigbibi added the agent-approved An agent cleared this high-risk change on the current head; not an owner confirmation label Nov 6, 2026
@Pigbibi
Pigbibi merged commit 4d41656 into main Nov 6, 2026
13 of 15 checks passed
@Pigbibi
Pigbibi deleted the feat/unified-operator-format branch November 6, 2026 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-approved An agent cleared this high-risk change on the current head; not an owner confirmation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant