Repository navigation
feat: unify operator notification sections - #779
Conversation
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
|
@codex review Please review exact head commit Review request only. Job: notify-codex-request-r1. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fb8e687fb9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Please review both P2 repairs on current head |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
AI assistance
Codex (GPT-6; host-selected configuration).
What changed
Use the existing notification facts and localized explanations in one five-section operator format: Result, Scope, Evidence, Coverage, Next step. Migrate risk, runtime-guard and receipt templates without changing their signatures, classifier, routing or transport. Add canonical explanations for preserved execution-block causes. Required diagnostics are reserved before optional display context.
How verified
Current repair: focused notification/localization suite 318 passed and 2 subtests; complete repository suite 4033 passed, 3 skipped and 1277 subtests (27 warnings), with declared development dependencies, pip and the actual starting source revision supplied. Twelve regression cases fail before the fixes and pass after. Repository Ruff passes.
python scripts/check_style.py: exit 0, zero blocking findings, one existing README advisory. Hosted CI and the new independent review are not claimed green.Why
Operators currently receive different layouts and must infer the inspected scope and unknown financial counts. The new format makes those facts explicit while keeping existing business decisions intact.
Risk
Display-contract change only. Existing pinned platform consumers do not adopt this revision automatically. QRS and Schwab consume only a byte-recorded pure presentation snapshot; neither bumps the runtime dependency pin. No deployment, switch, permission, recipient, receipt-acceptance or execution change. A budget too small for required fields fails explicitly. Central publication-check.py is available on the repair host; its advisory result is recorded below.
<PROJECT_ID> alert example
Before:
After:
Review finding repairs
Exclude routine time skips from receipt attention only when an accepted receipt exists; real and unknown faults still require review. Return complete evidence when the UTF-16 message fits its budget, including 246-unit diagnostics under a 256-unit limit. Existing overflow and required-field failure behavior stays covered. No merge, label or deployment. Codex, GPT-6.1 Sol (host-selected configuration).
Central publication check
publication-check/2.0-advisorybuild83d9d1130377; advisory exit 0; total matches: 1179; matching lines: 1174. First 20 matches (masked text):.<PROJECT_ID>/CODEOWNERS:2:/.github/CODEOWNERS @<PROJECT_ID>.<PROJECT_ID>/CODEOWNERS:3:/src/quant_platform_kit/risk/ @<PROJECT_ID>.<PROJECT_ID>/CODEOWNERS:4:/src/quant_platform_kit/binance/ @<PROJECT_ID>.<PROJECT_ID>/CODEOWNERS:5:/src/quant_platform_kit/ibkr/ @<PROJECT_ID>.<PROJECT_ID>/CODEOWNERS:6:/src/quant_platform_kit/longbridge/ @<PROJECT_ID>.<PROJECT_ID>/CODEOWNERS:7:/src/quant_platform_kit/schwab/ @<PROJECT_ID>.<PROJECT_ID>/CODEOWNERS:8:/src/quant_platform_kit/common/models.py @<PROJECT_ID>.<PROJECT_ID>/CODEOWNERS:9:/src/quant_platform_kit/common/port_adapters.py @<PROJECT_ID>.<PROJECT_ID>/CODEOWNERS:10:/src/quant_platform_kit/common/execution_translation.py @<PROJECT_ID>.<PROJECT_ID>/CODEOWNERS:11:/src/quant_platform_kit/position_sizing.py @<PROJECT_ID>.<PROJECT_ID>/CODEOWNERS:16:/scripts/verify_fractional_dca_execution.py @<PROJECT_ID>.<PROJECT_ID>/CODEOWNERS:17:/src/quant_platform_kit/binance/execution.py @<PROJECT_ID>.<PROJECT_ID>/CODEOWNERS:18:/src/quant_platform_kit/common/account_risk_budget.py @<PROJECT_ID>.<PROJECT_ID>/CODEOWNERS:19:/src/quant_platform_kit/common/execution_capabilities.py @<PROJECT_ID>.<PROJECT_ID>/CODEOWNERS:20:/src/quant_platform_kit/common/execution_commands.py @<PROJECT_ID>.<PROJECT_ID>/CODEOWNERS:21:/src/quant_platform_kit/common/execution_fills.py @<PROJECT_ID>.<PROJECT_ID>/CODEOWNERS:22:/src/quant_platform_kit/common/execution_outcomes.py @<PROJECT_ID>.<PROJECT_ID>/CODEOWNERS:23:/src/quant_platform_kit/common/execution_receipts.py @<PROJECT_ID>.<PROJECT_ID>/CODEOWNERS:24:/src/quant_platform_kit/common/execution_state.py @<PROJECT_ID>.<PROJECT_ID>/CODEOWNERS:25:/src/quant_platform_kit/common/paper_execution_admission.py @<PROJECT_ID>Repair head:
a7166cf1cce1dafdaf55c5fef87f1572759de49a.