Skip to content

feat: unify digest candidate confirmation warnings - #683

Draft
Pigbibi wants to merge 3 commits into
mainfrom
feat/unified-candidate-warning
Draft

Pigbibi wants to merge 3 commits into
mainfrom
feat/unified-candidate-warning

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Nov 6, 2026 •

Copy link
Copy Markdown
Collaborator

AI assistance

Codex (GPT-6; host-selected configuration).

What changed

Format the existing digest-candidate confirmation warning in Result, Scope, Evidence, Coverage and Next step sections. Reuse only the byte-recorded QPK pure presentation module. Keep missing window/order/fill facts unknown and link only a validated current Actions run when its context exists.

How verified

Final warning, candidate-failure, heartbeat-workflow and notification-entrypoint checks: 96 passed plus 8 subtests using the maintenance job's frozen environment. Ruff, documentation and diff checks pass. Initial hosted full suite: 5282 passed, 1 skipped, 418 subtests; three legacy single-sentence assertions failed. The follow-up updates those assertions to verify the same facts, unknown counts, privacy and unified sections; all affected modules pass locally. New-head hosted CI remains pending at this update. Organization redacted Gitleaks 8.30.1: zero findings.

Why

The candidate warning currently has an unrelated single-sentence layout with no explicit coverage or unknown financial facts.

Risk

Shared presentation source: QPK #779, byte-pinned independently of runtime dependencies. Stacked on #682's stable fault-fix head. This PR owns copy and the presentation snapshot; #682 owns fault workflow logic. No changes to atomic attempt markers, deduplication identity, strict sender acknowledgement, exception handling, acceptance rules or candidate conflict semantics. Runtime dependency pins remain unchanged. Source only; no deploy, trading, secrets, IAM or switches.

Pigbibi and others added 3 commits November 6, 2026 12:49
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
Base automatically changed from fix/preserve-heartbeat-execution-evidence to main November 6, 2026 15:32

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant