Repository navigation
feat(sdl): add reusable participant tool profiles - #1576
Merged
Merged
Conversation
doublewhy
marked this pull request as ready for review
October 13, 2026 04:39
9 of 11 tasks
doublewhy
added a commit
that referenced
this pull request
Oct 13, 2026
9 of 11 tasks
…profiles A behavior specification's tool_affordances are its participant tool profile. Each binding may now carry participant_refs and participant_role_refs, which only narrow the specification's selection and use the same PI-03 resolver over the composed scenario. Both empty keeps today's meaning. The validator rejects selectors that widen the specification, dangle or name an authored __private ref, and checks each binding's actions and boundaries against the participants it selects. Composition namespaces explicit selectors and keeps roles global. The compiler records the raw selectors and resolved participant addresses, with defense-in-depth diagnostics, and makes the existing specification-level dangling participant diagnostic reachable. v2 projection offers a binding only to the participants it selects, deciding scope from the raw selector lists so an empty resolution fails closed. v1 refuses specifications with scoped bindings. Admission is unchanged and independent of bindings. The five SDL schemas and their publication records gain the two fields. Docs, the ACT-619 formal section, the decision record and the migration page describe the semantics, conflict classes and unsupported cases. Refs #301
SonarCloud python:S9073 flags two combined assertions and python:S5778 flags an exception test that builds its selection and admission request inside pytest.raises. Assert each condition separately and build the inputs first. Test-only; the research captures still bind the source. Refs #301
…ence catalog The tool_affordances participant_role_refs row said a role ref is fatal unless bound by a participant inside the owning behavior specification, which reads as the relative selector semantics the decision record rejects. State the absolute rule that TP-3 and the validator enforce: at least one participant has the role, and every participant with the role is inside the owning behavior specification. The parity expectation changes with the row.
Specification-coverage capture capture-97145a5b and formal-validation capture capture-49729647 bind this branch's implementation digest (17c00fe3) on top of dev 348c490, with zero formal replay drift. They follow docs/develop/research-captures.md, using dev's current captures (capture-c9ca186a and capture-3bad3945) as templates; outcomes, classifications and claim limits are unchanged. Refs #301
doublewhy
force-pushed
the
301-participant-tool-profiles
branch
from
October 13, 2026 15:04
1195c8d to
fec0e76
Compare
doublewhy
marked this pull request as draft
October 13, 2026 18:36
This was referenced Oct 13, 2026
Merged
Brad-Edwards
marked this pull request as ready for review
October 26, 2026 23:05
Collaborator
|
Ground Control delivery — this pull request delivers issue #301; Phase E runs on merge. |
Collaborator
|
Ground Control delivery — this pull request delivers issue #301; Phase E runs on merge. |
This was referenced Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
One behavior specification can provide a reusable tool profile to multiple roles. Explicit binding selectors control availability, while observation boundaries and action contracts retain visibility and invocation constraints. The change also repairs the approved parser/projection defects and preserves hidden-reference enforcement across authored and canonical history names.
Requirement UIDs
ACT-619Related Issues
Refs #301
ADR Impact
Changes
Test Plan
490 targeted tests passed on the synchronized branch, including schema parity and full-history regressions for hidden authored references. Generated schema/publication/catalog checks, changed-file Ruff, native Vale, file-local policy, requirement governance, and fresh current-capture replay passed. The complete 61-file review found two classes; both are repaired and covered by regression tests. The merged branch preserves dev's imported tool identity and declaration-resolution behavior. Hosted current-head CI and SonarCloud gates are required before readiness.
Ground Control Checks
Traceability
Checklist
Documentation
Updated: see diff.