Skip to content

fix(sdl): own and admit typed descriptor profile bindings - #1770

Merged
Brad-Edwards merged 4 commits into
devfrom
298-participant-tool-authoring
Oct 31, 2026
Merged

Brad-Edwards merged 4 commits into
devfrom
298-participant-tool-authoring

Conversation

@Brad-Edwards

@Brad-Edwards Brad-Edwards commented Oct 31, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

PR #1440 delivered the #298 done-when items. This PR fixes the residual DSL-117 gap. Since #1278, a typed domain-profile binding on interactive_access.<id>.channel was accepted with any owner, context and value, and no component admitted it. The facade protocol, forest trust type, and federation protocol and mapping intent had the same gap. Each typed descriptor binding must now be owned by its own SDL field. The compiler carries it, and planning and runtime plan admission refuse it unless the target's committed profile context admits its exact semantics (ADR-120). Built-in string values are unchanged.

Requirement UIDs

  • DSL-117
  • SEM-218

Related Issues

Refs #298

ADR Impact

  • ADR-120

Changes

  • raes/descriptor_profiles.py: one host table for the five descriptor fields, the exact owner rule, the field walk, and per-binding admission bound to the manifest context digest. The SDL package owns it because each entry names an SDL field; raes_contracts is unchanged, so the machine-check source pin and the Independently reproduce participant-crossing bisimulation #975 reproduction stay valid.
  • A pass in raes/validator/_sections.py: semantic validation rejects a typed descriptor binding that its field does not own. Composition reads the same host table.
  • RuntimeModel.descriptor_profile_bindings: compiled carriage. The model refuses a compiled typed channel outside the tuple.
  • raes_processor/planner/descriptor_profiles.py and raes_runtime/manager_plan_admission.py: realization.descriptor-profile-unsupported before mutation, with fixed text.
  • Docs: ADR-120, specs/sdl/profile-selections.md, SEM-219 IA3/IA5/IA8, sections.md, the participant-tools README, and the issue-298 decision record with the migration. DSL-117 clause text now names composition/_tool_affordance.py (moved by feat(sdl): add reusable participant tool profiles #1576). A stale example link in sections.md is fixed.
  • Records: DSL-117 and SEM-218 traceability, the 298.json scope, requirement_order.yaml ownership, and the ADR index identity digests in historical_identity_records.json. Spec-coverage, formal and runtime-mapping branch captures are re-recorded; the formal capture records the accepted compiled-digest drift.

Test Plan

  • Unit tests pass
  • Integration tests pass if applicable
  • Full completion suite required in CI before merge
  • No coverage regression

Fail before the fix: on the unmodified tree the new cases failed for the reported defects (owner not checked, no planning refusal, no compiled tuple). Local targeted runs on the final tree: the new module (65 cases), test_issue_298_tool_authoring.py, test_issue_1208_*, test_participant_interactive_access.py, test_enterprise_deployment_tenancy.py, test_issue_304_tool_support.py, the evidence, runtime-mapping, machine-check and #975 reproduction modules all pass. check_specification_coverage.py, check_formal_semantic_validation.py, check_identity_cutover.py, machine_check check, requirement governance and repo policy pass.

Ground Control Checks

  • Repository policy checks required in CI before merge
  • Pre-push Codex review completed; all findings fixed or dispositioned

Traceability

  • IMPLEMENTS: DSL-117 ← implementations/python/packages/raes/descriptor_profiles.py, DSL-117 ← implementations/python/packages/raes_processor/planner/descriptor_profiles.py, DSL-117 ← implementations/python/packages/raes_runtime/manager_plan_admission.py, SEM-218 ← implementations/python/packages/raes/descriptor_profiles.py, SEM-218 ← implementations/python/packages/raes/validator/_sections.py, SEM-218 ← implementations/python/packages/raes/composition/_profiles.py, SEM-218 ← implementations/python/packages/raes_processor/planner/descriptor_profiles.py, SEM-218 ← implementations/python/packages/raes_runtime/manager_plan_admission.py
  • TESTS: DSL-117 ← implementations/python/tests/test_issue_298_descriptor_profiles.py, DSL-117 ← implementations/python/tests/test_issue_1208_profile_boundaries.py, SEM-218 ← implementations/python/tests/test_issue_298_descriptor_profiles.py

Checklist

  • Code follows the project's coding standards
  • Changelog: owned by Release Please (generated from the Conventional Commit PR title; no per-PR fragment)
  • Architectural docs updated if stack, package structure, or key behaviors changed

Documentation

Updated: see diff.

@Brad-Edwards

Copy link
Copy Markdown
Collaborator Author

Ground Control delivery — this pull request delivers issue #298; Phase E runs on merge.

@Brad-Edwards
Brad-Edwards merged commit 33265ac into dev Oct 31, 2026
35 checks passed
@Brad-Edwards
Brad-Edwards deleted the 298-participant-tool-authoring branch October 31, 2026 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant