Repository navigation
fix(sdl): own and admit typed descriptor profile bindings - #1770
Merged
Merged
Conversation
Collaborator
Author
|
Ground Control delivery — this pull request delivers issue #298; Phase E runs on merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #1440 delivered the #298 done-when items. This PR fixes the residual DSL-117 gap. Since #1278, a typed domain-profile binding on
interactive_access.<id>.channelwas accepted with any owner, context and value, and no component admitted it. The facade protocol, forest trust type, and federation protocol and mapping intent had the same gap. Each typed descriptor binding must now be owned by its own SDL field. The compiler carries it, and planning and runtime plan admission refuse it unless the target's committed profile context admits its exact semantics (ADR-120). Built-in string values are unchanged.Requirement UIDs
DSL-117SEM-218Related Issues
Refs #298
ADR Impact
Changes
raes/descriptor_profiles.py: one host table for the five descriptor fields, the exact owner rule, the field walk, and per-binding admission bound to the manifest context digest. The SDL package owns it because each entry names an SDL field;raes_contractsis unchanged, so the machine-check source pin and the Independently reproduce participant-crossing bisimulation #975 reproduction stay valid.raes/validator/_sections.py: semantic validation rejects a typed descriptor binding that its field does not own. Composition reads the same host table.RuntimeModel.descriptor_profile_bindings: compiled carriage. The model refuses a compiled typed channel outside the tuple.raes_processor/planner/descriptor_profiles.pyandraes_runtime/manager_plan_admission.py:realization.descriptor-profile-unsupportedbefore mutation, with fixed text.specs/sdl/profile-selections.md, SEM-219 IA3/IA5/IA8,sections.md, the participant-tools README, and the issue-298 decision record with the migration. DSL-117 clause text now namescomposition/_tool_affordance.py(moved by feat(sdl): add reusable participant tool profiles #1576). A stale example link insections.mdis fixed.298.jsonscope,requirement_order.yamlownership, and the ADR index identity digests inhistorical_identity_records.json. Spec-coverage, formal and runtime-mapping branch captures are re-recorded; the formal capture records the accepted compiled-digest drift.Test Plan
Fail before the fix: on the unmodified tree the new cases failed for the reported defects (owner not checked, no planning refusal, no compiled tuple). Local targeted runs on the final tree: the new module (65 cases),
test_issue_298_tool_authoring.py,test_issue_1208_*,test_participant_interactive_access.py,test_enterprise_deployment_tenancy.py,test_issue_304_tool_support.py, the evidence, runtime-mapping, machine-check and #975 reproduction modules all pass.check_specification_coverage.py,check_formal_semantic_validation.py,check_identity_cutover.py,machine_check check, requirement governance and repo policy pass.Ground Control Checks
Traceability
Checklist
Documentation
Updated: see diff.