Repository navigation
feat!: make reference eligibility explicit per purpose and align the editor with validation - #1446
Conversation
8e32e4d to
4b8794a
Compare
a36ae06 to
94777b1
Compare
94777b1 to
3da6039
Compare
3da6039 to
ab22b8f
Compare
ab22b8f to
4ac06f1
Compare
ba40a58 to
45d9e4c
Compare
…icit-target-eligibility
…icit-target-eligibility
|
Completed all nine required repairs documented on #1339, including the overlapping acceptance criteria in #1503, #1511 and #1577–#1579. Preserved contributor history and merged the latest dev. All 98 added repair regressions pass after synchronization; the 18 explicit participant-obligation cases and both refreshed source-bound evidence captures also pass. Changed-file lint, scoped policy, schema parity and contract tracing passed. The PR description now records concrete commands and outcomes. Required isolated CI for this published head remains the completion gate. |
|
Corrected the failures from current-head CI: source metadata now preserves scenario/declaration equality and existing source collision checks; relationship candidates copy only their edited edge; the exhaustive endpoint assertions remain, with complete/incomplete/untyped behaviors in separate cases under the existing timeout. The domain-join test now rejects a workstation that validation does not recognize as a controller. All 99 dedicated repair regressions pass, as do targeted classification, materialization, editor and topology checks. Lint, scoped policy and refreshed source-bound evidence validation pass. Required CI must pass for this new head. |
…icit-target-eligibility
|
Addressed all 24 Sonar maintainability findings without waiving checks. The repair/YAML/registry tests passed (333), editor/reference policy tests passed (77), and the complete endpoint-editor module passed (158). Merged the latest dev credential/artifact-evidence fix cleanly; its relevant runtime and scope/effect tests passed (42). Recollected and recorded source-bound formal/specification evidence for the merged source; selected capture validation reports zero failures. Final-head CI is required before merge. |
|
Updated the tooling lock from virtualenv 21.7.9 to 21.7.13 and urllib3 2.7.0 to 2.8.0, covering all seven open dependency alerts observed during publication. The product lock already selects patched urllib3. Only these two transitive packages changed; hashes were regenerated through uv, offline lock verification and scoped policy pass. Product source digest remains unchanged. Required final-head CI is rerunning. |
|
Recommendation: do not merge as is. The repository-bound review snapshot could not be retrieved.
Required action:
Coverage and outstanding work: Issue criteria, premise, design, source diff, checks and mergeability are unverifiable because the context call fails before returning them. Verification limits: This is a verification blocker, not a demonstrated code defect or close recommendation. |
Resolve the conflicts with the hardening that #1446 landed on dev: - module_registry/models.py: keep dev's bounded workspace-configuration reader, YAML token and graph validation and value-free sdl.workspace-config.invalid errors; drop this branch's unbounded read_text and yaml.safe_load loaders. - module_registry/resolution.py: keep dev's locked-import loop with its cycle check, composition-depth budget and value-free invalid-record error; drop this branch's unbounded loop and value-rendering record error. Keep the directory and unreadable local-import checks and the imported-unit removed-scoring check. - composition/_expand.py: keep dev's admit_import_source and declaration-source tracking; keep typed import-list validation before the first import resolves. The imported-unit removed-scoring check moves into composition/_import_admission.py, where dev now loads the unit.
…e-surface Conflicts and their resolution: - Research evidence (docs/research, tools/formal_semantic_validation, tools/check_specification_coverage.py and three evidence tests): take dev's side and drop this branch's numbered releases (specification coverage 69.0.0, formal validation 70.0.0), the shared index edits and the revision-pin edits. Feature branches record content-addressed captures instead (.gc/plan-rules.md, docs/develop/research-captures.md). - participant_behavior_specification.py, validator/__init__.py, compiler/pipeline.py: keep dev's mixed-control policy, effect-target and delivery-control members beside the episode policy. - specs/sdl/references.md: keep dev's delivery-control rows, then the nine episode-policy rows. - Schemas and ledger: regenerated from schema_bundle() on the merged source; the five last_change entries are recorded against the new content. materialized-scenario-v1.json is 469,101 bytes, inside the 512,000-byte budget, because dev's shared-subschema factoring (#1584) absorbs the policy's growth (#1556). Semantic conflicts resolved in the same merge: - dev's #1446 replaced the targetable flag with explicit reference purposes, so the reset-authority check and its compiled address resolve through ReferencePurpose.TARGETABLE, the purpose the references.md row already names, and the editor table gains the same entry. - dev's composition/_behavior.py is now 490 lines, so the episode-policy rewriter moves to composition/_episode_policy.py to stay under the 500-line cap.
Summary
Complete #1339's shared reference-purpose policy across authoring, composition, instantiation, editor navigation/completion and runtime compilation. Validated references retain the canonical identity their field selected, including imported declarations and authority/operating scopes.
Breaking authoring change: objective subjects, action/effect targets, shared state and authority scopes require explicit eligibility. Recognized nonreferenceable declarations cannot masquerade as opaque effect targets. Eligibility grants no participation, authority or visibility.
Requirement UIDs
Related Issues
Closes #1339
Includes the overlapping repair criteria from #1503, #1511, #1577, #1578 and #1579. All nine repair areas are documented on #1339, with an additional tooling security repair. None of the required repairs is moved to a follow-up.
Identity program context: #1338, #1340, #1341 and #220.
ADR Impact
Aligns with ADR-109 participant identity, ADR-076 canonical identities and safe boundaries, ADR-052 subtype ownership, ADR-053 composition/source provenance, and ADR-020 operating scope. Affiliations remain optional and convey no authority; objective ownership stays separate from participant assignment.
Changes
from_net/to_netand detectionsource_artifact_refthrough canonical import namespaces, including nested imports and colliding root names. Restore the excluded stage-matrix cases.Test Plan
test_issue_1339_*modules.3ee3e0ba11138c7df3a61104048df2a30d9d9c7c: full verification, all four coverage shards, integration, CPython 3.11–3.14 compatibility, fuzz, proof/contract checks and security. Bootstrap qualification and docs also passed. Sonar quality gate is OK with zero open issues and zero open hotspots.Local source execution uses explicit relevant modules/cases in a credential-free sandbox with networking disabled. Repository-wide test, integration and fuzz suites run only in CI. Lock resolution uses the existing approved package index without executing builds.
Ground Control Checks
The existing PR branch includes real merges from
dev; contributor history is preserved. Authorized manual fallback recovered the publisher/synchronizer deadlock and the oversized PR-context read. Publication remains a fast-forward on the original PR branch. Merge remains a maintainer decision.Traceability
The issue repair checklist maps required behavior to the shared purpose policy, declaration index, composition/resolution boundaries, language helpers, subtype owners and compiler projections. Existing and added regressions cover the admitted kinds and purposes across authoring, composition, instantiation and compilation. The security addendum identifies every affected advisory and its patched lock version.
Checklist
Documentation
Updated the normative reference catalog, objective/variation guidance, editor documentation and migration instructions for eligibility, explicit registration, namespace rewriting, effect recognition, completion constraints, declaration provenance and runtime projection.