Default-disable SW cursor for Linux - #2134
Open
Rainyan wants to merge 6 commits into
Open
Conversation
Workaround for NeotokyoRebuild#2114 The reason why we still default-enable for Windows is NeotokyoRebuild#1705 Should figure out the actual cause of the offset bug, but it's better to the kind of cursor which works best for Windows/Linux until then.
cvar type from bool -> int and use RingBoxFlag for toggling the enum bits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Workaround for bug:
This will change
cl_software_cursorfrom bool to per-OS int bitflags, with the current default bitflags being Windows only.The video menu options for the SW cursor are also updated to toggle the per-platform bitflag. This way, users can have their per-platform cursor preference carry over across Linux/Windows when synced via Steam etc, since only the bit for their current platform is changed.
Worth noting that this doesn't fix #2114 but just works around it, to avoid users having a bad time with their cursor not aligning properly.
Changes introduced
Default appearance of the SW cursor on Linux changes to disabled, to alleviate Software cursor is unaligned at non-native screen resolutions on Linux #2114 . The Windows OS software cursor default appearance remains unchanged (enabled), so that we don't reintroduce OS mouse cursor graphical glitch #1705 .
Linux will have the video options menu field for the software cursor hidden, to avoid users running into Software cursor is unaligned at non-native screen resolutions on Linux #2114
cl_software_cursorbitflags directly from the console to override thisToolchain
Linked Issues