Bots don't avoid smoke grenades with a known thrower - #2133
Open
sunzenshen wants to merge 1 commit into
Open
sunzenshen wants to merge 1 commit into
sunzenshen wants to merge 1 commit into
Conversation
Contributor
Author
|
This PR is partly a response to being reminded that previously bots do not differentiate smokes from frags when retreating from flying grenades: bot-follow-cmdr-in-smoke.mp4After the bots differentiate who threw the smoke grenade: bot-ignore-known-smoke.mp4 |
sunzenshen
commented
Sep 13, 2026
| { | ||
| if ( grenadeArea->IsPotentiallyVisible( me->GetLastKnownArea() ) ) | ||
| { | ||
| bIsExposed = true; |
Contributor
Author
There was a problem hiding this comment.
Also took the opportunity to remove some dead stub code that didn't end up being used for anything impactful.
Rainyan
approved these changes
Sep 14, 2026
Rainyan
left a comment
Rainyan
left a comment
Member
There was a problem hiding this comment.
Seems good to me, also verified with sv_neo_bot_cmdr_debug_pause_uncommanded 1 that a support throwing a frag grenade still correctly gets the teammates to disperse.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds smoke identification code to the bot grenade avoidance behavior.
Before bots retreated from smoke grenades while they were in flight, even in circumstances where the nature of the grenade should be obvious.
Now checks whether the smoke grenade was thrown by a teammate (implied that the teammate communicated the intent), or whether the thrower was identified by the bot recently.
Toolchain
Linked Issues