Bot path reservation dispersal improvements - #2132
Open
sunzenshen wants to merge 1 commit into
Open
sunzenshen wants to merge 1 commit into
sunzenshen wants to merge 1 commit into
Conversation
- fixed bots using the same serial prefix as a reservation index (the reservation system was treating all teammates as the same individual) - clear reservations on death - penalize excessively long detours
sunzenshen
commented
Sep 13, 2026
sunzenshen
left a comment
sunzenshen
left a comment
Contributor
Author
There was a problem hiding this comment.
This PR fixes the bookkeeping behind the teammate dispersal path reservations and changes how the penalty scales with the number of teammates on a route.
| float avoidPenalty = neo_bot_path_reservation_enable.GetBool() | ||
| ? CNEOBotPathReservations()->GetAreaAvoidPenalty( area->GetID() ) | ||
| : 0.0f; | ||
| float avoidPenalty = CNEOBotPathReservations()->GetAreaAvoidPenalty( area->GetID() ); |
Contributor
Author
There was a problem hiding this comment.
Would have been zero anyway if the system was disabled.
| "Base penalty for calculating inverse traversal penalty for scoped weapons", true, 1.0f, false, 0.0f); | ||
|
|
||
| ConVar neo_bot_path_visibility_exposure_enable("neo_bot_path_visibility_exposure_enable", "1", FCVAR_NONE, | ||
| "Enable visibility-exposure pathing penalties", true, 0, true, 1); |
Contributor
Author
There was a problem hiding this comment.
Separate team-based path penalties from equipment based penalties.
| if (nFriendly > 0) | ||
| { | ||
| // Discourage team clustering: (n^2 * penalty) | ||
| cost += nFriendly * nFriendly * neo_bot_path_reservation_penalty.GetFloat(); |
Contributor
Author
There was a problem hiding this comment.
Instead of using a huge flat penalty, power scale (n^2) based on number of friendlies on the path.
| // Intended for use by ghost carrier team, to emulate a team that knows where enemies are likely to ambush | ||
| // Compensates for bots' lack of meta knowledge by making them prefer routes not reserved by enemies | ||
| // Adheres to cheat against bots but not against humans philosophy by not considering human players' positions | ||
| cost += CNEOBotPathReservations()->GetPredictedFriendlyPathCount(area->GetID(), GetEnemyTeam(m_me->GetTeamNumber())) * neo_bot_path_reservation_penalty.GetFloat() * 2; |
Contributor
Author
There was a problem hiding this comment.
Consolidated with team-based penalties above.
| // Less function for EHANDLE in m_BotReservedAreas | ||
| inline static bool EHandleLessFunc(const EHANDLE &lhs, const EHANDLE &rhs) | ||
| { | ||
| return lhs.GetSerialNumber() < rhs.GetSerialNumber(); |
Contributor
Author
There was a problem hiding this comment.
Ironically, logging pointed out that these values often ended up being identical between bots. (The serial number was part of a larger ID value.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Primarily addresses a myriad of issues with the team-specific lookup and penalization of congested routes:
Toolchain
Linked Issues