Improve bot tracking of recent combat sounds - #2129
Open
sunzenshen wants to merge 1 commit into
Open
Conversation
sunzenshen
force-pushed
the
bot-investigate-sounds-revisit
branch
from
September 12, 2026 23:16
2589e54 to
c332680
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bot trackable combat sounds on average were only existing for about 200 milliseconds before disappearing, so most combat sounds were disappearing by the time bots were considering nearest combat sounds every 250ms. The proposed fix is to add combat sounds to a temporary buffer object every tick, and let the bots query this buffer object at their leisure.
Toolchain
Linked Issues