Conversation
Move to neo_player_shared
Manually verify ground entity presence for the water jump case. This fixes the issue with waterjumping, but doesn't address the underlaying problem, which seems to be that we spawn with stale FL_ONGROUND value, which causes IsAllowedToSuperJump to incorrectly pass the IsAirborne check. This also means that one can superjump upon spawning for non-freezetimed rounds (like warmup), if they are fast enough to do the superjump before landing. Will address the actual problem in next commit.
BaseClass of server CNEO_Player class will set FL_ONGROUND unconditionally at Spawn. This is not necessarily true, and will fail most notably for the case where the player spawns in and above a pool of water. Having the FL_ONGROUND be incorrect will then subsequently break checks for Airborne-ness for the recon superjump, effectively allowing the recon to superjump from above the surface of the water, until they first land on a true ground surface to sync their ONGROUND flag with reality. Another bugged case would be spawning high in the air, during warmup or mid-round where there might be no freezetime, whereby the recon could superjump mid-air if they were quick enough to do it before touching the floor. Client side seems to not set the FL_ONGROUND flag in this way, so the fix is only needed server side. Also reverting the previous 9c0b04f hotfix because this commit obsoletes it.
Height can differ by class (supports)
because this only matters for players
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix a problem with
FL_ONGROUNDflag being set unconditionally server side for CNEO_Player::Spawn when calling into its base class. This would not always hold true, the most notable issue being #1969 . Another weird edge case would be spawning late into a round, and being able to recon-superjump if you do it before landing on the ground for the first time from a mid-air spawnpoint.Also refactoring some old related code to be shorter and nicer.
Test map (OGNT compatible)
dev_swimspawn.zip
Should be able to superjump (parity):
Should not be able to superjump:
Toolchain
Linked Issues