Repository navigation
feat(fabric): pin Fabric to current main and keep OpenClaw's state across runtimes - #14385
Merged
Merged
Conversation
… changes Signed-off-by: Carlos Villela <cvillela@nvidia.com>
…rface The new Fabric pin lets OpenClaw keep its state, so NemoClaw now sets runtime.keep_state for OpenClaw agents and their dashboard token lives in the agent's state folder. Adapted from #14362. Co-authored-by: J. Yaunches <jyaunches@nvidia.com> Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Collaborator
Author
Authoring session — opening
|
Contributor
|
v1 documentation preview: https://nvidia-preview-nemoclaw-v1-pr-14385.docs.buildwithfern.com/nemoclaw |
cv
added a commit
that referenced
this pull request
Nov 11, 2026
…ms (#14413) The release notes now list every user-visible change on `v1` since the `v0.1.0-rc9` tag, including the breaking ones, and four example pages drop claims that later changes made false. ## Problem `docs/about/release-notes.md` listed three breaking changes and none of the features, fixes, and onboarding changes that reached `v1` after `v0.1.0-rc9`; it didn't name the configuration shapes the parser now rejects or the intent record version `v0.1.0-rc9` writes. Some example claims went stale: - `examples/spark/README.md` said the pinned OpenShell has the Podman TLS initialization blocker, NVIDIA/OpenShell#3427; its fix merged before OpenShell 0.1.0, and `v1` pins 0.1.7. - `examples/station/README.md` and `examples/gtc-dc/README.md` required exactly one visible GPU on the host; since #13929, `container.gpuDevices` lets a service on a host with more GPUs request one. - `examples/hcl/travel-team` said Fabric's Deep Agents adapter can't turn reasoning off, NVIDIA/NeMo-Fabric#433; NVIDIA/NeMo-Fabric#439 fixed that, and the pinned catalog's Deep Agents `reasoning_effort` accepts `none`. - The travel team cited #13313 for the booking key its service doesn't receive, but #13313 closed when `openshell_api` landed. ## Change - `docs/about/release-notes.md` gains "Changes Since v0.1.0-rc9", grouped by area, from the commits in `v0.1.0-rc9..origin/v1`; where a later commit changed an earlier one, the entry describes the current code, and changes added and removed after the tag aren't listed: - Agents and interfaces: #14037, #14038, #14269, #13981, #14024, #14186, #14052, #14385, #13971, #13858, #13947, #14039, #14042, #14044, #14343. - Inference: #13929, #14391, #14396, #14398, #14400, #13963, #13912, #13964, #14388, #14390, #14397. - Gateways and Kubernetes: #13909, #13970, #13922 (an existing namespace, refused at plan by #13756, is now bound; cluster-wide reads dropped), #14014, #14169, #13921. - Plan, apply, and diagnostics: #14224, #13756, #14141, #14133, #14135, #13775, #13744, #13701. - Onboarding: #13693, #13695, #13741, #13757, #13851, #13978, #14228, #14233, #14334, #14336. - Examples and builds: #14166, #14184, #14188, #14191, #14192, #14200, #13889, #14267, #14312, #14315, #14355, b30e9b4, #13781, #13813, #14246, and the pins in `versions.json` and `image/fabric/Dockerfile`. - Its breaking changes since the tag: - the intent record moving from 15, which `v0.1.0-rc9` writes, through 16 (#14266), 17 (#14343), 18 (#13929), 19 (#14391) and 20 (#14394); - name-keyed `sandboxes` and `inferenceProviders` (#13703, #13705); - a recipe `compatibility.gpu` outside every hardware profile (#13912); - model tuning the adapter doesn't accept (#14111), and Hermes's `max_tokens` losing its default (#14296); - `skills.paths` resolution (#14296); - endpoint and `networkCIDR` validation (#13847, #14081); - the HCL `gateway_values` attribute (#14014), and Kubernetes ownership receipts from before #13922 and #14014. The two earlier items stay, under their own heading. - `examples/spark/README.md` replaces the closed OpenShell#3427 blocker with the Podman and remote-model limits in `docs/resources/limits.md`. - `examples/station/README.md` and `examples/gtc-dc/README.md` require one GPU visible in the model container, and point to `container.gpuDevices` for a host with more. - `examples/hcl/travel-team/README.md` and `WALKTHROUGH.md` drop the NeMo-Fabric#433 limitation, and the travel team's booking-key statements link #14417 instead of #13313. Not listed, because both changes landed after the tag: Deep Agents Code (#14043, #14250), `compatibility.gpuCount` (#14391, #14394), and the "Creating infrastructure state" progress step (#14169, #14248). Checked and left unchanged: the root `README.md`, `crates/nemoclaw-onboarding/README.md`, `crates/nemoclaw-cli/assets/README.md`, `internal-docs/README.md`, the other example READMEs, and every example YAML header comment. The GPU autoscaling README and `load.sh` read the JSON fields `OperationResult` serializes, and NVIDIA/OpenShell#4287 is fixed only after the pinned 0.1.7. The two pre-tag release-note items still match the schema and SDK. `docs/README.md` is left to #14412, which retires the stale field reference snapshot it describes. Not verified: whether Hermes sends the booking key's placeholder to MCP servers; #14417 tracks the live check. ## Beyond CI Each relative link and anchor in the changed files resolves to an existing file and heading.
cv
added a commit
that referenced
this pull request
Nov 16, 2026
…ill directories (#14472) Moves the Fabric pin to the head of NVIDIA/NeMo-Fabric#632, so OpenClaw and Hermes agents list their skills in `skills.directories`, with `duplicates` and `bundled` policies, and OpenClaw agents go back to temporary native state. Documents and HCL that list a folder of skills in `skills.paths` must move it to `skills.directories`. ## Problem At the current pin (`f33fa19a`, a fork commit that combines Fabric `main` with NVIDIA/NeMo-Fabric#576, NVIDIA/NeMo-Fabric#615, and an OpenClaw kept-state change): - An OpenClaw or Hermes `skills.paths` entry can be a folder of skills, a rule that exists only on the fork. NVIDIA/NeMo-Fabric#632 replaces it with `skills.directories`, whose `folder` and `skill` entries mean the same thing for every adapter, and adds `skills.duplicates` and `skills.bundled`. - Fabric reverted OpenClaw's `runtime.keep_state`: recreating or restoring an OpenClaw runtime on a kept state folder failed with "Another Gateway owner lease is still active". ## Change - Pins Fabric at `b4725580` in `versions.json`, the Cargo manifests, the source line of `Cargo.lock`, and the documentation links. The commit is the head of NVIDIA/NeMo-Fabric#632, based on Fabric `main` at `910218f0`; the `integration/nemoclaw-pin-20261116` branch of cv/NeMo-Fabric keeps it. - Regenerates `image/fabric/catalog.json`: - OpenClaw no longer accepts `runtime.keep_state`. - Both adapters declare their `skills` support. - Hermes declares cold resume (NVIDIA/NeMo-Fabric#605) and new native settings. OpenClaw also declares new native settings; none were removed. - OpenClaw agents get temporary state again, since NemoClaw sets `runtime.keep_state` only where the adapter accepts it. Their dashboard token is back at `<artifact root>/.fabric/openclaw/runtimes/<runtime-id>/interfaces/dashboard.token`. This undoes #14385's OpenClaw test, fixture, and documentation changes; Hermes keeps its state. - `fabric_agent`'s `skills` block takes `directories` blocks, each with `folder` or `skill`, plus `duplicates` and a `bundled` block. - Fabric's schema gives each `directories` entry the other key with the type `null`, so `{"skill": "/x", "folder": null}` is accepted. - NemoClaw's schema-to-OpenTofu mapping (`nemoclaw-tofu`'s `shape`) had no type for a property that can only be null, so building the provider schema panicked, and every plan and apply failed with it. - The mapping now leaves such a property out, because omitting it is the only way to set it. - The change is in NemoClaw because that mapping is NemoClaw's: Fabric's schema describes valid configuration correctly, and other JSON schema consumers handle it. - The mapping already drops an omitted list block and null attributes, so a `skills` block with only `paths` sends no `directories`. Fabric refuses `directories` beside non-empty `paths`. HCL therefore can't send `directories: []`, which Fabric reads as no external skills; YAML can. - Uses `directories` with `duplicates: reject` wherever a folder of skills is meant, which keeps the start failure on duplicate names that `skills.paths` had at the old pin: - the `docker-openclaw-hermes-interfaces` live case; - the `docker-hermes-kept-state` integration case; - `examples/hcl/travel-team`, whose integration scenario now mounts the skills volume and checks each researcher's skills; - the user docs. - Rewrites Skills on a Mounted Volume for `directories`. Its table now compares how Hermes and OpenClaw find skills in a folder, as Fabric's skills guide at the pin describes. - Adds release notes. `skills.paths` behaves as in `v0.1.0-rc9` again: OpenClaw requires `SKILL.md` in each path, and Hermes passes each path to `skills.external_dirs` unchecked. - Regenerates the provider schema snapshot, the discovery and OpenShell contract fixtures, and the inference names in the `openshift-external-two-providers` scenario. - The onboarding journey tests omit OpenClaw's new `agents`, `plugins`, and `tools` settings, as they omit its other optional settings. Hermes's bundled skills don't change while `skills.bundled` is omitted, as in every example and case here: - An embedded Hermes agent with a new home has none. - A runtime with Hermes's API server, dashboard, or terminal gets Hermes's own copy, which a kept home retains. - Fabric's new Hermes descriptor declares `bundled.default: "disabled"` and `supports_disable: false` for that behavior. - Setting `skills.bundled` makes the adapter copy the selection at start, and it must keep `hermes-agent`. This replaces #14454, which also refreshed the Fabric pin. ## Beyond CI - The pin is the head of NVIDIA/NeMo-Fabric#632, which is open and under review. Move the pin to Fabric `main` once it merges. - Recomputed the `fabric.tar.gz` SHA-256 from codeload. - Regenerated `image/fabric/catalog.json` with `image/fabric/catalog.py` from `nemo-fabric-adapter-catalog` installed from the pinned source. --------- Signed-off-by: Carlos Villela <cvillela@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the Fabric pin from
316fbdfbtof33fa19a, which adds everything merged to NVIDIA/NeMo-Fabricmainthrough6015e7cfto the pending Hermes home, skill folder, and OpenClaw kept-state changes. OpenClaw agents now keep their native state and the skills they author across runtimes, as Hermes agents already do.Problem
At the current pin (
316fbdfb, branched from Fabricmainon 2026-11-06):mainhas 15 commits the pin lacks. They include the merged versions of feat: keep an agent's state in one folder across its runtimes NeMo-Fabric#572 (the kept-state lock) and feat: share OpenClaw configuration across native interfaces NeMo-Fabric#573 (OpenClaw's interfaces), runtime health fixes that report an exited harness as failed instead of unknown ([Enhancement]: Add bounded runtime health checks across harness adapters NeMo-Fabric#298), and Hermes Relay 0.11 support.#14362 proposes the OpenClaw change with a pin on a fork of a fork, based on an older Fabric
main.Change
f33fa19ainversions.json, the Cargo manifests and lock file, and the documentation links. The commit combines Fabricmainwith feat: keep Hermes's home in the agent's state folder NeMo-Fabric#576, feat: accept a skill folder or a folder of skills in skills.paths NeMo-Fabric#615, and the OpenClaw kept-state change, and theintegration/nemoclaw-pin-20261110branch of cv/NeMo-Fabric keeps it.image/fabric/catalog.json: OpenClaw acceptsruntime.keep_state, and the Hermes and OpenClaw adapters declare aterminalinterface.runtime.keep_statewherever the adapter accepts it, so OpenClaw agents now keep their state in/sandbox/artifacts/.fabric/state/nvidia.fabric.openclaw/<agent name>. Their dashboard token moves to that folder'sinterfaces/, and apply prints the new path.terminalinterface; NemoClaw reports it as documented by the adapter, without a token path.openshift-external-two-providersscenario.The test and documentation changes are adapted from #14362, which this replaces.
Left out: moving the bundled Hermes from v0.22.5 to v0.22.7, which the pinned adapter also supports, and reporting the new terminal interfaces.
Beyond CI
The pinned commit is on a fork until NVIDIA/NeMo-Fabric#576 and NVIDIA/NeMo-Fabric#615 merge; the pin should then move to a commit on Fabric
main.