Skip to content

feat(fabric)!: pin Fabric to NVIDIA/NeMo-Fabric#632 for structured skill directories - #14472

Merged
cv merged 3 commits into
v1from
cv/fabric-pin-632-skills
Nov 16, 2026
Merged

cv merged 3 commits into
v1from
cv/fabric-pin-632-skills

Conversation

@cv

@cv cv commented Nov 15, 2026 •

Copy link
Copy Markdown
Collaborator

Moves the Fabric pin to the head of NVIDIA/NeMo-Fabric#632, so OpenClaw and Hermes agents list their skills in skills.directories, with duplicates and bundled policies, and OpenClaw agents go back to temporary native state. Documents and HCL that list a folder of skills in skills.paths must move it to skills.directories.

Problem

At the current pin (f33fa19a, a fork commit that combines Fabric main with NVIDIA/NeMo-Fabric#576, NVIDIA/NeMo-Fabric#615, and an OpenClaw kept-state change):

  • An OpenClaw or Hermes skills.paths entry can be a folder of skills, a rule that exists only on the fork. feat: load skills from directories with bundled and duplicate controls NeMo-Fabric#632 replaces it with skills.directories, whose folder and skill entries mean the same thing for every adapter, and adds skills.duplicates and skills.bundled.
  • Fabric reverted OpenClaw's runtime.keep_state: recreating or restoring an OpenClaw runtime on a kept state folder failed with "Another Gateway owner lease is still active".

Change

  • Pins Fabric at b4725580 in versions.json, the Cargo manifests, the source line of Cargo.lock, and the documentation links. The commit is the head of feat: load skills from directories with bundled and duplicate controls NeMo-Fabric#632, based on Fabric main at 910218f0; the integration/nemoclaw-pin-20261116 branch of cv/NeMo-Fabric keeps it.
  • Regenerates image/fabric/catalog.json:
  • OpenClaw agents get temporary state again, since NemoClaw sets runtime.keep_state only where the adapter accepts it. Their dashboard token is back at <artifact root>/.fabric/openclaw/runtimes/<runtime-id>/interfaces/dashboard.token. This undoes feat(fabric): pin Fabric to current main and keep OpenClaw's state across runtimes #14385's OpenClaw test, fixture, and documentation changes; Hermes keeps its state.
  • fabric_agent's skills block takes directories blocks, each with folder or skill, plus duplicates and a bundled block.
    • Fabric's schema gives each directories entry the other key with the type null, so {"skill": "/x", "folder": null} is accepted.
    • NemoClaw's schema-to-OpenTofu mapping (nemoclaw-tofu's shape) had no type for a property that can only be null, so building the provider schema panicked, and every plan and apply failed with it.
    • The mapping now leaves such a property out, because omitting it is the only way to set it.
    • The change is in NemoClaw because that mapping is NemoClaw's: Fabric's schema describes valid configuration correctly, and other JSON schema consumers handle it.
    • The mapping already drops an omitted list block and null attributes, so a skills block with only paths sends no directories. Fabric refuses directories beside non-empty paths. HCL therefore can't send directories: [], which Fabric reads as no external skills; YAML can.
  • Uses directories with duplicates: reject wherever a folder of skills is meant, which keeps the start failure on duplicate names that skills.paths had at the old pin:
    • the docker-openclaw-hermes-interfaces live case;
    • the docker-hermes-kept-state integration case;
    • examples/hcl/travel-team, whose integration scenario now mounts the skills volume and checks each researcher's skills;
    • the user docs.
  • Rewrites Skills on a Mounted Volume for directories. Its table now compares how Hermes and OpenClaw find skills in a folder, as Fabric's skills guide at the pin describes.
  • Adds release notes. skills.paths behaves as in v0.1.0-rc9 again: OpenClaw requires SKILL.md in each path, and Hermes passes each path to skills.external_dirs unchecked.
  • Regenerates the provider schema snapshot, the discovery and OpenShell contract fixtures, and the inference names in the openshift-external-two-providers scenario.
  • The onboarding journey tests omit OpenClaw's new agents, plugins, and tools settings, as they omit its other optional settings.

Hermes's bundled skills don't change while skills.bundled is omitted, as in every example and case here:

  • An embedded Hermes agent with a new home has none.
  • A runtime with Hermes's API server, dashboard, or terminal gets Hermes's own copy, which a kept home retains.
  • Fabric's new Hermes descriptor declares bundled.default: "disabled" and supports_disable: false for that behavior.
  • Setting skills.bundled makes the adapter copy the selection at start, and it must keep hermes-agent.

This replaces #14454, which also refreshed the Fabric pin.

Beyond CI

…ill directories

Moves the Fabric pin from f33fa19a to 7f8d4a40, the head of
NVIDIA/NeMo-Fabric#632. A skills.paths entry is no longer a folder of
skills; skills.directories lists folders and skills, with duplicates and
bundled policies. OpenClaw no longer accepts runtime.keep_state, so its
state is temporary again. The fabric_agent schema now maps properties
that can only be null, which skills.directories entries declare.

Signed-off-by: Carlos Villela <cvillela@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Nov 15, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@cv

cv commented Nov 15, 2026

Copy link
Copy Markdown
Collaborator Author
Authoring session — opening
Field Status Value Evidence or limit
Harness recorded Pi 1.5.0 (pi-coding-agent), with the Pit TypeScript tool, as a helper agent Session header (format version 3) and the install path in the recorded system prompt
Skills recorded nemoclaw-contributor-create-pr (complete read) Tool results to the cutoff; other skills were listed but not read
Instruction files recorded AGENTS.md (injected; complete read); WRITING.md (complete read); internal-docs/contributing/agent-image-maintenance.md (complete read); .github/PULL_REQUEST_TEMPLATE.md (complete read); .github/SESSION_REPORT_TEMPLATE.md (complete read) Injections and read results to the cutoff; internal-docs/contributing/testing.md was read with its middle truncated, so it isn't counted
Tool calls recorded typescript: 159 Wrapper calls, including failures, to the cutoff; the shell, git, and workspace calls inside them aren't recorded separately
Tokens recorded input: 27932108; cached input: 27463655; output: 73167 Sum of all 148 assistant message.usage entries (input + cacheRead + cacheWrite; cacheRead; output) to the cutoff; no other usage entries
Session window recorded 2026-11-15T00:19Z to 2026-11-15T17:49Z; 17 h 30 min First event to cutoff, including idle time waiting for the owner's decision
Compactions recorded 0 Complete record to cutoff; Pit context edits elided six earlier tool results and added notes, which are not compactions
Models recorded azure/anthropic/claude-opus-5-5 (nvidia-internal) Model change event and assistant messages; no changes
Reasoning levels recorded high Thinking level event; no changes

@github-actions

Copy link
Copy Markdown
Contributor

@cv cv added the v1 NemoClaw v1 branch label Nov 15, 2026
@cv
cv marked this pull request as ready for review November 15, 2026 19:23
Moves the Fabric pin from 7f8d4a40 to b4725580, the head of
NVIDIA/NeMo-Fabric#632. The Hermes descriptor no longer supports
skills.bundled.include; the inference names in the
openshift-external-two-providers scenario follow the new catalog.

Signed-off-by: Carlos Villela <cvillela@nvidia.com>
@cv
cv merged commit 1849ae6 into v1 Nov 16, 2026
68 of 70 checks passed
@cv
cv deleted the cv/fabric-pin-632-skills branch November 16, 2026 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v1 NemoClaw v1 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant