Repository navigation
feat(fabric)!: pin Fabric to NVIDIA/NeMo-Fabric#632 for structured skill directories - #14472
Merged
Merged
Conversation
…ill directories Moves the Fabric pin from f33fa19a to 7f8d4a40, the head of NVIDIA/NeMo-Fabric#632. A skills.paths entry is no longer a folder of skills; skills.directories lists folders and skills, with duplicates and bundled policies. OpenClaw no longer accepts runtime.keep_state, so its state is temporary again. The fabric_agent schema now maps properties that can only be null, which skills.directories entries declare. Signed-off-by: Carlos Villela <cvillela@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Collaborator
Author
Authoring session — opening
|
Contributor
|
v1 documentation preview: https://nvidia-preview-nemoclaw-v1-pr-14472.docs.buildwithfern.com/nemoclaw |
cv
marked this pull request as ready for review
November 15, 2026 19:23
Moves the Fabric pin from 7f8d4a40 to b4725580, the head of NVIDIA/NeMo-Fabric#632. The Hermes descriptor no longer supports skills.bundled.include; the inference names in the openshift-external-two-providers scenario follow the new catalog. Signed-off-by: Carlos Villela <cvillela@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the Fabric pin to the head of NVIDIA/NeMo-Fabric#632, so OpenClaw and Hermes agents list their skills in
skills.directories, withduplicatesandbundledpolicies, and OpenClaw agents go back to temporary native state. Documents and HCL that list a folder of skills inskills.pathsmust move it toskills.directories.Problem
At the current pin (
f33fa19a, a fork commit that combines Fabricmainwith NVIDIA/NeMo-Fabric#576, NVIDIA/NeMo-Fabric#615, and an OpenClaw kept-state change):skills.pathsentry can be a folder of skills, a rule that exists only on the fork. feat: load skills from directories with bundled and duplicate controls NeMo-Fabric#632 replaces it withskills.directories, whosefolderandskillentries mean the same thing for every adapter, and addsskills.duplicatesandskills.bundled.runtime.keep_state: recreating or restoring an OpenClaw runtime on a kept state folder failed with "Another Gateway owner lease is still active".Change
b4725580inversions.json, the Cargo manifests, the source line ofCargo.lock, and the documentation links. The commit is the head of feat: load skills from directories with bundled and duplicate controls NeMo-Fabric#632, based on Fabricmainat910218f0; theintegration/nemoclaw-pin-20261116branch of cv/NeMo-Fabric keeps it.image/fabric/catalog.json:runtime.keep_state.skillssupport.runtime.keep_stateonly where the adapter accepts it. Their dashboard token is back at<artifact root>/.fabric/openclaw/runtimes/<runtime-id>/interfaces/dashboard.token. This undoes feat(fabric): pin Fabric to current main and keep OpenClaw's state across runtimes #14385's OpenClaw test, fixture, and documentation changes; Hermes keeps its state.fabric_agent'sskillsblock takesdirectoriesblocks, each withfolderorskill, plusduplicatesand abundledblock.directoriesentry the other key with the typenull, so{"skill": "/x", "folder": null}is accepted.nemoclaw-tofu'sshape) had no type for a property that can only be null, so building the provider schema panicked, and every plan and apply failed with it.skillsblock with onlypathssends nodirectories. Fabric refusesdirectoriesbeside non-emptypaths. HCL therefore can't senddirectories: [], which Fabric reads as no external skills; YAML can.directorieswithduplicates: rejectwherever a folder of skills is meant, which keeps the start failure on duplicate names thatskills.pathshad at the old pin:docker-openclaw-hermes-interfaceslive case;docker-hermes-kept-stateintegration case;examples/hcl/travel-team, whose integration scenario now mounts the skills volume and checks each researcher's skills;directories. Its table now compares how Hermes and OpenClaw find skills in a folder, as Fabric's skills guide at the pin describes.skills.pathsbehaves as inv0.1.0-rc9again: OpenClaw requiresSKILL.mdin each path, and Hermes passes each path toskills.external_dirsunchecked.openshift-external-two-providersscenario.agents,plugins, andtoolssettings, as they omit its other optional settings.Hermes's bundled skills don't change while
skills.bundledis omitted, as in every example and case here:bundled.default: "disabled"andsupports_disable: falsefor that behavior.skills.bundledmakes the adapter copy the selection at start, and it must keephermes-agent.This replaces #14454, which also refreshed the Fabric pin.
Beyond CI
mainonce it merges.fabric.tar.gzSHA-256 from codeload.image/fabric/catalog.jsonwithimage/fabric/catalog.pyfromnemo-fabric-adapter-cataloginstalled from the pinned source.