Skip to content

chore(deps): refresh the Fabric fork pin with upstream main - #14454

Closed
jyaunches wants to merge 3 commits into
v1from
codex/update-fabric-pin-20261113
Closed

jyaunches wants to merge 3 commits into
v1from
codex/update-fabric-pin-20261113

Conversation

@jyaunches

@jyaunches jyaunches commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Move NemoClaw's Fabric pin from f33fa19a to 9228d18a, bringing Hermes and OpenClaw native configuration controls into v1 while preserving the fork's pending skill-folder and OpenClaw state changes.

Problem

The current integration pin lacks the native configuration controls merged in NVIDIA/NeMo-Fabric#627. Updating directly to upstream would omit the fork’s pending skill-folder and OpenClaw state changes.

Change

  • Merge upstream main at 3bf6e1324acc4a08a2176ed203b78505109b4c3a into the existing pinned tree. The merge's first parent is the old pin, preserving its history and pending changes. Resolve overlapping documentation, tests, and generated catalog metadata; adapt the new configuration tests to the fork's required base_dir argument.
  • Retain the combined commit on jyaunches/NeMo-Fabric's integration branch. The fork's main also advances to upstream main.
  • Extend supplied-journey tests’ explicit omission lists for the three new optional OpenClaw setting groups, and refresh the OpenShift two-provider scenario’s inference resource references for the updated pin.
  • Update all three Rust dependency revisions, Cargo.lock, the source archive checksum, the generated adapter catalog, and revision-matched documentation links. Keep the existing Hermes and OpenClaw release pins, which the updated adapters still support.

Beyond CI

The merged Fabric tree passed 307 focused adapter, skill-resolution, configuration, and descriptor-validation tests; 164 tests skipped, including cases requiring an unavailable Hermes SDK. The matching Python binding built, catalog regeneration checked cleanly, and the resolved test files passed Fabric's pinned Python lint and format checks. Both the fork and canonical repository archive URLs returned the same SHA-256.

A broader Fabric Python run was interrupted after 1,795 passes, 202 skips, four failures, and one error. It was not a complete qualification: the disposable checkout lacked built Pi JavaScript artifacts, and a NOOA subprocess test failed in the reused environment. Native Hermes/OpenClaw inference and interface qualification remain unverified by this update.

Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>
…rneys

Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>
@jyaunches

jyaunches commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor Author
Authoring session — opening
Field Status Value Evidence or limit
Harness recorded Codex Desktop; CLI 0.166.0-alpha.5.1 Persisted session metadata matches the checkout, user request, and authored branches.
Skills recorded nemoclaw-contributor-create-pr; test-driven-development; validate-change; karpathy-guidelines (complete reads) Complete read results through cutoff; no delegated agents.
Instruction files partial NemoClaw AGENTS.md and WRITING.md; Fabric AGENTS.md and maintainer skill index; NemoClaw PR and session-report templates Complete injected guidance and read results; some combined early outputs were truncated.
Tool calls recorded exec wrappers: 82; nested exec_command: 114; nested write_stdin: 5 Attempted calls through cutoff, including failures; wrapper and observable nested calls are separate layers and are not added together.
Tokens partial input: 10854456; cached input: 10675968; output: 24527 Last actual event_msg/token_count total_token_usage snapshot before cutoff; the response producing this report is unfinished and later publication activity is excluded.
Session window recorded 2026-11-13T13:41:23.951Z to 2026-11-13T13:57:12.020Z; 15.8 minutes Whole authoring session through cutoff, including idle time; no inherited session history.
Compactions recorded 0 Persisted record through cutoff contains no compaction events.
Models recorded gpt-6.1-sol Persisted turn context; no model changes through cutoff.
Reasoning levels recorded medium Persisted turn context; no effort changes through cutoff.

Local validation for 87bb2808afec37cdc1b277d49c026cfc47402fe4:

  • cargo ci --base origin/v1: formatting, Clippy, and workspace build passed. The final unit run passed 1,878 tests, failed one, and skipped 139. The remaining changes::lockfile_only_git_dependency_updates_select_their_consumers failure also reproduces on unchanged v1 at e2510409b71fe806acc8431723d4af2711a14789: its temporary repository is reported dirty. The 16 catalog-dependent authoring/onboarding failures from the first run were corrected by extending explicit omission lists; the full rerun passed them.
  • cargo test --locked -p nemoclaw-authoring --test integration with the CI profile: 203 passed, 11 ignored.
  • SDK-enabled cargo run --locked -p nemoclaw-build -- schema --check: passed. An earlier cargo ci schema attempt used the SDK-disabled executable left by the baseline diagnostic and was superseded by this direct run.
  • cargo ci live-docker: cannot run on this macOS host because versions.json has no OpenShell pin for darwin_arm64. Bundle, lifecycle, and Linux Docker validation are deferred to the PR's Linux CI; the full local sequence stopped at the baseline test failure.
  • The merged Fabric source built its matching Python binding, passed 307 focused tests (164 skipped), passed catalog consistency and Python lint/format checks, and retained both old-pin and upstream-main commits as direct parents. The broader interrupted Fabric run and its limits are recorded in the PR description.

No live native inference or interface qualification is claimed. The PR's session-report check passed; other required checks were still running when this note was posted.

@github-actions

Copy link
Copy Markdown
Contributor

Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>
@jyaunches

Copy link
Copy Markdown
Contributor Author
Readiness validation — dc673a9

The four platform failures came from stale generated inference resource addresses in openshift-external-two-providers. Commit dc673a93fe29726e8e2ade6e0e06601487573a2c refreshes those six assertion references while preserving the provider, credential, sandbox-isolation, unchanged-reapply, and teardown assertions.

  • Local regression: integration shard 2 passed in 20.36 seconds against the previous CI-built macOS bundle; all five scenarios passed, including the previously failing OpenShift case.
  • Final-candidate CI: all four platforms passed unit, contract, and integration suites. Linux ARM64 and AMD64 Docker and Kubernetes E2E passed, as did hosted native OpenClaw inference and Hermes/OpenClaw parity cases. Both production image builds and documentation checks passed.
  • Trusted hosted Advisor: all nine specialists and the blocker gate passed. Every summary, findings ledger, and E2E receipt was read; all ledgers are clear and match this head and base e2510409b71fe806acc8431723d4af2711a14789. Architecture's optional native OpenClaw recommendation is covered at the applicable v1 boundary by the passing docker-openclaw-nvidia case; main's manual E2E controller accepts only main-based PRs.

The PR is non-draft and mergeable. The existing opening authoring report and its historical cutoff are preserved.

@cv

cv commented Nov 15, 2026

Copy link
Copy Markdown
Collaborator

Closing in favor of #14472, which pins a newer Fabric: the head of NVIDIA/NeMo-Fabric#632, on top of Fabric main at 910218f0. It also moves skills to skills.directories and makes OpenClaw's state temporary again.

@cv cv closed this Nov 15, 2026
cv added a commit that referenced this pull request Nov 16, 2026
…ill directories (#14472)

Moves the Fabric pin to the head of NVIDIA/NeMo-Fabric#632, so OpenClaw
and Hermes agents list their skills in `skills.directories`, with
`duplicates` and `bundled` policies, and OpenClaw agents go back to
temporary native state. Documents and HCL that list a folder of skills
in `skills.paths` must move it to `skills.directories`.

## Problem

At the current pin (`f33fa19a`, a fork commit that combines Fabric
`main` with NVIDIA/NeMo-Fabric#576, NVIDIA/NeMo-Fabric#615, and an
OpenClaw kept-state change):

- An OpenClaw or Hermes `skills.paths` entry can be a folder of skills,
a rule that exists only on the fork. NVIDIA/NeMo-Fabric#632 replaces it
with `skills.directories`, whose `folder` and `skill` entries mean the
same thing for every adapter, and adds `skills.duplicates` and
`skills.bundled`.
- Fabric reverted OpenClaw's `runtime.keep_state`: recreating or
restoring an OpenClaw runtime on a kept state folder failed with
"Another Gateway owner lease is still active".

## Change

- Pins Fabric at `b4725580` in `versions.json`, the Cargo manifests, the
source line of `Cargo.lock`, and the documentation links. The commit is
the head of NVIDIA/NeMo-Fabric#632, based on Fabric `main` at
`910218f0`; the `integration/nemoclaw-pin-20261116` branch of
cv/NeMo-Fabric keeps it.
- Regenerates `image/fabric/catalog.json`:
  - OpenClaw no longer accepts `runtime.keep_state`.
  - Both adapters declare their `skills` support.
- Hermes declares cold resume (NVIDIA/NeMo-Fabric#605) and new native
settings. OpenClaw also declares new native settings; none were removed.
- OpenClaw agents get temporary state again, since NemoClaw sets
`runtime.keep_state` only where the adapter accepts it. Their dashboard
token is back at `<artifact
root>/.fabric/openclaw/runtimes/<runtime-id>/interfaces/dashboard.token`.
This undoes #14385's OpenClaw test, fixture, and documentation changes;
Hermes keeps its state.
- `fabric_agent`'s `skills` block takes `directories` blocks, each with
`folder` or `skill`, plus `duplicates` and a `bundled` block.
- Fabric's schema gives each `directories` entry the other key with the
type `null`, so `{"skill": "/x", "folder": null}` is accepted.
- NemoClaw's schema-to-OpenTofu mapping (`nemoclaw-tofu`'s `shape`) had
no type for a property that can only be null, so building the provider
schema panicked, and every plan and apply failed with it.
- The mapping now leaves such a property out, because omitting it is the
only way to set it.
- The change is in NemoClaw because that mapping is NemoClaw's: Fabric's
schema describes valid configuration correctly, and other JSON schema
consumers handle it.
- The mapping already drops an omitted list block and null attributes,
so a `skills` block with only `paths` sends no `directories`. Fabric
refuses `directories` beside non-empty `paths`. HCL therefore can't send
`directories: []`, which Fabric reads as no external skills; YAML can.
- Uses `directories` with `duplicates: reject` wherever a folder of
skills is meant, which keeps the start failure on duplicate names that
`skills.paths` had at the old pin:
  - the `docker-openclaw-hermes-interfaces` live case;
  - the `docker-hermes-kept-state` integration case;
- `examples/hcl/travel-team`, whose integration scenario now mounts the
skills volume and checks each researcher's skills;
  - the user docs.
- Rewrites Skills on a Mounted Volume for `directories`. Its table now
compares how Hermes and OpenClaw find skills in a folder, as Fabric's
skills guide at the pin describes.
- Adds release notes. `skills.paths` behaves as in `v0.1.0-rc9` again:
OpenClaw requires `SKILL.md` in each path, and Hermes passes each path
to `skills.external_dirs` unchecked.
- Regenerates the provider schema snapshot, the discovery and OpenShell
contract fixtures, and the inference names in the
`openshift-external-two-providers` scenario.
- The onboarding journey tests omit OpenClaw's new `agents`, `plugins`,
and `tools` settings, as they omit its other optional settings.

Hermes's bundled skills don't change while `skills.bundled` is omitted,
as in every example and case here:

- An embedded Hermes agent with a new home has none.
- A runtime with Hermes's API server, dashboard, or terminal gets
Hermes's own copy, which a kept home retains.
- Fabric's new Hermes descriptor declares `bundled.default: "disabled"`
and `supports_disable: false` for that behavior.
- Setting `skills.bundled` makes the adapter copy the selection at
start, and it must keep `hermes-agent`.

This replaces #14454, which also refreshed the Fabric pin.

## Beyond CI

- The pin is the head of NVIDIA/NeMo-Fabric#632, which is open and under
review. Move the pin to Fabric `main` once it merges.
- Recomputed the `fabric.tar.gz` SHA-256 from codeload.
- Regenerated `image/fabric/catalog.json` with `image/fabric/catalog.py`
from `nemo-fabric-adapter-catalog` installed from the pinned source.

---------

Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: integrations Third-party service integration behavior area: packaging Packages, images, registries, installers, or distribution chore Build, CI, dependency, or tooling maintenance integration: hermes Hermes integration behavior integration: openclaw OpenClaw integration behavior v1 NemoClaw v1 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants