Repository navigation
Conversation
Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>
…rneys Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>
Authoring session — opening
Local validation for
No live native inference or interface qualification is claimed. The PR's session-report check passed; other required checks were still running when this note was posted. |
|
v1 documentation preview: https://nvidia-preview-nemoclaw-v1-pr-14454.docs.buildwithfern.com/nemoclaw |
Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>
Readiness validation — dc673a9The four platform failures came from stale generated inference resource addresses in
The PR is non-draft and mergeable. The existing opening authoring report and its historical cutoff are preserved. |
|
Closing in favor of #14472, which pins a newer Fabric: the head of NVIDIA/NeMo-Fabric#632, on top of Fabric |
…ill directories (#14472) Moves the Fabric pin to the head of NVIDIA/NeMo-Fabric#632, so OpenClaw and Hermes agents list their skills in `skills.directories`, with `duplicates` and `bundled` policies, and OpenClaw agents go back to temporary native state. Documents and HCL that list a folder of skills in `skills.paths` must move it to `skills.directories`. ## Problem At the current pin (`f33fa19a`, a fork commit that combines Fabric `main` with NVIDIA/NeMo-Fabric#576, NVIDIA/NeMo-Fabric#615, and an OpenClaw kept-state change): - An OpenClaw or Hermes `skills.paths` entry can be a folder of skills, a rule that exists only on the fork. NVIDIA/NeMo-Fabric#632 replaces it with `skills.directories`, whose `folder` and `skill` entries mean the same thing for every adapter, and adds `skills.duplicates` and `skills.bundled`. - Fabric reverted OpenClaw's `runtime.keep_state`: recreating or restoring an OpenClaw runtime on a kept state folder failed with "Another Gateway owner lease is still active". ## Change - Pins Fabric at `b4725580` in `versions.json`, the Cargo manifests, the source line of `Cargo.lock`, and the documentation links. The commit is the head of NVIDIA/NeMo-Fabric#632, based on Fabric `main` at `910218f0`; the `integration/nemoclaw-pin-20261116` branch of cv/NeMo-Fabric keeps it. - Regenerates `image/fabric/catalog.json`: - OpenClaw no longer accepts `runtime.keep_state`. - Both adapters declare their `skills` support. - Hermes declares cold resume (NVIDIA/NeMo-Fabric#605) and new native settings. OpenClaw also declares new native settings; none were removed. - OpenClaw agents get temporary state again, since NemoClaw sets `runtime.keep_state` only where the adapter accepts it. Their dashboard token is back at `<artifact root>/.fabric/openclaw/runtimes/<runtime-id>/interfaces/dashboard.token`. This undoes #14385's OpenClaw test, fixture, and documentation changes; Hermes keeps its state. - `fabric_agent`'s `skills` block takes `directories` blocks, each with `folder` or `skill`, plus `duplicates` and a `bundled` block. - Fabric's schema gives each `directories` entry the other key with the type `null`, so `{"skill": "/x", "folder": null}` is accepted. - NemoClaw's schema-to-OpenTofu mapping (`nemoclaw-tofu`'s `shape`) had no type for a property that can only be null, so building the provider schema panicked, and every plan and apply failed with it. - The mapping now leaves such a property out, because omitting it is the only way to set it. - The change is in NemoClaw because that mapping is NemoClaw's: Fabric's schema describes valid configuration correctly, and other JSON schema consumers handle it. - The mapping already drops an omitted list block and null attributes, so a `skills` block with only `paths` sends no `directories`. Fabric refuses `directories` beside non-empty `paths`. HCL therefore can't send `directories: []`, which Fabric reads as no external skills; YAML can. - Uses `directories` with `duplicates: reject` wherever a folder of skills is meant, which keeps the start failure on duplicate names that `skills.paths` had at the old pin: - the `docker-openclaw-hermes-interfaces` live case; - the `docker-hermes-kept-state` integration case; - `examples/hcl/travel-team`, whose integration scenario now mounts the skills volume and checks each researcher's skills; - the user docs. - Rewrites Skills on a Mounted Volume for `directories`. Its table now compares how Hermes and OpenClaw find skills in a folder, as Fabric's skills guide at the pin describes. - Adds release notes. `skills.paths` behaves as in `v0.1.0-rc9` again: OpenClaw requires `SKILL.md` in each path, and Hermes passes each path to `skills.external_dirs` unchecked. - Regenerates the provider schema snapshot, the discovery and OpenShell contract fixtures, and the inference names in the `openshift-external-two-providers` scenario. - The onboarding journey tests omit OpenClaw's new `agents`, `plugins`, and `tools` settings, as they omit its other optional settings. Hermes's bundled skills don't change while `skills.bundled` is omitted, as in every example and case here: - An embedded Hermes agent with a new home has none. - A runtime with Hermes's API server, dashboard, or terminal gets Hermes's own copy, which a kept home retains. - Fabric's new Hermes descriptor declares `bundled.default: "disabled"` and `supports_disable: false` for that behavior. - Setting `skills.bundled` makes the adapter copy the selection at start, and it must keep `hermes-agent`. This replaces #14454, which also refreshed the Fabric pin. ## Beyond CI - The pin is the head of NVIDIA/NeMo-Fabric#632, which is open and under review. Move the pin to Fabric `main` once it merges. - Recomputed the `fabric.tar.gz` SHA-256 from codeload. - Regenerated `image/fabric/catalog.json` with `image/fabric/catalog.py` from `nemo-fabric-adapter-catalog` installed from the pinned source. --------- Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Move NemoClaw's Fabric pin from
f33fa19ato9228d18a, bringing Hermes and OpenClaw native configuration controls intov1while preserving the fork's pending skill-folder and OpenClaw state changes.Problem
The current integration pin lacks the native configuration controls merged in NVIDIA/NeMo-Fabric#627. Updating directly to upstream would omit the fork’s pending skill-folder and OpenClaw state changes.
Change
mainat3bf6e1324acc4a08a2176ed203b78505109b4c3ainto the existing pinned tree. The merge's first parent is the old pin, preserving its history and pending changes. Resolve overlapping documentation, tests, and generated catalog metadata; adapt the new configuration tests to the fork's requiredbase_dirargument.mainalso advances to upstreammain.Beyond CI
The merged Fabric tree passed 307 focused adapter, skill-resolution, configuration, and descriptor-validation tests; 164 tests skipped, including cases requiring an unavailable Hermes SDK. The matching Python binding built, catalog regeneration checked cleanly, and the resolved test files passed Fabric's pinned Python lint and format checks. Both the fork and canonical repository archive URLs returned the same SHA-256.
A broader Fabric Python run was interrupted after 1,795 passes, 202 skips, four failures, and one error. It was not a complete qualification: the disposable checkout lacked built Pi JavaScript artifacts, and a NOOA subprocess test failed in the reused environment. Native Hermes/OpenClaw inference and interface qualification remain unverified by this update.