Repository navigation
Conversation
Contributor
Author
Authoring session — opening
|
Contributor
|
v1 documentation preview: https://nvidia-preview-nemoclaw-v1-pr-14362.docs.buildwithfern.com/nemoclaw |
cv
added a commit
that referenced
this pull request
Nov 11, 2026
…ross runtimes (#14385) Moves the Fabric pin from `316fbdfb` to `f33fa19a`, which adds everything merged to NVIDIA/NeMo-Fabric `main` through `6015e7cf` to the pending Hermes home, skill folder, and OpenClaw kept-state changes. OpenClaw agents now keep their native state and the skills they author across runtimes, as Hermes agents already do. ## Problem At the current pin (`316fbdfb`, branched from Fabric `main` on 2026-11-06): - Fabric `main` has 15 commits the pin lacks. They include the merged versions of NVIDIA/NeMo-Fabric#572 (the kept-state lock) and NVIDIA/NeMo-Fabric#573 (OpenClaw's interfaces), runtime health fixes that report an exited harness as failed instead of unknown (NVIDIA/NeMo-Fabric#298), and Hermes Relay 0.11 support. - OpenClaw's adapter keeps native state in a temporary directory that it removes at stop, so an OpenClaw agent loses its history and the skills it authored whenever its runtime is replaced. #14362 proposes the OpenClaw change with a pin on a fork of a fork, based on an older Fabric `main`. ## Change - Pins Fabric at `f33fa19a` in `versions.json`, the Cargo manifests and lock file, and the documentation links. The commit combines Fabric `main` with NVIDIA/NeMo-Fabric#576, NVIDIA/NeMo-Fabric#615, and the OpenClaw kept-state change, and the `integration/nemoclaw-pin-20261110` branch of cv/NeMo-Fabric keeps it. - Regenerates `image/fabric/catalog.json`: OpenClaw accepts `runtime.keep_state`, and the Hermes and OpenClaw adapters declare a `terminal` interface. - NemoClaw sets `runtime.keep_state` wherever the adapter accepts it, so OpenClaw agents now keep their state in `/sandbox/artifacts/.fabric/state/nvidia.fabric.openclaw/<agent name>`. Their dashboard token moves to that folder's `interfaces/`, and apply prints the new path. - Plan no longer rejects Hermes's `terminal` interface; NemoClaw reports it as documented by the adapter, without a token path. - Updates the state, interface, usage, and limits pages, and removes the Fabric#298 limitation. - Updates the tests and fixtures that pin the generated configuration: the Fabric compatibility and interface access tests, the discovery and OpenShell contract fixtures, and the inference names in the `openshift-external-two-providers` scenario. The test and documentation changes are adapted from #14362, which this replaces. Left out: moving the bundled Hermes from v0.22.5 to v0.22.7, which the pinned adapter also supports, and reporting the new terminal interfaces. ## Beyond CI The pinned commit is on a fork until NVIDIA/NeMo-Fabric#576 and NVIDIA/NeMo-Fabric#615 merge; the pin should then move to a commit on Fabric `main`. --------- Signed-off-by: Carlos Villela <cvillela@nvidia.com> Co-authored-by: J. Yaunches <jyaunches@nvidia.com>
Pin Fabric to the integration revision that removes OpenClaw native-state retention, so recreate and restore no longer reuse an unexpired Gateway ownership lease. ## Problem With the previous pin, ordinary OpenClaw replacement can fail with `Another Gateway owner lease is still active for this state directory`. The Gateway exceeds Fabric's five-second shutdown allowance, and its unreleased lease survives in retained native state. ## Change - Move the planner and image pin to `cc6f6ba153f25a9e5746ea794d6c2282d86539e0`, which reverses the OpenClaw retention implementation and documentation while preserving the other integration changes. Keep the canonical NVIDIA source URLs and verify the archive checksum. - Regenerate the adapter catalog and refresh discovery, configuration, and interface-token expectations. Hermes continues to retain its native state. - Document OpenClaw's return to temporary native state. Native conversation history and authored skills no longer survive runtime replacement; caller-mounted workspace and artifact files still can. This does not delete existing retained data or repair the underlying shutdown problem. ## Beyond CI The reverted Fabric Git tree exactly matches the controlled Brev comparison: AMD64, OpenClaw `2026.9.34 (f123d43)`, and OpenRouter `openai/gpt-4.1-mini`. Initial use, destroy/recreate, a tool configuration change, and restore passed with fresh inference and native tool effects. The same base revisions with retention enabled failed recreate and restore. Forced shutdown still occurred without retention, confirming that retention exposes the leftover lease rather than introducing the forced shutdown. Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>
Collaborator
|
Closing as superseded by #14385, which moved the Fabric pin to The Gateway lease failure that #14406 found ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update NemoClaw's Fabric planner and agent images to a clean integration commit maintained in
jyaunches/NeMo-Fabric, fetched through the existing canonical NVIDIA URLs. The pin includes current upstream runtime-health fixes and retained OpenClaw native state and skills.Problem
The previous pin predates Fabric's OpenShell startup-readiness and runtime-health fixes. OpenClaw also stores authored skills in temporary native state that disappears when its runtime stops.
Change
1b5c8ce5057f846dd86db6788e0be38c6b3675af, with the verified archive checksum and regenerated adapter catalog.f37b150a915ae0ebb7462616d73f2f7c0f5f4bbc. Carry only the remaining Control UI, retained-state, retained Hermes home, and skill-folder changes, including feat: keep OpenClaw's native state in the agent's state folder cv/NeMo-Fabric#1. Earlier fork-stack commits are not in its ancestry; merged features come from upstream main.runtime.keep_statethrough NemoClaw's existing descriptor-driven configuration. Refresh token-path assertions, generated fixtures, and state and health documentation. Retention does not select or resume a conversation.Beyond CI
The clean Fabric commit has exactly the same Git tree as the tested integration candidate. Its standalone Rust suite passed 338 tests; the full TypeScript suite and consumer package-install checks passed. The Python run passed 3,448 tests with 190 skips; its two failures passed on focused retests after building Kiro and using the existing Homebrew Python for copied virtual environments. Native Hermes passed 166 tests (one skipped), and native OpenClaw skills passed five tests on macOS. Linux-only live deployment coverage runs through NemoClaw's GitHub E2E lanes.