Skip to content

fix: update Fabric pin with retained OpenClaw state - #14362

Closed
jyaunches wants to merge 4 commits into
v1from
run-brev-v1-e2e/fabric-fork-main-20261110
Closed

jyaunches wants to merge 4 commits into
v1from
run-brev-v1-e2e/fabric-fork-main-20261110

Conversation

@jyaunches

@jyaunches jyaunches commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Update NemoClaw's Fabric planner and agent images to a clean integration commit maintained in jyaunches/NeMo-Fabric, fetched through the existing canonical NVIDIA URLs. The pin includes current upstream runtime-health fixes and retained OpenClaw native state and skills.

Problem

The previous pin predates Fabric's OpenShell startup-readiness and runtime-health fixes. OpenClaw also stores authored skills in temporary native state that disappears when its runtime stops.

Change

  • Pin Rust dependencies and image sources to 1b5c8ce5057f846dd86db6788e0be38c6b3675af, with the verified archive checksum and regenerated adapter catalog.
  • Base the integration directly on NVIDIA main f37b150a915ae0ebb7462616d73f2f7c0f5f4bbc. Carry only the remaining Control UI, retained-state, retained Hermes home, and skill-folder changes, including feat: keep OpenClaw's native state in the agent's state folder cv/NeMo-Fabric#1. Earlier fork-stack commits are not in its ancestry; merged features come from upstream main.
  • Preserve the canonical source policy and revision/catalog consistency checks. NVIDIA's repository resolves the fork commit and serves its checksum-verified archive without another upstream PR.
  • Enable OpenClaw's declared runtime.keep_state through NemoClaw's existing descriptor-driven configuration. Refresh token-path assertions, generated fixtures, and state and health documentation. Retention does not select or resume a conversation.

Beyond CI

The clean Fabric commit has exactly the same Git tree as the tested integration candidate. Its standalone Rust suite passed 338 tests; the full TypeScript suite and consumer package-install checks passed. The Python run passed 3,448 tests with 190 skips; its two failures passed on focused retests after building Kiro and using the existing Homebrew Python for copied virtual environments. Native Hermes passed 166 tests (one skipped), and native OpenClaw skills passed five tests on macOS. Linux-only live deployment coverage runs through NemoClaw's GitHub E2E lanes.

@jyaunches

Copy link
Copy Markdown
Contributor Author
Authoring session — opening
Field Status Value Evidence or limit
Harness recorded Codex Desktop; CLI 0.166.0-alpha.5.1 Persisted authoring-session metadata, inspected through the cutoff below.
Skills partial validate-change; karpathy-guidelines; python-tests; test-driven-development; nemoclaw-contributor-create-pr (complete reads) Verified complete reads for this pin update; earlier research includes truncated skill outputs, so this is not a complete session inventory.
Instruction files partial Fabric AGENTS.md; NemoClaw AGENTS.md and WRITING.md; task-directory AGENTS.md; PR and session-report templates Verified complete reads for authoring; some earlier directory-guidance output was truncated.
Tool calls partial exec: 172; request_user_input_async: 2; wait: 1; sleep: 11 Attempted calls at the recorded tool-wrapper layer, including failures. Nested shell/tool calls are not separately counted; these totals are not a count of shell commands.
Session window recorded 2026-11-09T13:40:57.690Z to 2026-11-10T15:29:46.098Z; 1549 minutes Whole recorded session, including prior Fabric research and idle time; cutoff precedes PR publication.
Compactions recorded 2 Persisted compaction events through cutoff.
Models recorded gpt-6-astra Recorded turn contexts through cutoff.
Reasoning levels recorded medium Recorded turn contexts through cutoff.

@github-actions

Copy link
Copy Markdown
Contributor

@jyaunches jyaunches changed the title fix: pin Fabric fork with OpenClaw state retention fix: update Fabric pin with retained OpenClaw state Nov 10, 2026
@jyaunches
jyaunches requested a review from cv November 10, 2026 16:34
cv added a commit that referenced this pull request Nov 11, 2026
…ross runtimes (#14385)

Moves the Fabric pin from `316fbdfb` to `f33fa19a`, which adds
everything merged to NVIDIA/NeMo-Fabric `main` through `6015e7cf` to the
pending Hermes home, skill folder, and OpenClaw kept-state changes.
OpenClaw agents now keep their native state and the skills they author
across runtimes, as Hermes agents already do.

## Problem

At the current pin (`316fbdfb`, branched from Fabric `main` on
2026-11-06):

- Fabric `main` has 15 commits the pin lacks. They include the merged
versions of NVIDIA/NeMo-Fabric#572 (the kept-state lock) and
NVIDIA/NeMo-Fabric#573 (OpenClaw's interfaces), runtime health fixes
that report an exited harness as failed instead of unknown
(NVIDIA/NeMo-Fabric#298), and Hermes Relay 0.11 support.
- OpenClaw's adapter keeps native state in a temporary directory that it
removes at stop, so an OpenClaw agent loses its history and the skills
it authored whenever its runtime is replaced.

#14362 proposes the OpenClaw change with a pin on a fork of a fork,
based on an older Fabric `main`.

## Change

- Pins Fabric at `f33fa19a` in `versions.json`, the Cargo manifests and
lock file, and the documentation links. The commit combines Fabric
`main` with NVIDIA/NeMo-Fabric#576, NVIDIA/NeMo-Fabric#615, and the
OpenClaw kept-state change, and the `integration/nemoclaw-pin-20261110`
branch of cv/NeMo-Fabric keeps it.
- Regenerates `image/fabric/catalog.json`: OpenClaw accepts
`runtime.keep_state`, and the Hermes and OpenClaw adapters declare a
`terminal` interface.
- NemoClaw sets `runtime.keep_state` wherever the adapter accepts it, so
OpenClaw agents now keep their state in
`/sandbox/artifacts/.fabric/state/nvidia.fabric.openclaw/<agent name>`.
Their dashboard token moves to that folder's `interfaces/`, and apply
prints the new path.
- Plan no longer rejects Hermes's `terminal` interface; NemoClaw reports
it as documented by the adapter, without a token path.
- Updates the state, interface, usage, and limits pages, and removes the
Fabric#298 limitation.
- Updates the tests and fixtures that pin the generated configuration:
the Fabric compatibility and interface access tests, the discovery and
OpenShell contract fixtures, and the inference names in the
`openshift-external-two-providers` scenario.

The test and documentation changes are adapted from #14362, which this
replaces.
Left out: moving the bundled Hermes from v0.22.5 to v0.22.7, which the
pinned adapter also supports, and reporting the new terminal interfaces.

## Beyond CI

The pinned commit is on a fork until NVIDIA/NeMo-Fabric#576 and
NVIDIA/NeMo-Fabric#615 merge; the pin should then move to a commit on
Fabric `main`.

---------

Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Co-authored-by: J. Yaunches <jyaunches@nvidia.com>
Pin Fabric to the integration revision that removes OpenClaw
native-state retention, so recreate and restore no longer reuse an
unexpired Gateway ownership lease.

## Problem

With the previous pin, ordinary OpenClaw replacement can fail with
`Another Gateway owner lease is still active for this state directory`.
The Gateway exceeds Fabric's five-second shutdown allowance, and its
unreleased lease survives in retained native state.

## Change

- Move the planner and image pin to
`cc6f6ba153f25a9e5746ea794d6c2282d86539e0`, which reverses the OpenClaw
retention implementation and documentation while preserving the other
integration changes. Keep the canonical NVIDIA source URLs and verify
the archive checksum.
- Regenerate the adapter catalog and refresh discovery, configuration,
and interface-token expectations. Hermes continues to retain its native
state.
- Document OpenClaw's return to temporary native state. Native
conversation history and authored skills no longer survive runtime
replacement; caller-mounted workspace and artifact files still can. This
does not delete existing retained data or repair the underlying shutdown
problem.

## Beyond CI

The reverted Fabric Git tree exactly matches the controlled Brev
comparison: AMD64, OpenClaw `2026.9.34 (f123d43)`, and OpenRouter
`openai/gpt-4.1-mini`. Initial use, destroy/recreate, a tool
configuration change, and restore passed with fresh inference and native
tool effects. The same base revisions with retention enabled failed
recreate and restore. Forced shutdown still occurred without retention,
confirming that retention exposes the leftover lease rather than
introducing the forced shutdown.

Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>
@cv

cv commented Nov 12, 2026

Copy link
Copy Markdown
Collaborator

Closing as superseded by #14385, which moved the Fabric pin to f33fa19a and turned on OpenClaw's kept state. This branch now conflicts with v1 in 13 of its 14 files.

The Gateway lease failure that #14406 found (Another Gateway owner lease is still active on recreate and restore) likely affects v1 at f33fa19a too, so it still needs a v1 issue.

@cv cv closed this Nov 12, 2026
@wscurran wscurran added area: integrations Third-party service integration behavior area: packaging Packages, images, registries, installers, or distribution chore Build, CI, dependency, or tooling maintenance integration: openclaw OpenClaw integration behavior v1 NemoClaw v1 branch labels Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: integrations Third-party service integration behavior area: packaging Packages, images, registries, installers, or distribution chore Build, CI, dependency, or tooling maintenance integration: openclaw OpenClaw integration behavior v1 NemoClaw v1 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants