Repository navigation
Record the hole union's EdgeGrid and IntArrayList in the API baseline - #34
Merged
Merged
Conversation
This was referenced Nov 9, 2026
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
なぜ
#33（穴の結合）で
PolygonHoleUnion.ktにEdgeGridとIntArrayListを足しましたが、ベースラインを更新していませんでした。どちらも top-level のprivate classなので、バイトコードでは package-private のクラスになり、既存のEdgeやNodeと同じく android-sdk（集約ビルド）のapiCheckのダンプに出ます。そのため 6fc9b53 の android-sdk-core を指すと、android-sdk で./gradlew :android-sdk-core:apiCheckが落ちます。（このリポジトリ単体の CI は
assembleReleaseだけで、apiCheckは集約ビルドにしかないため、#33 では気づけませんでした。）何を変えたか
api/android-sdk-core.apiにEdgeGrid・IntArrayListの 2 クラス（11 行）を追加。android-sdk で./gradlew :android-sdk-core:apiDumpを回した結果そのものです。コードは変えていません。検証
:android-sdk-core:apiCheckが通ることを確認。6fc9b53 のままだと上の 7 宣言が「追加された宣言」として落ちます。