Repository navigation
Point android-sdk-core at the polygon hole union fix - #117
Merged
Merged
Conversation
android-sdk-core 6fc9b53 (MapConductor/android-sdk-core#33): unionHoleRings merges touching or overlapping holes so their shared area is not filled back in. Also brings in the core changes merged since e216c96 (overlay stacking order, clear strategy, geodesic fill, clear order).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
なぜ
近い穴を結合するときに穴の面積が失われ、街区などが塗りつぶされていた不具合の修正が android-sdk-core でマージ済みです:
何を変えたか
検証
./gradlew :android-sdk-core:testDebugUnitTest :android-sdk-compose:testDebugUnitTest :android-kml:testDebugUnitTest :android-geojson-layer:testDebugUnitTest :android-icons:testDebugUnitTest(test.yml と同じ 5 モジュール): 330 / 8 / 15 / 2 / 3 件、すべて pass。:example-app:assembleDebug: 通る。:android-sdk-core:apiCheckは 6fc9b53 のままだと落ちます。 Revert "Update .editorconfig (#32)" #33 で足した private クラス(EdgeGrid,IntArrayList)がベースラインに入っていないためです(コードの問題ではありません)。ベースラインだけを足す PR を出しました: Record the hole union's EdgeGrid and IntArrayList in the API baseline android-sdk-core#34。それを向けた状態で apiCheck が通ることは確認済みです。Ignore all build directories #34 のマージ後に gitlink をそのマージ commit へ進めるか、この PR のマージ前にこちらで進めます。確認できていないもの