Repository navigation
Add Polygons(states) for registering many polygons at once - #13
Merged
Merged
Conversation
Same shape as Markers(states): diffs the list against the ids this call added last time and publishes the result in one collector update, so several Polygons()/Polygon() can share a map.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
何をするか
多数のポリゴン(既定: 2,000 個以上または頂点 50,000 以上)を、ネイティブの図形ではなくラスタータイルとして描きます(
PolygonTilingOptions/PolygonTiler)。web・Android・iOS で同じ設計です。このリポジトリで変えたこと
Polygons(states): 多数のポリゴンを 1 つの effect で登録する(タイル化の入口)。develop の merge は衝突なし。develop の取り込み
このブランチは push 済みだったので、rebase せず
origin/developを merge commit で取り込みました。testDebugUnitTest: core 350 件ほか全部 pass(OMM は develop から引き継いだ 1 件の失敗のみ。android.util.Log.isLoggableがテストでモックされていない)。apiCheck: 全モジュール ok(増えた API はベースラインに追加)。マージの順番
この機能は複数のリポジトリにまたがります。android-sdk-core → android-sdk-compose(feat/polygons)→ 各 android-for- → android-sdk(親)* の順にマージが要ります。
この PR は大きな機能なので、マージするかはレビューのうえで判断してください。