perf(ds4): optimize q5 fused verifier on AMD - #569
Draft
davide221 wants to merge 4 commits into
Draft
Conversation
davide221
force-pushed
the
codex/ds4-16k-amd-opt
branch
from
August 3, 2026 21:26
be20268 to
0208630
Compare
davide221
force-pushed
the
codex/ds4-q5-verifier
branch
from
August 4, 2026 10:17
5417326 to
e24ad65
Compare
This was referenced Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #565 is now merged; this branch is rebased directly on
mainand remains a draft while gated rejected candidates are cleaned up.AMD validation
Hardware profile: R9700 target plus Strix Halo expert device, in-process expert parallelism, four active experts, 36 hot experts per layer, one request at a time, 128 output tokens, temperature 0.
All 25 requests in the 2K -> 4K -> 8K -> 16K -> post-16K 2K sequence produced the exact expected SHA-256:
0f785a7ffa406498aafb14553966eaed0f52220fed0f7cc016b66921d104d194The two-second monitor observed a 30.561 GiB R9700 peak during the full hot-36 sweep. This expert budget is a hardware profile, not a portable default for smaller cards.
The final
test_deepseek4_unitGPU suite completed withOK. The sweep left MMVQ width, verifier slots, and x4+1 onauto; logs confirmed width 5, nine slots, and the gfx1201 x4+1 default.Reproduction
Run
server/scripts/qualify_ds4_q5_amd.shwithTARGET_MODEL,DRAFT_MODEL, andHOTNESS_CSV. It records the manifest, exact response hashes, timings, ROCm state, and VRAM trace.Measured A/B decisions
Before marking ready
main