feat(ds4): add external ROCTX phase markers - #554
Open
cheese-cakee wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 10 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 6 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 5 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
cheese-cakee
marked this pull request as draft
August 4, 2026 20:50
cheese-cakee
force-pushed
the
codex/perf-ds4-gpu-profiler
branch
from
August 4, 2026 20:50
90ac4e5 to
3aaf9b1
Compare
cheese-cakee
marked this pull request as ready for review
August 4, 2026 21:38
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 10 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Carry semantic phase by value through ROCTX scopes and mixed-layer IPC so remote Halo shard markers label decode correctly instead of unspecified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This replaces the superseded historical in-process HIP-event profiler on current
main. The old implementation recorded on a null/default stream and synchronized events, which could fence unrelated streams and distort the two-owner overlap being measured. This rewrite intentionally performs no internal GPU timing.Behavior contract
DFLASH_DS4_ROCTX=1enables balanced semantic ranges for correlation with an external rocprof kernel/copy trace. The marker layer:Validation completed
git diff --checkpassedPending before ready-for-review / profiling claims
The Lucebox machines are currently unavailable, so this is reopened as a draft. The completed standalone checks do not constitute target-hardware validation, and no performance result is claimed. Historical CI and reviews applied to the superseded event-timing implementation and should not be treated as evidence for this rewrite.
Stack
Independent current-main PR. It does not depend on #548 or the #569/#575/#577 performance stack. #575 may provide a useful external rocprof collection wrapper, but it is not a code prerequisite.