test(ds4): preserve reference-exact speculative verification - #548
Open
cheese-cakee wants to merge 4 commits into
Open
test(ds4): preserve reference-exact speculative verification#548cheese-cakee wants to merge 4 commits into
cheese-cakee wants to merge 4 commits into
Conversation
cheese-cakee
marked this pull request as ready for review
July 20, 2026 14:12
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 6 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
This was referenced Jul 21, 2026
cheese-cakee
marked this pull request as draft
August 4, 2026 20:44
cheese-cakee
force-pushed
the
codex/fix-ds4-fused-verify
branch
from
August 4, 2026 20:44
cba8487 to
82a3377
Compare
cheese-cakee
marked this pull request as ready for review
August 4, 2026 21:39
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 7 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 4 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 1 file (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DFLASH_DS4_SPEC_REFERENCE_EXACT=1as the supported reference-exact speculative verification modeDFLASH_DS4_FUSED_VERIFY=1intentionally approximate for throughput experimentsThis replaces the superseded historical diff on current
main. The previous fail-closed fused-flag policy is intentionally not restored: reference-exact verification and approximate fused verification are separate modes.Exactness contract
The gate holds the target execution policy constant between greedy AR and reference-exact speculation, sanitizes inherited DS4/MoE/MMVQ policy variables, and differs only in DSpark/spec/reference-exact activation. It requires:
matched/offeredcountersmatched < offered)full_snap=1, proving the rollback-capable path was activeThe gate retains both logs and a manifest instead of overwriting evidence.
Validation completed
git diff --checkpassedPending before ready-for-review / exactness claim
The Lucebox machines and target artifacts are currently unavailable, so this is reopened as a draft. No target-hardware parity or performance result is claimed yet. Historical CI and reviews applied to the superseded implementation and should not be treated as evidence for this rewrite.
Stack
Independent current-main PR. It does not depend on #554 or the #569/#575/#577 performance stack.