Repository navigation
i18n: extract Devices and the root App - #145
Merged
Merged
Conversation
Extract the user-facing English strings of the Devices view and the root App.svelte into the catalog (en / zh-Hans / zh-Hant), one key per sentence, grouped per component (devices.* / app.*). en.json stays the source of truth; both Chinese scripts are aligned, no orphan keys. No lib/ behavior changes. - src/lib/i18n.test.js alignment gate green (0 missing / 0 extra / no empty) - npm test 336/336, vite build clean (removed now-dead .boot-hint code rule)
|
@Janlhin is attempting to deploy a commit to the sivadaboi's projects Team on Vercel. A member of the Team first needs to authorize it. |
Collaborator
|
Thanks, merged. Two small things for your next PR: |
This was referenced Nov 7, 2026
Omar-VF
pushed a commit
that referenced
this pull request
Nov 9, 2026
The boot label was still hardcoded even though app.startingOpenSave was already in the catalogs, and app.detailsSaved was still English in zh-Hans and zh-Hant. Both were pointed out in the #145 merge review. Only the reference and the two values change; key sets stay aligned with en.json.
Omar-VF
added a commit
that referenced
this pull request
Nov 9, 2026
i18n: finish the two app strings left over from #145
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Extracts the user-facing strings of the Devices view and the root
App.svelteinto the catalog (en/zh-Hans/zh-Hant), one key per sentence, grouped per component (devices.*/app.*).en.jsonstays the source of truth; both Chinese scripts carry the same keys.Notes
src/lib/i18n.test.jsgreen).lib/behavior changes — only string extraction plus catalog additions.common.dismisskey (already present from earlier i18n PRs) instead of adding a duplicate.npm test336/336 ·vite buildclean · catalog alignment verified.Verification
npm testincl.i18n.test.jsalignment gate (no orphan keys, no missing keys, no empty values) — all pass.npx vite build— clean, no errors/warnings (removed the now-dead.boot-hint codeCSS rule that the change left behind).$t('devices.*' | 'app.*')reference (65 total) resolves to an existing, non-emptyen.jsonkey.Translation and review: @Janlhin (simplified & traditional)