Skip to content

i18n: extract Devices and the root App - #145

Merged
Omar-VF merged 1 commit into
Liquid-co:dev-publicfrom
Janlhin:pr-4-devices-and-app
Nov 7, 2026
Merged

Omar-VF merged 1 commit into
Liquid-co:dev-publicfrom
Janlhin:pr-4-devices-and-app

Conversation

@Janlhin

@Janlhin Janlhin commented Nov 3, 2026

Copy link
Copy Markdown

What

Extracts the user-facing strings of the Devices view and the root App.svelte into the catalog (en / zh-Hans / zh-Hant), one key per sentence, grouped per component (devices.* / app.*). en.json stays the source of truth; both Chinese scripts carry the same keys.

Notes

  • Both Chinese scripts in the same commit, keys aligned (scripted check: 0 missing / 0 extra; src/lib/i18n.test.js green).
  • No lib/ behavior changes — only string extraction plus catalog additions.
  • Reuses the existing common.dismiss key (already present from earlier i18n PRs) instead of adding a duplicate.
  • npm test 336/336 · vite build clean · catalog alignment verified.

Verification

  • npm test incl. i18n.test.js alignment gate (no orphan keys, no missing keys, no empty values) — all pass.
  • npx vite build — clean, no errors/warnings (removed the now-dead .boot-hint code CSS rule that the change left behind).
  • Every $t('devices.*' | 'app.*') reference (65 total) resolves to an existing, non-empty en.json key.

Translation and review: @Janlhin (simplified & traditional)

Extract the user-facing English strings of the Devices view and the root
App.svelte into the catalog (en / zh-Hans / zh-Hant), one key per sentence,
grouped per component (devices.* / app.*). en.json stays the source of truth;
both Chinese scripts are aligned, no orphan keys. No lib/ behavior changes.

- src/lib/i18n.test.js alignment gate green (0 missing / 0 extra / no empty)
- npm test 336/336, vite build clean (removed now-dead .boot-hint code rule)
@vercel

vercel Bot commented Nov 3, 2026

Copy link
Copy Markdown

@Janlhin is attempting to deploy a commit to the sivadaboi's projects Team on Vercel.

A member of the Team first needs to authorize it.

@Omar-VF
Omar-VF merged commit 304f78a into Liquid-co:dev-public Nov 7, 2026
10 of 11 checks passed
@Omar-VF

Omar-VF commented Nov 7, 2026

Copy link
Copy Markdown
Collaborator

Thanks, merged. Two small things for your next PR: App.svelte:293 still hardcodes "Starting OpenSave…", though app.startingOpenSave is already in the catalogues, and app.detailsSaved is still English in zh-Hans and zh-Hant.

Omar-VF pushed a commit that referenced this pull request Nov 9, 2026
The boot label was still hardcoded even though app.startingOpenSave was already in the catalogs, and app.detailsSaved was still English in zh-Hans and zh-Hant. Both were pointed out in the #145 merge review. Only the reference and the two values change; key sets stay aligned with en.json.
Omar-VF added a commit that referenced this pull request Nov 9, 2026
i18n: finish the two app strings left over from #145
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants