Repository navigation
Conversation
The boot label was still hardcoded even though app.startingOpenSave was already in the catalogs, and app.detailsSaved was still English in zh-Hans and zh-Hant. Both were pointed out in the Liquid-co#145 merge review. Only the reference and the two values change; key sets stay aligned with en.json.
Replayed the two original batches onto the current dev-public base, with the Liquid-co#145 follow-up (PR4b) as its parent. The three catalogs gain 245 keys each; no existing key was changed or removed. The 13 game-detail views now use $t(). A duplicate import of t in GameHeader.svelte, introduced by the three-way merge against upstream changes, was removed so the build stays clean.
|
@Janlhin is attempting to deploy a commit to the sivadaboi's projects Team on Vercel. A member of the Team first needs to authorize it. |
Janlhin
marked this pull request as ready for review
November 9, 2026 10:08
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Extract the user-facing strings of the game detail view (13 Svelte components) into the catalogue, one key per sentence, grouped per component (
game.*).Why
Refs #18 (per-view i18n plan).
This is the next per-view PR after #145, continuing the screen-by-screen plan agreed there.
Stacking: this branch sits on the PR4b branch (
Janlhin:fix/145-app-strings), so its diff currently also shows PR4b's three lines. Once #152 is merged, GitHub moves this PR's merge base onto that commit and the diff shrinks to this PR alone — no rebase needed. Please merge #152 first; I'm holding this one as a draft until it lands.Verification
npm test→ 336/336 passed (41 files), incl. the i18n.test.js catalog alignment gatenpm run build(vite build) → clean, 431 modules transformed$t()reference in the touched views resolves to an existing, non-emptyen.jsonkeyNot verified
npm testin its default parallel mode intermittently raises oneEPERMunhandled error on this machine (Windows temp-dir contention in Vitest's SSR cache); the run above was serial (--no-file-parallelism).Impact and risk
lib/is untouchedTranslation and review: @Janlhin (simplified & traditional)