Repository navigation
i18n: finish the two app strings left over from #145 - #152
Merged
Merged
Conversation
The boot label was still hardcoded even though app.startingOpenSave was already in the catalogs, and app.detailsSaved was still English in zh-Hans and zh-Hant. Both were pointed out in the Liquid-co#145 merge review. Only the reference and the two values change; key sets stay aligned with en.json.
|
@Janlhin is attempting to deploy a commit to the sivadaboi's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Use the existing
app.startingOpenSavekey for the boot label, and translateapp.detailsSavedin both Chinese scripts.Why
Refs #18 (per-view i18n plan).
Follows up on #145: in the merge review, @Omar-VF pointed out that
App.svelte:293still hardcoded "Starting OpenSave…" even thoughapp.startingOpenSavewas already in the catalogues, and thatapp.detailsSavedwas still English in zh-Hans and zh-Hant. Both are small leftovers from that PR, so no separate design issue is needed.Verification
npm test→ 336/336 passed (41 files), incl. the i18n.test.js catalog alignment gatenpm run build(vite build) → clean, 431 modules transformedgit diff origin/dev-public --stat→ 3 files changed, 3 insertions(+), 3 deletions(-)Not verified
npm testin its default parallel mode intermittently raises oneEPERMunhandled error on this machine (Windows temp-dir contention in Vitest's SSR cache); the run above was serial (--no-file-parallelism).Impact and risk
Translation and review: @Janlhin (simplified & traditional)