Skip to content

i18n: finish the two app strings left over from #145 - #152

Merged
Omar-VF merged 1 commit into
Liquid-co:dev-publicfrom
Janlhin:fix/145-app-strings
Nov 9, 2026
Merged

Omar-VF merged 1 commit into
Liquid-co:dev-publicfrom
Janlhin:fix/145-app-strings

Conversation

@Janlhin

@Janlhin Janlhin commented Nov 7, 2026 •

Copy link
Copy Markdown

What

Use the existing app.startingOpenSave key for the boot label, and translate app.detailsSaved in both Chinese scripts.

Why

Refs #18 (per-view i18n plan).
Follows up on #145: in the merge review, @Omar-VF pointed out that App.svelte:293 still hardcoded "Starting OpenSave…" even though app.startingOpenSave was already in the catalogues, and that app.detailsSaved was still English in zh-Hans and zh-Hant. Both are small leftovers from that PR, so no separate design issue is needed.

Verification

  • npm test → 336/336 passed (41 files), incl. the i18n.test.js catalog alignment gate
  • npm run build (vite build) → clean, 431 modules transformed
  • Catalog alignment: 0 missing / 0 extra / 0 empty across en, zh-Hans, zh-Hant
  • git diff origin/dev-public --stat → 3 files changed, 3 insertions(+), 3 deletions(-)

Not verified

  • Manual render check of the boot screen in the built app, both scripts: not performed in this environment.
  • npm test in its default parallel mode intermittently raises one EPERM unhandled error on this machine (Windows temp-dir contention in Vitest's SSR cache); the run above was serial (--no-file-parallelism).

Impact and risk

  • Public API: none
  • Behavior change: the boot label and the boot-error hint now come from the catalogue instead of being hardcoded
  • Breaking change: none

Translation and review: @Janlhin (simplified & traditional)

The boot label was still hardcoded even though app.startingOpenSave was already in the catalogs, and app.detailsSaved was still English in zh-Hans and zh-Hant. Both were pointed out in the Liquid-co#145 merge review. Only the reference and the two values change; key sets stay aligned with en.json.
@vercel

vercel Bot commented Nov 7, 2026

Copy link
Copy Markdown

@Janlhin is attempting to deploy a commit to the sivadaboi's projects Team on Vercel.

A member of the Team first needs to authorize it.

@Omar-VF
Omar-VF merged commit 4764979 into Liquid-co:dev-public Nov 9, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants