Skip to content

chore(deps): pin azure provider at the run-rate fix merge (cloud-commitments-go#218) - #652

Closed
cristim wants to merge 1 commit into
mainfrom
chore/deps-azure-runrate-218
Closed

cristim wants to merge 1 commit into
mainfrom
chore/deps-azure-runrate-218

Conversation

@cristim

@cristim cristim commented Oct 7, 2026

Copy link
Copy Markdown
Member

Why

Rollout relay from the PR-fleet orchestrator: cloud-commitments-go#218 merged to main as e24345c (fix(azure): stop dividing the monthly run-rate by the term months). The platform pinned the Azure provider at ce9513612901 (2026-09-28), before that fix.

The upstream bug: CommitmentCost/RecurringMonthlyCost from Azure Extract are monthly run-rates over the lookback period, but ExpandPaymentVariants treated CommitmentCost as a term total and divided it by 12 or 36 — the monthly payment variant understated the recurring Azure reservation charge 12x/36x. It also overwrote provider-reported NetSavings with a derived 100% when TotalCostWithReservedInstances was absent.

What

Per-module pin update, no code changes:

  • providers/azure: v0.0.0-20260928214714-ce9513612901 → v0.0.0-20261007130138-e24345ce68f8 (exactly the fix(api): "Run now" flips a purchase to running but nothing executes it #218 merge commit)
  • pkg: b3b4cb5e3d80 → v0.0.0-20261006104817-90e61e668b99 — the minimum version the new azure module's own go.mod requires
  • providers/aws stays at the newer v0.0.0-20261003204812-9962786e0695 and providers/gcp is untouched — a single SHA across all four modules would downgrade aws

Evidence

  • go build ./... clean; go mod tidy -diff clean
  • go test -race -short ./internal/purchase/... ./internal/scheduler/... ./internal/api/... — all pass
  • Verified the pkg bump is not gratuitous: providers/azure@e24345ce68f8/go.mod requires pkg v0.0.0-20261006104817-90e61e668b99
  • Verified the azure pseudo-version timestamp/SHA matches the upstream merge: 20261007130138-e24345ce68f8

Coordination

Overlaps in go.mod with #475 (orchestrator-owned Azure reservation rollout, pins azure at the older 56555e1be095). Whichever merges second rebases; commented on #475 so its owner can reconcile. This PR is the focused rollout of the #218 run-rate fix only.

Pin cloud-commitments-go/providers/azure at e24345ce68f8, the merge of
cloud-commitments-go#218, which stops ExpandPaymentVariants dividing
the monthly run-rate by the term months (the monthly variant
understated the recurring Azure reservation charge 12x or 36x).

Per-module pins: providers/aws stays at 9962786e0695 and
providers/gcp is untouched; the pkg bump to 90e61e668b99 is the minimum
version the new azure module requires.
@coderabbitai

coderabbitai Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

  • Run on-demand review

This review includes 1 billable file and costs up to $0.25.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 24 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 68 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: LeanerCloud/cloud-commitments-platform/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: f054a300-35cf-4d9f-8054-9761a67358aa
📥 Commits

Reviewing files that changed from the base of the PR and between 3131779 and 57c1019.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@cristim

cristim commented Oct 7, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@cristim

cristim commented Oct 7, 2026

Copy link
Copy Markdown
Member Author

Independent verification of the pin (rollout relay for cloud-commitments-go#218):

  • providers/azure pinned at v0.0.0-20261007130138-e24345ce68f8 — commit e24345ce68f8 is the fix(api): "Run now" flips a purchase to running but nothing executes it #218 merge (fix(azure): stop dividing the monthly run-rate by the term months) and is on cloud-commitments-go main. Pin is exactly at the required merge.
  • providers/aws untouched at the newer Oct 3 pin (9962786e0695) — no downgrade; the relay's per-module-pin constraint is respected. providers/gcp untouched; pkg moves to 90e61e668b99 as required by the azure module's dependency chain.

Note: PR #651 and PR #652 have byte-identical diffs (git diff between the branches is empty). One of them can be closed as a duplicate — suggest keeping #651 (earlier).

@cristim

cristim commented Oct 7, 2026

Copy link
Copy Markdown
Member Author

Deconfliction relay from the PR-fleet orchestrator: the azure pin bump is already DONE in fleet PR #475 (commit 11fdc1f, closes #650) — its diff pins providers/azure at v0.0.0-20261007130138-e24345ce68f8, the same pin this PR carries. This PR is superseded; please close it unmerged, and do not push further azure-pin changes to go.mod/go.sum while #475 is in flight. (My earlier keep-#651 suggestion is moot — both are superseded by #475.)

@cristim

cristim commented Oct 7, 2026

Copy link
Copy Markdown
Member Author

Closing as superseded: the azure pin bump to cloud-commitments-go e24345c (run-rate fix, cloud-commitments-go#218) has landed in fleet PR #475 as commit 11fdc1f, which closes #650. Per the PR-fleet orchestrator's deconfliction, no further azure-pin changes to go.mod/go.sum while #475 is in flight.

@cristim cristim closed this Oct 7, 2026
@cristim
cristim deleted the chore/deps-azure-runrate-218 branch October 7, 2026 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant