Repository navigation
Conversation
Pin cloud-commitments-go/providers/azure at e24345ce68f8, the merge of cloud-commitments-go#218, which stops ExpandPaymentVariants dividing the monthly run-rate by the term months (the monthly variant understated the recurring Azure reservation charge 12x or 36x). Per-module pins: providers/aws stays at 9962786e0695 and providers/gcp is untouched; the pkg bump to 90e61e668b99 is the minimum version the new azure module requires.
|
Warning Review limit reached
This review includes 1 billable file and costs up to $0.25.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 24 minutes for your next included review. View limit detailsLimit details: You’ve used the included review currently available. Your 68 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Review configuration: ⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Comment |
|
@coderabbitai review |
|
|
Independent verification of the pin (rollout relay for cloud-commitments-go#218):
Note: PR #651 and PR #652 have byte-identical diffs ( |
|
Deconfliction relay from the PR-fleet orchestrator: the azure pin bump is already DONE in fleet PR #475 (commit 11fdc1f, closes #650) — its diff pins |
Why
Rollout relay from the PR-fleet orchestrator: cloud-commitments-go#218 merged to main as
e24345c(fix(azure): stop dividing the monthly run-rate by the term months). The platform pinned the Azure provider atce9513612901(2026-09-28), before that fix.The upstream bug:
CommitmentCost/RecurringMonthlyCostfrom Azure Extract are monthly run-rates over the lookback period, butExpandPaymentVariantstreatedCommitmentCostas a term total and divided it by 12 or 36 — the monthly payment variant understated the recurring Azure reservation charge 12x/36x. It also overwrote provider-reportedNetSavingswith a derived 100% whenTotalCostWithReservedInstanceswas absent.What
Per-module pin update, no code changes:
providers/azure:v0.0.0-20260928214714-ce9513612901→v0.0.0-20261007130138-e24345ce68f8(exactly the fix(api): "Run now" flips a purchase to running but nothing executes it #218 merge commit)pkg:b3b4cb5e3d80→v0.0.0-20261006104817-90e61e668b99— the minimum version the new azure module's owngo.modrequiresproviders/awsstays at the newerv0.0.0-20261003204812-9962786e0695andproviders/gcpis untouched — a single SHA across all four modules would downgrade awsEvidence
go build ./...clean;go mod tidy -diffcleango test -race -short ./internal/purchase/... ./internal/scheduler/... ./internal/api/...— all passproviders/azure@e24345ce68f8/go.modrequirespkg v0.0.0-20261006104817-90e61e668b9920261007130138-e24345ce68f8Coordination
Overlaps in
go.modwith #475 (orchestrator-owned Azure reservation rollout, pins azure at the older56555e1be095). Whichever merges second rebases; commented on #475 so its owner can reconcile. This PR is the focused rollout of the #218 run-rate fix only.