Skip to content

fix(deps): pin azure provider at cloud-commitments-go e24345c run-rate fix - #651

Closed
cristim wants to merge 1 commit into
mainfrom
deps/azure-runrate-pr218
Closed

cristim wants to merge 1 commit into
mainfrom
deps/azure-runrate-pr218

Conversation

@cristim

@cristim cristim commented Oct 7, 2026

Copy link
Copy Markdown
Member

Summary

Closes #650.

Pins github.com/LeanerCloud/cloud-commitments-go/providers/azure at the cloud-commitments-go PR #218 merge commit (e24345ce68f8), which fixes the Azure monthly run-rate being incorrectly divided by the term months.

Why

The platform's Azure run-rate figures shown in recommendations and purchase flows were understated by a factor of the term length while pinned at the Sept 28 azure module. The upstream fix is on the money path, so the pin needs to move forward.

Per-module pinning

Only the affected module moves:

Verification

Pin providers/azure at cloud-commitments-go PR #218 merge (e24345c),
which stops dividing the monthly run-rate by the term months.

Per-module pin: providers/aws (20261003) and providers/gcp are left
untouched; pkg moves forward transitively via azure's go.mod.
@coderabbitai

coderabbitai Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

  • Run on-demand review

This review includes 1 billable file and costs up to $0.25.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 26 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 68 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: LeanerCloud/cloud-commitments-platform/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 4243fe4d-80ba-4331-b336-852700825574
📥 Commits

Reviewing files that changed from the base of the PR and between 3131779 and f628174.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@cristim cristim added urgency/this-sprint Within the current sprint triaged Item has been triaged priority/p1 Next up; this sprint severity/high Significant harm impact/many Affects most users effort/xs Trivial / one-liner type/bug Defect labels Oct 7, 2026
@cristim

cristim commented Oct 7, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@cristim

cristim commented Oct 7, 2026

Copy link
Copy Markdown
Member Author

Independent verification of the pin (rollout relay for cloud-commitments-go#218):

  • providers/azure pinned at v0.0.0-20261007130138-e24345ce68f8 — commit e24345ce68f8 is the fix(api): "Run now" flips a purchase to running but nothing executes it #218 merge (fix(azure): stop dividing the monthly run-rate by the term months) and is on cloud-commitments-go main. Pin is exactly at the required merge.
  • providers/aws untouched at the newer Oct 3 pin (9962786e0695) — no downgrade; the relay's per-module-pin constraint is respected. providers/gcp untouched; pkg moves to 90e61e668b99 as required by the azure module's dependency chain.

Note: PR #651 and PR #652 have byte-identical diffs (git diff between the branches is empty). One of them can be closed as a duplicate — suggest keeping #651 (earlier).

@cristim

cristim commented Oct 7, 2026

Copy link
Copy Markdown
Member Author

Deconfliction relay from the PR-fleet orchestrator: the azure pin bump is already DONE in fleet PR #475 (commit 11fdc1f, closes #650) — its diff pins providers/azure at v0.0.0-20261007130138-e24345ce68f8, the same pin this PR carries. This PR is superseded; please close it unmerged, and do not push further azure-pin changes to go.mod/go.sum while #475 is in flight. (My earlier keep-#651 suggestion is moot — both are superseded by #475.)

@cristim

cristim commented Oct 7, 2026

Copy link
Copy Markdown
Member Author

Closing as superseded: the azure pin bump to cloud-commitments-go e24345c (run-rate fix, cloud-commitments-go#218) has landed in fleet PR #475 as commit 11fdc1f, which closes #650. Per the PR-fleet orchestrator's deconfliction, no further azure-pin changes to go.mod/go.sum while #475 is in flight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/xs Trivial / one-liner impact/many Affects most users priority/p1 Next up; this sprint severity/high Significant harm triaged Item has been triaged type/bug Defect urgency/this-sprint Within the current sprint

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(deps): pin providers/azure at or after cloud-commitments-go e24345c (Azure monthly run-rate fix)

1 participant