Skip to content

chore(deps): bump providers/azure past 58c25f0 after #475 merges #654

Closed

Description

@cristim

Summary

cloud-commitments-go PR #207 (fix(azure): report only savings plans billed to the subscription) merged to main as 58c25f0 (pseudo-version v0.0.0-20261007133317-58c25f04c49b). Fleet PR #475 pins providers/azure at e24345c (the #218 run-rate fix), which predates 58c25f0 — so after #475 merges, the azure pin still lacks the #207 fail-closed inventory change. Azure-pin changes are frozen while #475 is in flight (orchestrator deconfliction, 2026-10-07), so this issue tracks the follow-up bump.

Consumer impact audit (done 2026-10-07, no code change needed)

  • GetExistingCommitments for Azure savings plans can now return an error where it previously returned a silently partial list (billing-account/management-group scopes and malformed rows hard-error).
  • This platform has zero non-test callers of GetExistingCommitments (repo-wide grep; only test mocks implement it). The only error-ambiguous consumer, pkg/recfilter.DuplicateChecker.AdjustRecommendationsForExisting (returns all recs as passed alongside the error), has no callers in this repo or inside the pinned modules.
  • Duplicate-purchase protection for Azure savings plans rests on the module's PUT order-alias idempotency (services/savingsplans/client.go: "PUT with a previously-used name returns the existing order alias"), which is unaffected by the fix(ci): database-migration.yml discards the real terraform error when reading the DB endpoint #207 change.

Expected outcome

After #475 merges and the pin freeze lifts, bump github.com/LeanerCloud/cloud-commitments-go/providers/azure to v0.0.0-20261007133317-58c25f04c49b or later (per-module pin; do not move providers/aws or providers/gcp to the same SHA). Build and run the azure-tagged tests; no caller changes are expected to be required per the audit above.

References

Severity

Low — no caller impact in this repo; this is a tracking chore for the pin bump.

Activity

  1. IAmJSD commented on Oct 23, 2026

    @IAmJSD
    Collaborator

    Claiming: working on this

  2. self-assigned this
    on Oct 23, 2026
  3. IAmJSD commented on Oct 23, 2026

    @IAmJSD
    Collaborator

    Released: already fixed on main. #805 (6dc774b, merged 2026-10-12) bumped providers/azure to 9dae64b, which contains 58c25f0; main now pins 3def3f8 (also contains it, via #1053). #805 said "Refs #791", so this issue wasn't closed automatically. Checked with git merge-base --is-ancestor 58c25f0 <pin> in cloud-commitments-go. Closing.

  4. removed their assignment
    on Oct 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions