Skip to content

docs(paper): mechanical fixes from JOSS paper review (#447) - #450

Merged
phanindra-max merged 1 commit into
devfrom
fix/447-paper-mechanical
Oct 4, 2026
Merged

phanindra-max merged 1 commit into
devfrom
fix/447-paper-mechanical

Conversation

@phanindra-max

@phanindra-max phanindra-max commented Sep 17, 2026 •

Copy link
Copy Markdown
Member

Mechanical fixes for part of @jansim's paper review in #447. This does not fully address that issue: the Software design rewrite and the AI usage disclosure are left.

Changes

Paper (paper.md, paper.bib)

  • Alignment term: defined at first use in the Summary ("a step we call alignment").
  • Unsupported claims removed (Statement of need and State of the field)
  • LLM-based related work added, with a paragraph citing SkillGPT (Li et al., 2023), ESCOX (Kavargyris et al., 2025, Software Impacts), Skill-LLM (Herandi et al., 2024) and Nguyen et al. (2024, NLP4HR).
  • Cookbook: the repository is now linked in the Research impact statement.
  • Bibliography: the unused SCQF2019 entry is removed; the SCQF claim was dropped in fix: deterministic decoding by default; paper updates for JOSS review #424 #444.

Docs (docs/taxonomies.md)

  • Open Skills Network link: openskillsnetwork.org fails the TLS handshake. The link now points to WGU's Open Skills Management Tool (osmt.wgu.edu), where the OSN entries resolve.

Checks

  • Every citation key in paper.md resolves in paper.bib, and every bib entry is cited.
  • Paper body: 1,670 words.
  • mkdocs build --strict: passes.

Still open from #447

  • Comparison with LLM-based tools: state concretely how LAiSER differs from them, based on reading the papers.
  • Software design: rewrite it in the authors' own words, to describe plainly what happens to a document.
  • AI usage disclosure: correct it so it describes how the current paper text was produced.

🤖 Generated with Claude Code

Define alignment, remove claims contradicted by prior LLM-based tools,
drop the unevaluated "accurate", cite SkillGPT, ESCOX, Skill-LLM and
Nguyen et al. (2024), link the cookbook repository, remove the unused
SCQF bib entry, and replace the broken Open Skills Network link.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings September 17, 2026 06:55

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

Copy link
Copy Markdown

Code Hygiene

The following items are defined but not yet in active use. Routine cleanup — no impact on functionality.

  • laiser/llm_methods.py:87 — unused variable 'args' (100% confidence)
  • laiser/llm_models/llama_cpp_handler.py:45 — unused variable 'chat_format' (100% confidence)
  • laiser/llm_models/llama_cpp_handler.py:86 — unused variable 'exc' (100% confidence)
  • laiser/llm_models/llama_cpp_handler.py:86 — unused variable 'exc_type' (100% confidence)
  • laiser/llm_models/llama_cpp_handler.py:86 — unused variable 'tb' (100% confidence)
  • laiser/llm_models/llm_router.py:71 — unused variable 'args' (100% confidence)
  • laiser/llm_models/llm_router.py:86 — unused variable 'args' (100% confidence)
  • laiser/llm_models/llm_router.py:89 — unused variable 'args' (100% confidence)
  • laiser/services.py:132 — unused variable 'raw_description' (100% confidence)

@github-actions

Copy link
Copy Markdown

Complexity Analysis

Average: C — Moderate (13.75)

Hotspots tracked below. These are functional, well-exercised components — listed for visibility as the codebase scales.

Grade Name Type Score
F FAISSIndexManager.initialize_index Method 51
E SkillExtractionService.extract_and_align_core Method 36
E FAISSIndexManager.search_similar_skills Method 32
D ResponseParser._parse_skills_from_response Method 24
D FAISSIndexManager Class 22
C ResponseParser.parse_knowledge_task_response Method 20
C _BaseTaxonomyFAISSIndexManager.search_similar Method 18
C ResponseParser Class 17
C ResponseParser.parse_ksa_extraction_response Method 16
C ResponseParser.parse_skill_extraction_response Method 15
C openai_generate Function 14
C parse_output_vllm Function 13
C AlignmentService.align Method 11
C anthropic_generate Function 11
C LLMRouter._initialize_components Method 11
B SkillExtractionService._deduplicate Method 10
B load_model_from_vllm Function 10
B GeminiAPI.generate_with_config Method 10
B _BaseTaxonomyFAISSIndexManager.initialize_index Method 9
B ResponseParser.parse_ksa_details_response Method 8
B SkillExtractionService Class 8
B _BaseTaxonomyFAISSIndexManager Class 8
B llm_generate Function 8
B SkillExtractorRefactored._expand_allowed_sources Method 7
B get_completion_vllm Function 7
B llama_cpp_chat Function 7
B LLMRouter.generate Method 7
B AlignmentService Class 6
B SkillExtractionService._normalize_mixed_concept_rows Method 6
B fetch_model_output Function 6
B LlamaCppBackend.__init__ Method 6
B GeminiAPI Class 6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants