Repository navigation
docs(paper): rewrite remaining sections from JOSS paper review (#447) - #460
Merged
Merged
Conversation
Updates the requirements on [python-dotenv](https://github.com/theskumar/python-dotenv) to permit the latest version. - [Release notes](https://github.com/theskumar/python-dotenv/releases) - [Changelog](https://github.com/theskumar/python-dotenv/blob/main/CHANGELOG.md) - [Commits](theskumar/python-dotenv@v0.19.0...v1.2.3) --- updated-dependencies: - dependency-name: python-dotenv dependency-version: 1.2.3 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
…,>=0.19.0 to >=0.19.0,<2.0.0"
…p/python-dotenv-gte-0.19.0-and-lt-2.0.0 Revert "chore(deps-dev): update python-dotenv requirement from <1.0.0,>=0.19.0 to >=0.19.0,<2.0.0"
fix(ci): repair release and PR workflows, run the real test battery
ci: publish release notes per tag, fix changelog template
docs: bring #438 documentation and CPU fixes to main
fix: deterministic decoding by default; paper updates for JOSS review #424
Release to main: load local models on transformers 5 (#448)
Release to main: JOSS paper review fixes (#450)
Release to main: Open Skills Network docs link (#457)
Paper
- Statement of need: rewritten from the authors' answers on the problem,
its cost and the response; existing-work claims are now cited.
- State of the field: esco-skill-extractor and ESCOX are the same tool and
are now described once; the unsupported "lacks preprocessing" clause is
removed; a new paragraph states what LAiSER adds, why it was built rather
than extending Nesta's library, and that it has no published evaluation.
- Software design: rewritten as four paragraphs (pipeline, LLM vs NER,
exact search, reproducibility and its limits), checked against the code.
- AI usage disclosure: names each tool and model version, what it was used
for, and how this revision was produced, per the JOSS AI policy.
- Acknowledgments: states that the funders had no role.
- paper.bib: remove Autor2013, no longer cited. Body is 1,748 words.
Code
- Syllabi used a placeholder prompt (" Work in progress") that contained no
document text. Every input type now uses the shared extraction prompt and
reads every column in text_columns. Tests added; docs/usage.md updated.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
|
Code Hygiene The following items are defined but not yet in active use. Routine cleanup — no impact on functionality.
|
|
Complexity Analysis Average: C — Moderate (13.75) Hotspots tracked below. These are functional, well-exercised components — listed for visibility as the codebase scales.
|
phanindra-max
added a commit
that referenced
this pull request
Nov 7, 2026
Release to main: JOSS paper rewrite and syllabus prompt fix (#460)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the remaining items from @jansim's paper review in #447. Together with #450, this resolves the issue.
Paper (
paper.md,paper.bib)State of the field.
Software design. Rewritten from the authors' answers into four paragraphs:
API detail is kept out, per the JOSS guidelines.
Statement of need. Rewritten from the authors' answers on the problem, its cost and the response. Claims about existing work are now cited.
AI usage disclosure. Rewritten to the JOSS AI policy. It names each tool and model version, says what each was used for, and describes how this revision was produced.
Acknowledgments. Now states that the funders had no role.
Bibliography.
Autor2013is removed, since it is no longer cited.Code
Syllabi were sent to a placeholder prompt (
" Work in progress") that contained no document text. Every input type now uses the shared extraction prompt and reads every column intext_columns. Tests are intests/test_syllabus_prompt.py, anddocs/usage.mdis updated.Checks
Not in this PR
DEFAULT_VLLM_MODEL_IDsilently when the requested model fails, and that ID may not exist on Hugging Face.tests/test_index_process.pydeletes and rebuilds the committed index files on every run.🤖 Generated with Claude Code