Repository navigation
Release to main: JOSS paper rewrite and syllabus prompt fix (#460) - #461
Merged
Merged
Conversation
Paper
- Statement of need: rewritten from the authors' answers on the problem,
its cost and the response; existing-work claims are now cited.
- State of the field: esco-skill-extractor and ESCOX are the same tool and
are now described once; the unsupported "lacks preprocessing" clause is
removed; a new paragraph states what LAiSER adds, why it was built rather
than extending Nesta's library, and that it has no published evaluation.
- Software design: rewritten as four paragraphs (pipeline, LLM vs NER,
exact search, reproducibility and its limits), checked against the code.
- AI usage disclosure: names each tool and model version, what it was used
for, and how this revision was produced, per the JOSS AI policy.
- Acknowledgments: states that the funders had no role.
- paper.bib: remove Autor2013, no longer cited. Body is 1,748 words.
Code
- Syllabi used a placeholder prompt (" Work in progress") that contained no
document text. Every input type now uses the shared extraction prompt and
reads every column in text_columns. Tests added; docs/usage.md updated.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
docs(paper): rewrite remaining sections from JOSS paper review (#447)
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
|
Code Hygiene The following items are defined but not yet in active use. Routine cleanup — no impact on functionality.
|
|
Complexity Analysis Average: C — Moderate (13.75) Hotspots tracked below. These are functional, well-exercised components — listed for visibility as the codebase scales.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings #460 from
devtomain. It was merged intodevin #460; this PR only promotes it. The JOSS paper is built frommain, so the reviewer sees the revised paper only once this is merged.What reaches
maineed165ddocs(paper): rewrite remaining sections from JOSS paper review ([JOSS] Paper Feedback #447).paper.md:paper.bib: the unusedAutor2013entry is removed.laiser/services.py,laiser/config.py: syllabi now use the shared extraction prompt. Before this, they were sent to a placeholder prompt that contained no document text.docs/usage.md: updated to match.tests/test_syllabus_prompt.py: new tests for the fix.Checks
🤖 Generated with Claude Code