Skip to content

Release to main: JOSS paper review fixes (#450) - #456

Merged
phanindra-max merged 2 commits into
mainfrom
dev
Oct 4, 2026
Merged

phanindra-max merged 2 commits into
mainfrom
dev

Conversation

@phanindra-max

Copy link
Copy Markdown
Member

Brings #450 from dev to main. It was merged into dev in #450; this PR only promotes it.

The JOSS paper proof and the documentation site are both built from main. Until this merges, reviewers still see the old paper text and the broken Open Skills Network link.

What reaches main

  • d1a6595 docs(paper): address mechanical points from the JOSS paper review ([JOSS] Paper Feedback #447).
    • Defines alignment at first use.
    • Removes three claims that prior LLM-based tools contradict, and drops the unevaluated "accurate".
    • Cites SkillGPT, ESCOX, Skill-LLM and Nguyen et al. (2024).
    • Links the cookbook repository and removes the unused SCQF bib entry.
    • Replaces the broken Open Skills Network link in docs/taxonomies.md.

Three files change: paper.md, paper.bib and docs/taxonomies.md. There are no code changes. The branches merge cleanly.

Still open in #447

  • Software design rewrite
  • AI usage disclosure
  • How LAiSER compares with the LLM-based tools

🤖 Generated with Claude Code

phanindra-max and others added 2 commits September 17, 2026 02:54
Define alignment, remove claims contradicted by prior LLM-based tools,
drop the unevaluated "accurate", cite SkillGPT, ESCOX, Skill-LLM and
Nguyen et al. (2024), link the cookbook repository, remove the unused
SCQF bib entry, and replace the broken Open Skills Network link.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
docs(paper): mechanical fixes from JOSS paper review (#447)
Copilot AI balanced review requested due to automatic review settings October 4, 2026 07:26

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

github-actions Bot commented Oct 4, 2026

Copy link
Copy Markdown

Complexity Analysis

Average: C — Moderate (13.75)

Hotspots tracked below. These are functional, well-exercised components — listed for visibility as the codebase scales.

Grade Name Type Score
F FAISSIndexManager.initialize_index Method 51
E SkillExtractionService.extract_and_align_core Method 36
E FAISSIndexManager.search_similar_skills Method 32
D ResponseParser._parse_skills_from_response Method 24
D FAISSIndexManager Class 22
C ResponseParser.parse_knowledge_task_response Method 20
C _BaseTaxonomyFAISSIndexManager.search_similar Method 18
C ResponseParser Class 17
C ResponseParser.parse_ksa_extraction_response Method 16
C ResponseParser.parse_skill_extraction_response Method 15
C openai_generate Function 14
C parse_output_vllm Function 13
C AlignmentService.align Method 11
C anthropic_generate Function 11
C LLMRouter._initialize_components Method 11
B SkillExtractionService._deduplicate Method 10
B load_model_from_vllm Function 10
B GeminiAPI.generate_with_config Method 10
B _BaseTaxonomyFAISSIndexManager.initialize_index Method 9
B ResponseParser.parse_ksa_details_response Method 8
B SkillExtractionService Class 8
B _BaseTaxonomyFAISSIndexManager Class 8
B llm_generate Function 8
B SkillExtractorRefactored._expand_allowed_sources Method 7
B get_completion_vllm Function 7
B LLMRouter.generate Method 7
B llama_cpp_chat Function 7
B AlignmentService Class 6
B SkillExtractionService._normalize_mixed_concept_rows Method 6
B fetch_model_output Function 6
B LlamaCppBackend.__init__ Method 6
B GeminiAPI Class 6

@github-actions

github-actions Bot commented Oct 4, 2026

Copy link
Copy Markdown

Code Hygiene

The following items are defined but not yet in active use. Routine cleanup — no impact on functionality.

  • laiser/llm_methods.py:87 — unused variable 'args' (100% confidence)
  • laiser/llm_models/llama_cpp_handler.py:45 — unused variable 'chat_format' (100% confidence)
  • laiser/llm_models/llama_cpp_handler.py:86 — unused variable 'exc' (100% confidence)
  • laiser/llm_models/llama_cpp_handler.py:86 — unused variable 'exc_type' (100% confidence)
  • laiser/llm_models/llama_cpp_handler.py:86 — unused variable 'tb' (100% confidence)
  • laiser/llm_models/llm_router.py:71 — unused variable 'args' (100% confidence)
  • laiser/llm_models/llm_router.py:86 — unused variable 'args' (100% confidence)
  • laiser/llm_models/llm_router.py:89 — unused variable 'args' (100% confidence)
  • laiser/services.py:132 — unused variable 'raw_description' (100% confidence)

@phanindra-max
phanindra-max merged commit 819f62d into main Oct 4, 2026
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants