feat: add distinct bool data type to InfiniRT - #47
Merged
Merged
Conversation
voltjia
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DataType::kBoolwith one-byte size, string conversion, and C++boolmapping insrc/data_type.h.tests/test_core.cc.Motivation
Boolean tensors previously lacked a distinct runtime dtype, blocking correct bool input/output mapping in consumers such as InfiniOps.
Type of Change
feat- new feature / new backend capability / new public APIfix- bug fixperf- performance improvement without behavior changerefactor- code restructuring without behavior changetest- adding or fixing tests onlydocs- documentation onlybuild/ci- build system or CI configurationchore- tooling, formatting, or other non-code changesPlatforms Affected
WITH_CPU)WITH_NVIDIA)WITH_ILUVATAR)WITH_HYGON)WITH_METAX)WITH_MOORE)WITH_CAMBRICON)WITH_ASCEND)Smoke Build and Test Result
Earlier build from the same source tree was completed in an NVIDIA GPU container. On the final commit (format-only amendment to
tests/test_core.cc), the existing build was retested inbaoming_infiniops:Changed C++ files pass
clang-format 21 --dry-run --Werror;git diff --checkpasses.Test Results on Supported Platforms
Benchmark / Performance Impact
N/A - dtype mapping change; no benchmark run.
Notes for Reviewers
feat/bool-dtype-latestpredates the current branch naming convention (<type>/xxx-yyyy-zzzz); not renamed as part of this PR.