feat: support distinct bool tensor dtype in InfiniOps - #996
Merged
Merged
Conversation
baominghelly
force-pushed
the
feat/bool-dtype-latest
branch
from
September 23, 2026 08:57
0ff6514 to
5105bb8
Compare
baominghelly
marked this pull request as ready for review
September 24, 2026 07:25
voltjia
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DataType::kBoolthrough the Python and PyTorch C++ bindings, eliminating the bool-as-uint8 workaround.TopkSoftmaxandTopkSigmoid; remove the attention-mask dtype override now that native bool mapping exists.Motivation
Bool-valued inputs and outputs were previously rejected or represented as uint8 by InfiniOps. This blocked comparison, logical, and reduction tests and made mask contracts inconsistent with PyTorch. Requires the companion InfiniRT bool dtype change (InfiniTensor/InfiniRT#47).
Type of Change
feat— new feature / new operator / new platformfix— bug fixperf— performance improvement (no behavioral change)refactor— code restructuring without behavior changetest— adding or fixing tests onlydocs— documentation onlybuild/ci— build system or CI configurationchore— tooling, formatting, or other non-code changesPlatforms Affected
WITH_CPU)WITH_NVIDIA)WITH_ILUVATAR)WITH_METAX)WITH_CAMBRICON)WITH_MOORE)WITH_ASCEND)WITH_TORCH)Smoke Test Result
Built an InfiniOps wheel in the earlier container validation for this same source tree. Retested the final commit against its existing build in
baoming_infiniops:The 5,961 skips are existing conditional/parameterized skips, not validated passes. Changed C++ files pass
clang-format 21 --dry-run --Werror;git diff --checkpasses.Test Results on Supported Platforms
Benchmark / Performance Impact
N/A - dtype and mask contract change; no benchmark run.
Notes for Reviewers
DataType::kBool.TopkSoftmax/TopkSigmoidnow require a true boolis_paddingtensor; previous uint8 callers should be checked. Attention masks no longer need bool-via-byte dtype override.feat/bool-dtype-latestpredates the current branch naming convention (<type>/xxx-yyyy-zzzz); not renamed as part of this PR.