Skip to content

feat: add distinct bool data type to InfiniRT #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
voltjia merged 1 commit into from
Sep 23, 2026
Merged

feat: add distinct bool data type to InfiniRT #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions src/data_type.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,11 @@ enum class DataType : std::int8_t {
kFloat16,
kBFloat16,
kFloat32,
kFloat64
kFloat64,
kBool
};

constexpr ConstexprMap<DataType, std::size_t, 12> kDataTypeToSize{{{
constexpr ConstexprMap<DataType, std::size_t, 13> kDataTypeToSize{{{
{DataType::kInt8, 1},
{DataType::kInt16, 2},
{DataType::kInt32, 4},
Expand All @@ -39,9 +40,10 @@ constexpr ConstexprMap<DataType, std::size_t, 12> kDataTypeToSize{{{
{DataType::kBFloat16, 2},
{DataType::kFloat32, 4},
{DataType::kFloat64, 8},
{DataType::kBool, 1},
}}};

constexpr ConstexprMap<DataType, std::string_view, 12> kDataTypeToDesc{{{
constexpr ConstexprMap<DataType, std::string_view, 13> kDataTypeToDesc{{{
{DataType::kInt8, "int8"},
{DataType::kInt16, "int16"},
{DataType::kInt32, "int32"},
Expand All @@ -54,9 +56,10 @@ constexpr ConstexprMap<DataType, std::string_view, 12> kDataTypeToDesc{{{
{DataType::kBFloat16, "bfloat16"},
{DataType::kFloat32, "float32"},
{DataType::kFloat64, "float64"},
{DataType::kBool, "bool"},
}}};

constexpr ConstexprMap<std::string_view, DataType, 12> kStringToDataType{{{
constexpr ConstexprMap<std::string_view, DataType, 13> kStringToDataType{{{
{"int8", DataType::kInt8},
{"int16", DataType::kInt16},
{"int32", DataType::kInt32},
Expand All @@ -69,6 +72,7 @@ constexpr ConstexprMap<std::string_view, DataType, 12> kStringToDataType{{{
{"bfloat16", DataType::kBFloat16},
{"float32", DataType::kFloat32},
{"float64", DataType::kFloat64},
{"bool", DataType::kBool},
}}};

struct Float16 {
Expand Down Expand Up @@ -164,6 +168,7 @@ using TypeMapType = typename TypeMap<dev, dtype>::type;
};

DEFINE_DATA_TYPE_MAPPING(kUInt8, std::uint8_t)
DEFINE_DATA_TYPE_MAPPING(kBool, bool)
DEFINE_DATA_TYPE_MAPPING(kInt8, std::int8_t)
DEFINE_DATA_TYPE_MAPPING(kUInt16, std::uint16_t)
DEFINE_DATA_TYPE_MAPPING(kInt16, std::int16_t)
Expand Down
14 changes: 14 additions & 0 deletions tests/test_core.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,20 @@ void TestDataType(infini::rt::test::TestContext* context) {
"float64", "float64 should have a stable name.");
context->ExpectEqual(infini::rt::kStringToDataType.at("uint16"),
DataType::kUInt16, "uint16 should parse by name.");
context->Expect(DataType::kBool != DataType::kUInt8,
"bool must be distinct from uint8.");
context->ExpectEqual(infini::rt::kDataTypeToSize.at(DataType::kBool),
std::size_t{1}, "bool should use one byte.");
context->ExpectEqual(infini::rt::kDataTypeToDesc.at(DataType::kBool), "bool",
"bool should have a stable name.");
context->ExpectEqual(infini::rt::kStringToDataType.at("bool"),
DataType::kBool, "bool should parse by name.");
context->ExpectEqual(infini::rt::kStringToDataType.at("uint8"),
DataType::kUInt8, "uint8 should remain distinct.");
context->Expect(
std::is_same_v<
infini::rt::TypeMapType<Device::Type::kCpu, DataType::kBool>, bool>,
"CPU bool should map to C++ bool.");
}

void TestTensorViewRanks(infini::rt::test::TestContext* context) {
Expand Down
Loading