[ShridharGoel]

Explanation of Change

Adds a new Approve-only workspace role for Control workspaces. Members with this role can approve expenses but cannot create them.

What changed:

• Added the approveOnly role constant, its permission bundle (same read access as a member), and its display name and description in all languages.
• The role shows in the member role list on Control workspaces. Admins and People Admins can assign it.
• When an admin assigns the role, the backend can refuse it and return a list of reasons (for example the member has a card on the workspace). In that case a modal shows the reasons instead of changing the role. This uses a side-effects request so the response can be read.
• Approve-only members no longer see create options in their workspace chat, and the workspace is hidden from the expense creation, report creation, move expense, and per diem workspace pickers.
• The workspace cannot be set as the default workspace by an approve-only member.

Note: the blocked-reasons modal depends on the Web-Expensify change that passes blockedReasons through (https://github.com/Expensify/Web-Expensify/pull/56619). Without it, the role assignment simply fails with a generic error.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/680623
PROPOSAL:

Tests

1. Open a Control workspace > Members > pick a member > Role.
2. Verify "Approve-only" appears in the list with the description "Approve reports without submitting them.".
3. Select Approve-only for a member who has no card, is not in a restricted domain group, and does not have this workspace as default. Verify the role is saved.
4. Select Approve-only for a member who has a card on the workspace (or has it as their default workspace). Verify a modal appears listing the reasons and the role is not changed.
5. Log in as the approve-only member and open the workspace chat. Verify the + menu shows no expense creation options.
6. As the approve-only member, open Global Create > Create expense. Verify the approve-only workspace does not appear in the workspace picker.
7. As the approve-only member, open the workspaces list, open the three-dots menu on the approve-only workspace. Verify "Set as default" is not shown.
8. Verify a member with a regular Member role still sees all create options and workspace pickers as before.

• Verify that no errors appear in the JS console

Offline tests

1. Go offline and try to assign the Approve-only role to a member who has the workspace as their default workspace.
2. Verify the role updates and shows as pending.
3. Go back online.
4. Verify the blocked-reasons modal appears and the role reverts.

QA Steps

Same as tests.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If the PR adds or modifies the UI:
  • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
  • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
  • I verified all new/changed elements have meaningful accessible names and roles.
  • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

MacOS: Chrome / Safari

Screen.Recording.2026-10-09.at.2.20.48.AM.mov

[melvin-bot]

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

1. Look at the code and make sure there are no malicious changes.
2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx bun ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx bun ./scripts/generateTranslations.ts --compare-ref main

[codecov]

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	95.90% <ø> (ø)
src/ONYXKEYS.ts	100.00% <ø> (ø)
src/components/DeferredGlobalModals.tsx	100.00% <ø> (ø)
...s/WorkspaceListTable/WorkspaceRowThreeDotsMenu.tsx	65.88% <100.00%> (ø)
src/components/WorkspaceMemberRoleList.tsx	100.00% <ø> (ø)
src/hooks/useDefaultExpensePolicy.tsx	92.30% <100.00%> (+0.64%)	⬆️
src/hooks/usePolicyForMovingExpenses.ts	94.44% <100.00%> (-0.30%)	⬇️
src/libs/ExportOnyxState/masking.ts	80.95% <ø> (ø)
src/libs/OptionsListUtils/index.ts	91.89% <100.00%> (+0.02%)	⬆️
src/libs/PolicyUtils/permissions.ts	100.00% <100.00%> (ø)
... and 15 more
... and 10 files with indirect coverage changes

[melvin-bot]

@brunovjk @flodnv One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[lanitochka17]

Deploy Blocker #104902 was identified to be related to this PR.

[jponikarchuk]

Deploy Blocker #104903 was identified to be related to this PR.

[jponikarchuk]

Deploy Blocker #104907 was identified to be related to this PR.

[lanitochka17]

Deploy Blocker #104912 was identified to be related to this PR.

[lanitochka17]

Deploy Blocker #104914 was identified to be related to this PR.

[lanitochka17]

Deploy Blocker ##104917 was identified to be related to this PR.

[mitarachim]

Deploy Blocker ##104943 was identified to be related to this PR.

[mitarachim]

Deploy Blocker ##104944 was identified to be related to this PR.

[mitarachim]

Deploy Blocker ##104945 was identified to be related to this PR.

[mitarachim]

@ShridharGoel This PR is failing in offline test because of a regression issue #104946

The issue is reproducible in: web, Android, iOS

Bug7294861_1792793866553.Recording__2612.mp4

[mitarachim]

Deploy Blocker ##104948 was identified to be related to this PR.

[mitarachim]

Deploy Blocker ##104949 was identified to be related to this PR.

[mitarachim]

Deploy Blocker ##104959 was identified to be related to this PR.

[inimaga]

This PR is linked to a very high number of deploy blockers so unfortunately has to be reverted.

[ShridharGoel]

@inimaga We are removing the option to assign this new role, hence a revert is not needed.

[OSBotify]

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.5.20-5 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

Bundle Size Analysis (Sentry):

• Android
• iOS

[melvin-bot]

🤖 Payment issue created: #105068