Skip to content

Workspace - Rooms page is empty when opened as approve-only member #104943

Open
Open
Workspace - Rooms page is empty when opened as approve-only member#104943
Assignees
flodnvPujan92ShridharGoel
Labels
BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringOverdue

Description

@applause-bot
applause-bot
bot
opened on Oct 26, 2026

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.

Version Number: 9.5.20-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #102933
Email or phone of affected tester (no customers): sjdoinjdsojnsiojosn33@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • User A creates a Control workspace.
  • User B has a workspace.
  • User A invites User B to workspace with approve-only role.
  • Perform the steps below as User B:
  1. Go to staging.new.expensify.com
  2. Go to invited workspace settings > Rooms.

Expected Result:

Rooms will show available chat.

Actual Result:

Rooms page is empty when opened as approve-only member.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7294732_1792783309980.17.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Mita Rachim
Bug ID: 7294732

Issue OwnerCurrent Issue Owner: @ShridharGoel

Activity

  1. applause-bot
    added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 26, 2026

  2. applause-bot commented on Oct 26, 2026

    @applause-bot
    applause-botBot
    on Oct 26, 2026
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/d230c4d81a539171b3493630fdc8368a63f412772febe7f1dba99f406b91a349

  3. gleitebr
    added this to #expensify-bugson Oct 26, 2026

  4. melvin-bot commented on Oct 26, 2026

    @melvin-bot
    melvin-botBot
    on Oct 26, 2026 – with Melvin Bot

    @flodnv recently merged #102933, but they are OOO right now, so I'll auto-assign someone else.

  5. melvin-bot
    assigned
    grgia
    on Oct 26, 2026

  6. melvin-bot commented on Oct 26, 2026

    @melvin-bot
    melvin-botBot
    on Oct 26, 2026 – with Melvin Bot

    Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  7. melvin-bot
    assigned
    flodnv
    and
    Pujan92
    on Oct 26, 2026

  8. melvin-bot commented on Oct 26, 2026

    @melvin-bot
    melvin-botBot
    on Oct 26, 2026 – with Melvin Bot

    @flodnv @Pujan92 you have been assigned to this deploy blocker because you reviewed the offending PR: #102933

  9. github-actions
    added
    Engineering
    HourlyKSv2
    on Oct 26, 2026
  10. melvin-bot
    assigned
    ShridharGoel
    on Oct 26, 2026

  11. github-actions commented on Oct 26, 2026

    @github-actions
    github-actionsBot
    on Oct 26, 2026 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.

  12. melvin-bot commented on Oct 26, 2026

    @melvin-bot
    melvin-botBot
    on Oct 26, 2026 – with Melvin Bot

    @ShridharGoel you have been assigned to this deploy blocker because you authored the offending PR: #102933

  13. melvin-bot commented on Oct 26, 2026

    @melvin-bot
    melvin-botBot
    on Oct 26, 2026 – with Melvin Bot

    💬 A slack conversation has been started in #expensify-open-source

  14. MelvinBot commented on Oct 26, 2026

    @MelvinBot
    MelvinBot
    on Oct 26, 2026
    Contributor

    Deploy Blocker Analysis

    Causing PR: [Payment due @Pujan92] Add approve-only workspace role. It added the approve-only role, and this bug only affects that role.

    Root cause: Approve-only members get no workspace chat and no Rooms permission, so the Rooms page has nothing to show:

    1. permissions.ts:106-109 gives approve-only only OVERVIEW and MEMBERS. The Member role (:99-105) also gets AGENTS and ROOMS. The PR says approve-only has the "same read access as a member", so leaving out Rooms looks like an oversight.
    2. Member.ts:877-887 skips the workspace chat for roles that can't create expenses. That is intended, but it means the member's own workspace chat no longer appears on the page.

    Recommended fix (fix forward): Add AGENTS: READ and ROOMS: WRITE to the APPROVE_ONLY bundle in permissions.ts, and add a unit test. The rooms list comes from the server, so the backend must also return rooms for approve-only members. That part needs a separate internal check.

    If neither fix can land before the deploy, revert #102933.

    Investigation details
    • The Rooms page is not new in this release. WorkspaceRoomsPage.tsx:143-149 calls openPolicyRoomsPage for every role. WorkspaceRoomsPage.tsx:92 then shows the workspace rooms and chats stored on the device. This filter does not check the user's role.
    • [Payment due @nkdengineer] Add Guest workspace role changed the page so the server decides which rooms each role sees. Guests also lack ROOMS access, but they still see their own workspace chat. Approve-only members see neither.
    • On the App side, ROOMS permission only controls the Create button (WorkspaceRoomsPage.tsx:162). The App permission change alone won't fill the list.
    • Product may decide approve-only members should not see Rooms. In that case, hide the Rooms menu item for that role in getWorkspaceMenuItems.ts. Don't base that check on ROOMS permission alone, because guests lack it too and should still see the page.
    • I recommend fixing forward because the bug only affects a new role on Control workspaces, and reverting would undo a 49-file feature with a backend dependency.
    • Confidence: high that [Payment due @Pujan92] Add approve-only workspace role #102933 is the cause. Medium on the exact mechanism, because the backend's rooms filtering wasn't checked.

    view run

  15. ShridharGoel commented on Oct 26, 2026

    @ShridharGoel
    ShridharGoel
    on Oct 26, 2026
    Contributor

    This should be expected, I think an empty state was added but we can check why it is not showing

  16. jasperhuangg
    added
    DailyKSv2
    and removed
    DeployBlockerCashThis issue or pull request should block deployment
    HourlyKSv2
    on Oct 26, 2026

  17. m-natarajan commented on Oct 26, 2026

    @m-natarajan
    m-natarajan
    on Oct 26, 2026

    Not Reproducible
    Unable to reproduce - Approve-only no longer available
    iPhone 14 / iOS 26.6.2
    Version 9.5.20-4

    IMG_0009.MP4
  18. flodnv
    unassigned
    grgia
    on Oct 26, 2026

  19. melvin-bot commented on Oct 29, 2026

    @melvin-bot
    melvin-botBot
    on Oct 29, 2026 – with Melvin Bot

    @ShridharGoel Whoops! This issue is 2 days overdue. Let's get this updated quick!

  20. melvin-bot
    added
    Overdue
    on Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringOverdue

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions