Skip to content

Workspace - Workspace chat is not visible on member´s side when invited as "Approve-Only" #104944

Closed as not planned
Closed as not planned
Workspace - Workspace chat is not visible on member´s side when invited as "Approve-Only"#104944
Assignees
flodnvPujan92lakchoteShridharGoel
Labels
BugSomething is broken. Auto assigns a BugZero manager.EngineeringHourlyKSv2

Description

@applause-bot
applause-bot
bot
opened on Oct 26, 2026

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.

Version Number: 9.5.20-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #102933
Email or phone of affected tester (no customers): ibellicotest+3292@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Motorola MotoG60 / Android 12 (Hybrid app) - Windows 11 / Chrome
App Component: Workspace Settings

Action Performed:

Prerequisite: User A is owner of two "Control" workspaces. (Worksapce A and Workspace B)
Prerequisite 2: User B, already has a "Default" workspace.

  1. Open the staging.new.expensify.com website.
  2. Navigate to "Workspaces" > "Workspace A" > "Members"
  3. Invite User B as "Member" of the workspace.
  4. As User B, navigate to "Inbox"
  5. Note that the new workspace chat is displayed.
  6. As User A, click on User B on members list and edit role to "Approve-Only"
  7. As User B, note that workspace chat remains visible.
  8. As User A, navigate to "Workspace B" > "Members"
  9. Invite User B with "Approve-Only" role.
  10. As User B, note that new workspace chat is not visible on "Inbox"

Expected Result:

Workspace chat should be automatically visible on "Inbox" on member´s side, when invited with "Approve-Only" role.

Actual Result:

Workspace chat is not visible on member´s side when invited with "Approve-Only" role.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7294715_1792782113090.Approve_Only.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Mita Rachim
Bug ID: 7294715

Activity

  1. applause-bot
    added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 26, 2026

  2. applause-bot commented on Oct 26, 2026

    @applause-bot
    applause-botBot
    on Oct 26, 2026
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/33c805dba94109c0d5c7cb448ce5f83a5387432ce90cb3a2d69b80a7d8a198aa

  3. gleitebr
    added this to #expensify-bugson Oct 26, 2026

  4. melvin-bot commented on Oct 26, 2026

    @melvin-bot
    melvin-botBot
    on Oct 26, 2026 – with Melvin Bot

    @flodnv recently merged #102933, but they are OOO right now, so I'll auto-assign someone else.

  5. melvin-bot
    assigned
    lakchote
    on Oct 26, 2026

  6. melvin-bot commented on Oct 26, 2026

    @melvin-bot
    melvin-botBot
    on Oct 26, 2026 – with Melvin Bot

    Triggered auto assignment to @lakchote (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  7. github-actions
    added
    Engineering
    HourlyKSv2
    on Oct 26, 2026

  8. github-actions commented on Oct 26, 2026

    @github-actions
    github-actionsBot
    on Oct 26, 2026 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  9. melvin-bot
    assigned
    flodnv
    and
    Pujan92
    on Oct 26, 2026

  10. melvin-bot commented on Oct 26, 2026

    @melvin-bot
    melvin-botBot
    on Oct 26, 2026 – with Melvin Bot

    @flodnv @Pujan92 you have been assigned to this deploy blocker because you reviewed the offending PR: #102933

  11. melvin-bot
    assigned
    ShridharGoel
    on Oct 26, 2026

  12. melvin-bot commented on Oct 26, 2026

    @melvin-bot
    melvin-botBot
    on Oct 26, 2026 – with Melvin Bot

    @ShridharGoel you have been assigned to this deploy blocker because you authored the offending PR: #102933

  13. melvin-bot commented on Oct 26, 2026

    @melvin-bot
    melvin-botBot
    on Oct 26, 2026 – with Melvin Bot

    💬 A slack conversation has been started in #expensify-open-source

  14. MelvinBot commented on Oct 26, 2026

    @MelvinBot
    MelvinBot
    on Oct 26, 2026
    Contributor

    Deploy Blocker Investigation

    Verdict: Not a bug. Recommend removing DeployBlockerCash and closing as expected behavior. Don't revert.

    Causing PR: [Payment due @Pujan92] Add approve-only workspace role (High confidence). It adds the Approve-only role and intentionally skips the workspace chat for roles that can't create expenses.

    Why the chat is missing: The invite flow doesn't create a workspace chat for an Approve-only invitee. The chat isn't hidden in the Inbox; it never exists.

    Why steps 6-7 differ from step 10: Changing an existing member to Approve-only keeps their existing chat. Inviting someone directly as Approve-only creates no chat. Both match the intended design for this role.

    Investigation details
    • The PR was merged 2026-10-23 and is in the current staging deploy checklist.
    • The code comment came from an internal reviewer's suggestion during review, so the reviewers chose this behavior.
    • The PR's test and QA steps never say an Approve-only invitee gets a workspace chat.
    • The PR doesn't change Inbox/LHN filtering. It only hides create options inside the chat and removes the workspace from expense pickers.
    • If product decides Approve-only invitees should get a chat, that's a spec change for the App optimistic data and backend chat creation. It isn't a deploy-blocker fix.
    • No code-review rule is suggested because there's no defect.

    Next Steps: The assigned engineer should confirm with flodnv (internal reviewer, currently OOO) before removing DeployBlockerCash. Reply with @MelvinBot <your feedback> to refine this analysis.

    view run

  15. ShridharGoel commented on Oct 26, 2026

    @ShridharGoel
    ShridharGoel
    on Oct 26, 2026
    Contributor

    Expected

  16. ShridharGoel
    closed this as not plannedon Oct 26, 2026
  17. github-project-automation
    moved this to Done in #expensify-bugson Oct 26, 2026
  18. lakchote
    removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringHourlyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions