Skip to content

Run Velero discovery E2E with the Kubernetes Agent backend - #24645

Draft
nubtron wants to merge 1 commit into
masterfrom
nubtron/velero-kubernetes-agent-e2e
Draft

Run Velero discovery E2E with the Kubernetes Agent backend#24645
nubtron wants to merge 1 commit into
masterfrom
nubtron/velero-kubernetes-agent-e2e

Conversation

@nubtron

@nubtron nubtron commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

What does this PR do?

Stacks directly on #24639 and migrates Velero's static and discovery E2E coverage to the in-cluster KubernetesAgent backend.

The discovery test uses real Kubernetes container metadata and named ports, requires two discovered instances, and validates real Velero metrics and health through the standard dd_agent_check_discovery path. A separate boilerplate-style candidate-stability test runs every generated configuration for both the Velero server and node-agent through the standard dd_agent_check fixture and checks that the target pods remain healthy.

This layer adds the generated-configuration support Velero needs without depending on an unreleased base package. datadog_checks_dev now validates string-array inputs for local discovery strategies, and Velero provides a local from_named_ports strategy that preserves requested name order, filters unmatched ports, and deduplicates port numbers. The generated module therefore relies only on discovery APIs available since datadog-checks-base>=37.41.0.

Focused loader tests validate the local strategy schema, while a Velero behavioral test exercises the public VeleroCheck.generate_configs contract and verifies named-port ordering and filtering.

Motivation

This keeps the reusable Kubernetes Agent transport in #24639 independent from its integration consumers. The Kuma migration stacks on this layer in #24642. Velero demonstrates both static in-cluster checks and genuine Kubernetes Autodiscovery without introducing an integration-specific Agent lifecycle.

Validation

  • integrations-core pre-commit linters
  • discovery tooling and Kubernetes helper tests: 291 passed
  • local discovery-strategy schema tests: 2 passed
  • Velero unit and discovery suite with the local base package: 4 passed (3 E2E tests skipped outside an active environment)
  • Velero minimum-base compatibility with published datadog-checks-base==37.41.0: 4 passed (3 E2E tests skipped outside an active environment)
  • Velero configuration and generated-model validation
  • full Velero Kind E2E with local base package:
    • static dd_agent_check
    • dd_agent_check_discovery
    • environment cleanup
  • candidate-stability E2E coverage for both the Velero server and node-agent is included for the next active Kind/CI run

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add qa/required if this PR needs QA validation, or qa/skip-qa if it does not. Exactly one of the two is required.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Jul 22, 2026

Copy link
Copy Markdown

Tests  Code Coverage

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 82.93%
Overall Coverage: 88.61% (+0.09%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: a448d7e | Docs | View more details | Give us feedback!

@nubtron
nubtron force-pushed the nubtron/velero-kubernetes-agent-e2e branch from 302f9d5 to 45a59e0 Compare July 22, 2026 12:45
@nubtron
nubtron changed the base branch from nubtron/kubernetes-agent-interface-e2e to nubtron/kuma-kubernetes-agent-e2e July 22, 2026 12:45
@nubtron
nubtron force-pushed the nubtron/velero-kubernetes-agent-e2e branch from 45a59e0 to fefe824 Compare July 22, 2026 12:52
@nubtron
nubtron changed the base branch from nubtron/kuma-kubernetes-agent-e2e to nubtron/kubernetes-agent-interface-e2e July 22, 2026 12:52
@nubtron
nubtron force-pushed the nubtron/velero-kubernetes-agent-e2e branch 3 times, most recently from 3676060 to b9bcac0 Compare July 30, 2026 13:30
@nubtron
nubtron force-pushed the nubtron/kubernetes-agent-interface-e2e branch from 2a64043 to f21cf4c Compare August 10, 2026 09:28
@nubtron
nubtron force-pushed the nubtron/velero-kubernetes-agent-e2e branch from 7301542 to 16512f5 Compare August 10, 2026 09:34
Base automatically changed from nubtron/kubernetes-agent-interface-e2e to master August 10, 2026 17:43
@nubtron
nubtron force-pushed the nubtron/velero-kubernetes-agent-e2e branch from 16512f5 to a448d7e Compare August 18, 2026 10:33
@dd-octo-sts

dd-octo-sts Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Validation Report

All 21 validations passed.

Show details
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and code coverage settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
license-headers Validate Python files have proper license headers
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
qa-label Validate the pull request declares whether it needs QA for the next Agent release
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant