Run cert-manager E2E with the Kubernetes Agent backend - #24896
Draft
nubtron wants to merge 1 commit into
Draft
Conversation
Contributor
|
Contributor
Validation Report
Run Passed validations (20)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Runs the cert-manager Kind E2E with the Kubernetes Agent backend introduced by #24639.
openmetrics_endpoint(port 9402) has no matching Service, so it falls back to the pod IP of thecert-managerdeployment, fetched viakubectl get pods -n cert-manager --selector app.kubernetes.io/component=controller(falling back to--selector app=cert-managerif no pods match). The Agent now scrapeshttp://{controller_ip}:9402/metricsfrom inside the cluster instead of through akubectl port-forwardtunnel.ExitStack/port_forwardsetup; the Agent runs in a pod inside the kind cluster (agent_type: kubernetes), eliminating the port-forward startup race.Motivation
Reduces Kind E2E flakes caused by the Agent running outside the cluster with port forwarding, which introduces startup races (e.g.
Connection refusedto the forwarded endpoint). Running the Agent inside the cluster removes the port-forward dependency. See the cert-manager master flake on 2026-08-12 (test_check_ok—Connection refusedtohttp://10.1.0.253:36415/metrics), which is exactly the class this conversion eliminates.Follows the same pattern already applied to argo_workflows (#24827), fluxcd (#24829), and weaviate (#24830), plus the pod-IP fallback pattern from velero (#24645) for the port with no Service.
Review checklist (to be filled by reviewers)
qa/requiredif this PR needs QA validation, orqa/skip-qaif it does not. Exactly one of the two is required.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged