Skip to content

Run Argo Workflows E2E with the Kubernetes Agent backend - #24827

Merged
vitkyrka merged 3 commits into
masterfrom
vwhitchurch/argo_workflows-kubernetes-agent-e2e
Aug 17, 2026
Merged

Run Argo Workflows E2E with the Kubernetes Agent backend#24827
vitkyrka merged 3 commits into
masterfrom
vwhitchurch/argo_workflows-kubernetes-agent-e2e

Conversation

@vitkyrka

@vitkyrka vitkyrka commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Runs the Argo Workflows Kind E2E with the Kubernetes Agent backend introduced by #24639. workflow-controller has no backing Service, so the Agent (now running inside the Kind cluster) reaches it directly via the pod's IP address, fetched with kubectl get pods --namespace argo --selector app=workflow-controller --output json. The check now scrapes http://<pod-ip>:9090/metrics, so the external Docker Agent and the kubectl port-forward to workflow-controller are no longer needed.

Validation:

  • ddev test -fs argo_workflows
  • ddev --no-interactive test argo_workflows (3 passed, 1 E2E skipped)
  • ddev env show argo_workflows (py3.13)
  • ddev env start --dev argo_workflows py3.13
  • ddev env test --dev argo_workflows py3.13 (1 passed, 3 deselected)
  • ddev env stop argo_workflows py3.13

Motivation

This PR follows the conversion pattern from #24674 (argo_rollouts), adapted for a target with no Service: the pod IP is fetched directly, mirroring the approach used for Velero's node-agent DaemonSet in #24645. Running the Agent inside the same Kind cluster removes the long-lived host-side port-forward without changing the E2E setup, waits, instance shape, or assertions.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add qa/required if this PR needs QA validation, or qa/skip-qa if it does not. Exactly one of the two is required.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Convert the argo_workflows E2E environment to run the Agent inside
the Kind cluster instead of port-forwarding from the host. Since
workflow-controller has no backing Service, the pod IP is fetched
directly via kubectl and used to build the openmetrics_endpoint.

Environment: Datadog workspace

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@datadog-prod-us1-3

datadog-prod-us1-3 Bot commented Aug 11, 2026

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: a686e38 | Docs | Datadog PR Page | Give us feedback!

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Aug 11, 2026

Copy link
Copy Markdown

evalya-impact-summary

evalya impact analysis
Impact analysis: RUN-ALL — every test task will run
Trigger:         empty diff (default branch, scheduled run, or shallow-clone fallback)
Test tasks:      0 (all selected)
Publish tasks:   1 (always emitted)
Diff:            empty (no diff information)

Learn more about CI impact filtering

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: 76e1a88b2d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

CI failed because dd_environment re-runs get_workflow_controller_pod_ip()
on every invocation, including the one ddev env stop uses to tear down
the fixture after the Kind cluster is already deleted. Resolve the pod
IP once inside setup_argo_wf (which only runs on cluster creation) and
cache it with save_state/get_state, matching the pattern used by
velero's node-agent lookup.

Environment: Datadog workspace

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: 0a45fc3fb4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@vitkyrka
vitkyrka marked this pull request as ready for review August 12, 2026 08:02
@vitkyrka
vitkyrka requested a review from a team as a code owner August 12, 2026 08:02
@dd-octo-sts

dd-octo-sts Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Validation Report

All 21 validations passed.

Show details
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and code coverage settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
license-headers Validate Python files have proper license headers
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
qa-label Validate the pull request declares whether it needs QA for the next Agent release
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

@vitkyrka
vitkyrka added this pull request to the merge queue Aug 17, 2026
Merged via the queue into master with commit 4118f31 Aug 17, 2026
49 of 52 checks passed
@vitkyrka
vitkyrka deleted the vwhitchurch/argo_workflows-kubernetes-agent-e2e branch August 17, 2026 07:51
@dd-octo-sts dd-octo-sts Bot added this to the 7.83.0 milestone Aug 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants