fix: make the camera streamer opt-in and move snapshot out of protocols - #111
Merged
Conversation
This was referenced Aug 13, 2026
The Docker/RTSP streamer ignores cert_fingerprint, so a failed direct grab no longer falls through to it. X1 users must set camera_allow_streamer or pass --allow-camera-streamer. camera_direct_only still forbids the streamer even when the opt-in is set. The snapshot command, Docker lifecycle, and JSON envelopes now live in bambu_cli.commands.snapshot. protocols/camera.py is only the port-6000 grab.
DLANSAMA
force-pushed
the
refactor/aaa-pr2-snapshot
branch
from
August 13, 2026 03:14
fd4b621 to
6be67fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AAA stack 2/9. Stacked on #110.
The Docker/RTSP camera streamer is now opt-in. Snapshot command owns the Docker/JSON path;
protocols/camera.pyis only the port-6000 TLS grab.camera_allow_streameror--allow-camera-streamerSSLErrorwhen a pin is setStack: #110 → this → MQTT split → contracts → session reuse → Textual 8 / 3.10 → test stubs → sole error path → honesty