refactor: drop dead MQTT/FTPS leftovers and unify pin + redaction - #110
Merged
Conversation
Remove the unused PEM exporter and trusted-cert global from mqtt.py, and delete the FTPS connection pool that only doctor used. Every FTP caller now goes through BambuPrinter.get_ftp_client, which closes instead of quit() so Bambu's hanging control-channel shutdown cannot stall teardown. Fingerprint normalization has one implementation (tlspin); config and context delegate. emit_json uses jsonio.redact_url_credentials, so credential URLs lose userinfo instead of the weaker ***@ form.
This was referenced Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AAA stack 1/9. Base:
main(includes #108).Dead-code and unification pass. No behaviour change for a working printer.
_TRUSTED_CERT_FILEleftoversget_ftp_clientcloses instead ofquittlspin.normalize_fingerprintemit_jsonusesjsonio.redact_url_credentialsinstead of a second copyassert_shapehelperStack (merge in order):
PinningSSLContextLocal gates on the full stack: ruff, mypy, bandit, layers, schemas,
pytest -W error::ResourceWarning -m "not live"— 1436 passed, 88.91% coverage.