test: stop stubbing paho in sys.modules - #116
Merged
Merged
Conversation
This was referenced Aug 13, 2026
DLANSAMA
force-pushed
the
refactor/aaa-pr7-test-stubs
branch
from
August 13, 2026 02:45
b1fe46f to
3d42e67
Compare
DLANSAMA
force-pushed
the
refactor/aaa-pr6-textual-py310
branch
from
August 13, 2026 03:49
9a3ba4b to
0feec78
Compare
paho-mqtt is a hard runtime dependency. Tests import the real package. Audit-named files are renamed to topic names (jsonio, config_secrets, cli_envelopes, platform_paths).
DLANSAMA
force-pushed
the
refactor/aaa-pr7-test-stubs
branch
from
August 13, 2026 04:03
3d42e67 to
4befde7
Compare
DLANSAMA
added a commit
that referenced
this pull request
Aug 14, 2026
Re-verified the 2026-07-31 post-audit residual table against current main rather than trusting the audit snapshot. Four residuals it lists as open are closed, and one the follow-up notes recorded as closed is not: - S5 closed: utils.py:63-67 is now a shim delegating to jsonio; both spellings redact the audit's own repro identically. No weaker second implementation. - A4 closed: mqtt_port is wired end to end (context -> printer -> mqtt_tls _mqtt_port -> client.connect). Doctor no longer reports a port it ignores. - T1 closed: textual is pinned >=8.0,<9.0 (#115), not <2.0. - A3/Q1/S1/B1/R1/R3 closed by #119, the camera opt-in work, and the TUI merge. - Q4 NOT closed: #116 removed 81 setdefault stubs across 33 files but tests/bambu_test_base.py:26-29 still assigns MagicMock to sys.modules for paho at import time and never restores it, which is also order-dependent. - P1, Q5, Q6, A1, A2, S3, R2, T2/WS4, W3.4 re-confirmed open with current file:line evidence; A1's target moved to bambu_cli.cliparse. Plan headers carried numbers from before #119/#120 and read as live state. Both gameplans now lead with measured current values (1499 non-live, 90.99% Linux / 90.68% Windows over 8368 statements, floor 86, Python 3.10/3.12/3.14) and keep the old figures marked as historical, including the a-plus W1 sizing that was derived from the 89.4% baseline. mutation-baseline.md claimed its per-module table reconciles to the 50.7% headline. It does not: the seven rows are the whole only_mutate scope yet sum to 2010 mutants against a headline 2091, leaving 81 unattributed (37 survived, 41 killed, 3 timeout). Also corrected the "residual survivors should be cosmetic" prediction, which the same file already disproves at 21.8% with 269 survivors, and the stale "re-run mutmut on slicer/output.py" note, which was already done on 2026-08-04. tui-plan.md kept imperative branch instructions after its own "implemented" banner; folded into the historical framing. Also drops AI-vendor attribution from these two plan docs: the audience and source lines, the "pasteable brief for a new <vendor> session" heading, and the trailer rule, which now reads "AI/session attribution trailers" instead of naming a product. References to the local-only agent notes filename are left intact where removing the name would void the rule. Docs only, no code changes. Gates: 1499 passed / 1 deselected, 91.0% total; test_docs_consistency + test_docs_links 25 passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AAA stack 7/9. Stacked on #115.
Strip the ~90
sys.modules.setdefault(\"paho…\")stubs. Tests import the real paho client (already a runtime dependency). Rename leftovertest_audit_*modules to names that say what they test:test_jsonio.py,test_config_secrets.py,test_cli_envelopes.py,test_platform_paths.py.Stack: #110 → #111 → #112 → #113 → #114 → #115 → this → sole error path → honesty