fix(liquidity): skip exchanges without API credentials in balance polling

[Danswar]

Problem

The liquidity-management exchange adapter polls every exchange's balance on each cycle. When an exchange has no API credentials configured — e.g. XT on dev, where XT_KEY/XT_SECRET are unset — the ccxt call throws AuthenticationError: xt requires "apiKey" credential. The adapter logged this as ERROR and re-threw it, producing roughly 60 error logs per hour, indefinitely. The app was asking an exchange for a balance using credentials it doesn't have.

Fix

• Add an isConfigured getter to ExchangeService, returning true only when both ccxt credentials are present (apiKey and secret).
• In ExchangeAdapter.getForExchange(), if the resolved exchange service is not configured, skip it gracefully: return empty balances for those assets instead of calling getBalances(), and log a single WARN per exchange (guarded by an "already warned" set) rather than an ERROR every cycle.
• The "configured but the call failed" case is unchanged — it still logs ERROR and propagates, since that's a real error.

This is general, not XT-specific: it applies to every exchange and self-heals per environment (dev simply doesn't need XT keys). ScryptService does not extend ExchangeService and has no isConfigured, so it is treated as configured/unchanged.

Safety note

A genuinely misconfigured prod exchange (keys missing by mistake) is not silently swallowed — it still surfaces a WARN once, so the misconfiguration remains visible.

Tests

• tsc --noEmit: passes.
• src/integration/exchange Jest suites pass, including 3 new isConfigured cases (no creds / apiKey only / both creds) added to exchange.service.spec.ts.

Files changed

• src/integration/exchange/services/exchange.service.ts — isConfigured getter
• src/subdomains/core/liquidity-management/adapters/balances/exchange.adapter.ts — skip + warn-once
• src/integration/exchange/services/__tests__/exchange.service.spec.ts — unit tests

[github-actions]

⚠️ Unverified Commits (1)

The following commits are not signed/verified:

• 0d2585a Skip exchanges with no API credentials in liquidity balance polling (Daniel Padrino)

How to sign commits

# SSH signing (recommended)
git config --global gpg.format ssh
git config --global user.signingkey ~/.ssh/id_ed25519.pub
git config --global commit.gpgsign true

# Re-sign last commit
git commit --amend -S --no-edit
git push --force-with-lease

[davidleomay]

The 'isConfigured' in exchangeService duck-type check is fragile. Since getExchange returns ExchangeService | ScryptService, ScryptService could define its own isConfigured (checking GetConfig().scrypt.apiKey / apiSecret, same pattern) and ExchangeService could declare it abstractly. Then the adapter simplifies to if (!exchangeService.isConfigured) — no in guard needed.

[davidleomay]

'isConfigured' in exchangeService guards against ScryptService not having the getter. If ScryptService defined its own isConfigured (checking its own GetConfig().scrypt credentials) and ExchangeService declared it abstractly, this becomes if (!exchangeService.isConfigured) — cleaner and less fragile.

[Danswar]

Done in 0ee5edf — isConfigured is now part of the type contract: a getter on ExchangeService (checks the ccxt apiKey/secret) and ScryptService defines its own against GetConfig().scrypt. The adapter is now a plain if (!exchangeService.isConfigured), no in guard. CI green.