fix(liquidity): skip unconfigured exchanges instead of reporting zero balances#3870
Merged
Merged
Conversation
… balances Returning LiquidityBalance.create(a, 0, 0) for exchanges without API credentials persists fake zero balances via saveBalanceResults. If a configured exchange ever loses its credentials (env regression), the rules would see a sudden zero balance and could trigger rebalancing pipelines towards an exchange we cannot even query — with only a single warn log per process lifetime as a hint. Return no balances instead: verifyRule already handles a missing balance gracefully (info log, rule skipped).
davidleomay
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Follow-up to #3859:
getForExchangereturnsLiquidityBalance.create(a, 0, 0)for exchanges without API credentials. These fake zeros are persisted bysaveBalanceResultsand are visible to rule evaluation.If a configured exchange ever loses its credentials (env regression), rules would see a sudden zero balance and could trigger rebalancing pipelines towards an exchange we cannot even query — with only a single warn log per process lifetime as a hint. A missing value must not be reported as
0.Fix
Return
[]instead — no balances are reported or persisted for unconfigured exchanges.verifyRulealready handles this gracefully:findRelevantBalancefinds nothing, logsbalance not found(info) and skips the rule. Same skip semantics as intended by #3859, without inventing a value.Checks
format:check,type-check,lintclean