Skip to content

fix(liquidity): skip unconfigured exchanges instead of reporting zero balances #3870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidleomay merged 1 commit into from
Jun 11, 2026
Merged

fix(liquidity): skip unconfigured exchanges instead of reporting zero balances #3870

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/subdomains/core/liquidity-management/adapters/balances/exchange.adapter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,14 +62,15 @@ export class ExchangeAdapter implements LiquidityBalanceIntegration {
async getForExchange(exchange: string, assets: LiquidityManagementAsset[]): Promise<LiquidityBalance[]> {
const exchangeService = this.exchangeRegistry.getExchange(exchange);

// not configured (no API credentials) -> skip gracefully, warn once
// not configured (no API credentials) -> skip, warn once. No balances are reported on purpose:
// a zero balance would be persisted and could trigger liquidity rules, masking a config error
if (!exchangeService.isConfigured) {
if (!this.unconfiguredWarned.has(exchange)) {
this.unconfiguredWarned.add(exchange);
this.logger.warn(`Exchange ${exchange} has no credentials configured — skipping liquidity balance`);
}

return assets.map((a) => LiquidityBalance.create(a, 0, 0));
return [];
}

try {
Expand Down