fix(buy-fiat): log incomplete-creditor skips at WARN, not ERROR#3866
Closed
Danswar wants to merge 1 commit into
Closed
fix(buy-fiat): log incomplete-creditor skips at WARN, not ERROR#3866Danswar wants to merge 1 commit into
Danswar wants to merge 1 commit into
Conversation
addFiatOutputs (#3858) isolates per-record failures, but a buy-fiat with incomplete creditor data (missing IBAN/address/etc.) then logs at ERROR every cycle — a handled skip, not a failure. Log those at WARN; unexpected errors still surface as ERROR so a real outage stays visible.
Danswar
force-pushed
the
fix/buy-fiat-skip-warn
branch
from
1f6ac03 to
8af8e80
Compare
Member
|
This is a DEV phenomena, should stay an error on PRD. Cleaned up the data and closing this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#3858 made
addFiatOutputsisolate per-record failures (so one bad record no longer aborts the whole payout run — correct). But the most common per-record failure is a buy-fiat with incomplete creditor data (missing IBAN/address/etc.), and that is now logged at ERROR every cycle for every affected record. On dfxdev this turned the old single abort/min into ~200 ERROR/hr (BuyFiat 418/480/485/518/519…"Missing required creditor fields").Change
Incomplete creditor data is a handled skip (the record is retried next cycle once details are provided), not a failure — so log it at WARN. Unexpected errors still log at ERROR, so a real outage stays visible (same skip-vs-real-error split as the exchange-credentials guard in #3859).
isIncompleteCreditorData(e)matches theMissing required creditor fieldsvalidation error thrown byFiatOutputService.createInternal; both the immediate and batched payout catch blocks branch on it.Verification
npx tsc --noEmit— cleanjest buy-fiat— 4/4 pass