Skip to content

fix(buy-fiat): log incomplete-creditor skips at WARN, not ERROR #3866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Danswar wants to merge 1 commit into from
Closed

fix(buy-fiat): log incomplete-creditor skips at WARN, not ERROR #3866

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions src/subdomains/core/sell-crypto/process/services/buy-fiat-preparation.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,11 @@ export class BuyFiatPreparationService {
try {
await this.fiatOutputService.createInternal(FiatOutputType.BUY_FIAT, { buyFiats: [buyFiat] }, buyFiat.id);
} catch (e) {
this.logger.error(`Error during buy-fiat ${buyFiat.id} fiat output creation:`, e);
if (this.isIncompleteCreditorData(e)) {
this.logger.warn(`Skipped buy-fiat ${buyFiat.id} fiat output creation (incomplete creditor data):`, e);
} else {
this.logger.error(`Error during buy-fiat ${buyFiat.id} fiat output creation:`, e);
}
}
}

Expand Down Expand Up @@ -492,11 +496,23 @@ export class BuyFiatPreparationService {
buyFiats[0].userData.paymentLinksConfigObj.ep2ReportContainer != null,
);
} catch (e) {
this.logger.error(`Error during buy-fiat ${buyFiats[0].id} batched fiat output creation:`, e);
if (this.isIncompleteCreditorData(e)) {
this.logger.warn(
`Skipped buy-fiat ${buyFiats[0].id} batched fiat output creation (incomplete creditor data):`,
e,
);
} else {
this.logger.error(`Error during buy-fiat ${buyFiats[0].id} batched fiat output creation:`, e);
}
}
}
}

// Incomplete creditor data is a handled skip (retried next cycle), not a failure.
private isIncompleteCreditorData(e: unknown): boolean {
return e instanceof Error && e.message.includes('Missing required creditor fields');
}

async chargebackTx(): Promise<void> {
const entities = await this.buyFiatRepo.find({
where: {
Expand Down